All of lore.kernel.org
 help / color / mirror / Atom feed
From: <gregkh@linuxfoundation.org>
To: gregkh@linuxfoundation.org, chris@chris-wilson.co.uk,
	mika.kuoppala@intel.com, przanoni@gmail.com
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "drm/i915: fix compiler warning in drivers/gpu/drm/i915/intel_uncore.c" has been added to the 4.4-stable tree
Date: Thu, 31 Aug 2017 08:34:34 +0200	[thread overview]
Message-ID: <150416127416148@kroah.com> (raw)


This is a note to let you know that I've just added the patch titled

    drm/i915: fix compiler warning in drivers/gpu/drm/i915/intel_uncore.c

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     drm-i915-fix-compiler-warning-in-drivers-gpu-drm-i915-intel_uncore.c.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From foo@baz Thu Aug 31 08:30:43 CEST 2017
Date: Thu, 31 Aug 2017 08:30:43 +0200
To: Greg KH <gregkh@linuxfoundation.org>
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: drm/i915: fix compiler warning in drivers/gpu/drm/i915/intel_uncore.c

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

When building with gcc-7, the following warning happens:

drivers/gpu/drm/i915/intel_uncore.c: In function ‘hsw_unclaimed_reg_detect’:
drivers/gpu/drm/i915/intel_uncore.c:638:36: warning: decrement of a boolean expression [-Wbool-operation]
   i915.mmio_debug = mmio_debug_once--;
                                    ^~

As it's really not wise to -- on a boolean value.

Commit 7571494004d8 ("drm/i915: Do one shot unclaimed mmio detection
less frequently") which showed up in 4.6-rc1 does solve this issue, by
rewriting the mmio detection logic, but that isn't really good to
backport to 4.4-stable, so just fix up the obvious logic here to do the
right thing.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Paulo Zanoni <przanoni@gmail.com>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/gpu/drm/i915/intel_uncore.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -635,7 +635,8 @@ hsw_unclaimed_reg_detect(struct drm_i915
 			  "enabling oneshot unclaimed register reporting. "
 			  "Please use i915.mmio_debug=N for more information.\n");
 		__raw_i915_write32(dev_priv, FPGA_DBG, FPGA_DBG_RM_NOCLAIM);
-		i915.mmio_debug = mmio_debug_once--;
+		i915.mmio_debug = mmio_debug_once;
+		mmio_debug_once = false;
 	}
 }
 


Patches currently in stable-queue which might be from gregkh@linuxfoundation.org are

queue-4.4/scsi-sg-protect-accesses-to-reserved-page-array.patch
queue-4.4/drm-i915-fix-compiler-warning-in-drivers-gpu-drm-i915-intel_uncore.c.patch
queue-4.4/lpfc-fix-device-discovery-failures-during-switch-reboot-test.patch
queue-4.4/p54-memset-0-whole-array.patch
queue-4.4/btrfs-remove-duplicate-const-specifier.patch
queue-4.4/alsa-au88x0-fix-zero-clear-of-stream-resources.patch
queue-4.4/x86-io-add-memory-clobber-to-insb-insw-insl-outsb-outsw-outsl.patch
queue-4.4/gcov-add-support-for-gcc-version-6.patch
queue-4.4/gcov-support-gcc-7.1.patch
queue-4.4/arm64-fpsimd-prevent-registers-leaking-across-exec.patch
queue-4.4/scsi-isci-avoid-array-subscript-warning.patch
queue-4.4/lightnvm-initialize-ppa_addr-in-dev_to_generic_addr.patch
queue-4.4/arm64-mm-abort-uaccess-retries-upon-fatal-signal.patch
queue-4.4/i2c-jz4780-drop-superfluous-init.patch
queue-4.4/scsi-sg-reset-res_in_use-after-unlinking-reserved-array.patch

                 reply	other threads:[~2017-08-31  6:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150416127416148@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=mika.kuoppala@intel.com \
    --cc=przanoni@gmail.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.