diff for duplicates of <1504186436.15555.24.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index 392186a..a0831fc 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -5,9 +5,9 @@ And if you don't could you please apply it. Thanks. -On Mon, 2017-08-21@19:22 +0300, Eugeniy Paltsev wrote: +On Mon, 2017-08-21 at 19:22 +0300, Eugeniy Paltsev wrote: > For now baud field of earlycon structure device is't initialised at all -> in of_setup_earlycon (in opposit? to register_earlycon). +> in of_setup_earlycon (in oppositе to register_earlycon). > > So when I use stdout-path to point earlycon device > (like stdout-path = &serial or stdout-path = "serial:115200n8") @@ -22,14 +22,14 @@ On Mon, 2017-08-21@19:22 +0300, Eugeniy Paltsev wrote: > "current-speed" property from device tree or from options > (if they exist) when we use of_setup_earlycon > -> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com> +> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> > --- > Changes v2 -> v3: -> ?* Use simple_strtoul instead of kstrtoul as with kstrtoul we can't parse -> ???options string which includes arguments except baudrate (like "115200n8") +> * Use simple_strtoul instead of kstrtoul as with kstrtoul we can't parse +> options string which includes arguments except baudrate (like "115200n8") > > Changes v1 -> v2: -> ?* Use standart property name "current-speed" instead of custom "baud" +> * Use standart property name "current-speed" instead of custom "baud" > > NOTE: > I don't add parsing of the other standard options here because we don't @@ -40,25 +40,25 @@ On Mon, 2017-08-21@19:22 +0300, Eugeniy Paltsev wrote: > register such callbacks for earlycon. So we are only able to parse baud > value, which can be stored in baud field of earlycon_device structure. > -> ?drivers/tty/serial/earlycon.c | 5 +++++ -> ?1 file changed, 5 insertions(+) +> drivers/tty/serial/earlycon.c | 5 +++++ +> 1 file changed, 5 insertions(+) > > diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c > index c365154..82e813b 100644 > --- a/drivers/tty/serial/earlycon.c > +++ b/drivers/tty/serial/earlycon.c > @@ -282,7 +282,12 @@ int __init of_setup_earlycon(const struct earlycon_id *match, -> ? } -> ? } -> ? +> } +> } +> > + val = of_get_flat_dt_prop(node, "current-speed", NULL); > + if (val) > + early_console_dev.baud = be32_to_cpu(*val); > + -> ? if (options) { +> if (options) { > + early_console_dev.baud = simple_strtoul(options, NULL, 0); -> ? strlcpy(early_console_dev.options, options, -> ? sizeof(early_console_dev.options)); -> ? } +> strlcpy(early_console_dev.options, options, +> sizeof(early_console_dev.options)); +> } -- -?Eugeniy Paltsev + Eugeniy Paltsev diff --git a/a/content_digest b/N1/content_digest index 03afa1a..ad50cdd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,12 @@ "ref\020170821162213.27102-1-Eugeniy.Paltsev@synopsys.com\0" - "From\0Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev)\0" - "Subject\0[PATCH v3] earlycon: initialise baud field of earlycon device structure\0" + "From\0Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>\0" + "Subject\0Re: [PATCH v3] earlycon: initialise baud field of earlycon device structure\0" "Date\0Thu, 31 Aug 2017 13:33:56 +0000\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0linux-serial@vger.kernel.org <linux-serial@vger.kernel.org>\0" + "Cc\0linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>" + jslaby@suse.com <jslaby@suse.com> + gregkh@linuxfoundation.org <gregkh@linuxfoundation.org> + " linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org>\0" "\00:1\0" "b\0" "Hi,\n" @@ -12,9 +16,9 @@ "\n" "Thanks.\n" "\n" - "On Mon, 2017-08-21@19:22 +0300, Eugeniy Paltsev wrote:\n" + "On Mon, 2017-08-21 at 19:22 +0300, Eugeniy Paltsev wrote:\n" "> For now baud field of earlycon structure device is't initialised at all\n" - "> in of_setup_earlycon (in opposit? to register_earlycon).\n" + "> in of_setup_earlycon (in opposit\320\265 to register_earlycon).\n" "> \n" "> So when I use stdout-path to point earlycon device\n" "> (like stdout-path = &serial or stdout-path = \"serial:115200n8\")\n" @@ -29,14 +33,14 @@ "> \"current-speed\" property from device tree or from options\n" "> (if they exist) when we use of_setup_earlycon\n" "> \n" - "> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>\n" + "> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>\n" "> ---\n" "> Changes v2 -> v3:\n" - "> ?* Use simple_strtoul instead of kstrtoul as with kstrtoul we can't parse\n" - "> ???options string which includes arguments except baudrate (like \"115200n8\")\n" + "> \302\240* Use simple_strtoul instead of kstrtoul as with kstrtoul we can't parse\n" + "> \302\240\302\240\302\240options string which includes arguments except baudrate (like \"115200n8\")\n" "> \n" "> Changes v1 -> v2:\n" - "> ?* Use standart property name \"current-speed\" instead of custom \"baud\"\n" + "> \302\240* Use standart property name \"current-speed\" instead of custom \"baud\"\n" "> \n" "> NOTE:\n" "> I don't add parsing of the other standard options here because we don't\n" @@ -47,27 +51,27 @@ "> register such callbacks for earlycon. So we are only able to parse baud\n" "> value, which can be stored in baud field of earlycon_device structure.\n" "> \n" - "> ?drivers/tty/serial/earlycon.c | 5 +++++\n" - "> ?1 file changed, 5 insertions(+)\n" + "> \302\240drivers/tty/serial/earlycon.c | 5 +++++\n" + "> \302\2401 file changed, 5 insertions(+)\n" "> \n" "> diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c\n" "> index c365154..82e813b 100644\n" "> --- a/drivers/tty/serial/earlycon.c\n" "> +++ b/drivers/tty/serial/earlycon.c\n" "> @@ -282,7 +282,12 @@ int __init of_setup_earlycon(const struct earlycon_id *match,\n" - "> ?\t\t}\n" - "> ?\t}\n" - "> ?\n" + "> \302\240\t\t}\n" + "> \302\240\t}\n" + "> \302\240\n" "> +\tval = of_get_flat_dt_prop(node, \"current-speed\", NULL);\n" "> +\tif (val)\n" "> +\t\tearly_console_dev.baud = be32_to_cpu(*val);\n" "> +\n" - "> ?\tif (options) {\n" + "> \302\240\tif (options) {\n" "> +\t\tearly_console_dev.baud = simple_strtoul(options, NULL, 0);\n" - "> ?\t\tstrlcpy(early_console_dev.options, options,\n" - "> ?\t\t\tsizeof(early_console_dev.options));\n" - "> ?\t}\n" + "> \302\240\t\tstrlcpy(early_console_dev.options, options,\n" + "> \302\240\t\t\tsizeof(early_console_dev.options));\n" + "> \302\240\t}\n" "-- \n" - ?Eugeniy Paltsev + "\302\240Eugeniy Paltsev" -da3e8e115d8afa98fa4a7462b7d77952345a34e77ba09878baee5e66b442bd8a +fd4c6d468ab2aabaf02f3bcef7aa1aa339f4178d949be90b842f96a7208b8b3b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.