diff for duplicates of <1504197268.3799.8.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index fbdf9c9..35053ac 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,6 @@ Hi Vineet, -On Thu, 2017-08-31@09:31 -0700, Vineet Gupta wrote: +On Thu, 2017-08-31 at 09:31 -0700, Vineet Gupta wrote: > On 08/31/2017 07:22 AM, Alexey Brodkin wrote: > > > > This is useful to make sure no stale data exists in caches after bootloaders. @@ -8,30 +8,30 @@ On Thu, 2017-08-31@09:31 -0700, Vineet Gupta wrote: > > for example during DDR recalibration and never unlocked. This may lead > > to really unpredictable issues later down the line. > > -> > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com> +> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> > > --- -> > ? arch/arc/kernel/head.S | 16 ++++++++++++++++ -> > ? 1 file changed, 16 insertions(+) +> > arch/arc/kernel/head.S | 16 ++++++++++++++++ +> > 1 file changed, 16 insertions(+) > > > > diff --git a/arch/arc/kernel/head.S b/arch/arc/kernel/head.S > > index 8b90d25a15cc..04e28b664183 100644 > > --- a/arch/arc/kernel/head.S > > +++ b/arch/arc/kernel/head.S > > @@ -34,6 +34,10 @@ -> > ? #endif -> > ?? sr r5, [ARC_REG_IC_CTRL] -> > ?? +> > #endif +> > sr r5, [ARC_REG_IC_CTRL] +> > > > + ; Invalidate entire I$ > > + mov r5, 1 > > + sr r5, [ARC_REG_IC_IVIC] > > + -> > ? 1: -> > ?? lr r5, [ARC_REG_DC_BCR] -> > ?? breq????r5, 0, 1f ; D$ doesn't exist +> > 1: +> > lr r5, [ARC_REG_DC_BCR] +> > breq r5, 0, 1f ; D$ doesn't exist > > @@ -46,6 +50,18 @@ -> > ? #endif -> > ?? sr r5, [ARC_REG_DC_CTRL] -> > ?? +> > #endif +> > sr r5, [ARC_REG_DC_CTRL] +> > > > + ; Flush entire D$ > > + mov r5, 1 > > + sr r5, [ARC_REG_DC_FLSH] @@ -45,9 +45,9 @@ On Thu, 2017-08-31@09:31 -0700, Vineet Gupta wrote: > > + sr r5, [ARC_REG_DC_IVDC] > > + > -> AFAIK uboot already flushes the caches before handing control over to kernel - so? +> AFAIK uboot already flushes the caches before handing control over to kernel - so > why do we need it here. -> If uboot is locking lines, it needs to fix that and not penalize the general case? +> If uboot is locking lines, it needs to fix that and not penalize the general case > with or w/o uboot ! U-Boot indeed flushes caches.. but doesn't invalidate them! diff --git a/a/content_digest b/N1/content_digest index e7afa25..2d8cefb 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,14 +1,16 @@ "ref\020170831142158.27245-1-abrodkin@synopsys.com\0" "ref\07a5267e3-c012-7bfd-ced2-cfaa3f47524a@synopsys.com\0" - "From\0Alexey.Brodkin@synopsys.com (Alexey Brodkin)\0" - "Subject\0[PATCH] arc: Flush and invalidate caches on start\0" + "From\0Alexey Brodkin <Alexey.Brodkin@synopsys.com>\0" + "Subject\0Re: [PATCH] arc: Flush and invalidate caches on start\0" "Date\0Thu, 31 Aug 2017 16:34:29 +0000\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0Vineet Gupta <Vineet.Gupta1@synopsys.com>\0" + "Cc\0linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>" + " linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org>\0" "\00:1\0" "b\0" "Hi Vineet,\n" "\n" - "On Thu, 2017-08-31@09:31 -0700, Vineet Gupta wrote:\n" + "On Thu, 2017-08-31 at 09:31 -0700, Vineet Gupta wrote:\n" "> On 08/31/2017 07:22 AM, Alexey Brodkin wrote:\n" "> > \n" "> > This is useful to make sure no stale data exists in caches after bootloaders.\n" @@ -16,30 +18,30 @@ "> > for example during DDR recalibration and never unlocked. This may lead\n" "> > to really unpredictable issues later down the line.\n" "> > \n" - "> > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>\n" + "> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>\n" "> > ---\n" - "> > ? arch/arc/kernel/head.S | 16 ++++++++++++++++\n" - "> > ? 1 file changed, 16 insertions(+)\n" + "> > \302\240 arch/arc/kernel/head.S | 16 ++++++++++++++++\n" + "> > \302\240 1 file changed, 16 insertions(+)\n" "> > \n" "> > diff --git a/arch/arc/kernel/head.S b/arch/arc/kernel/head.S\n" "> > index 8b90d25a15cc..04e28b664183 100644\n" "> > --- a/arch/arc/kernel/head.S\n" "> > +++ b/arch/arc/kernel/head.S\n" "> > @@ -34,6 +34,10 @@\n" - "> > ? #endif\n" - "> > ??\tsr\tr5, [ARC_REG_IC_CTRL]\n" - "> > ??\n" + "> > \302\240 #endif\n" + "> > \302\240\302\240\tsr\tr5, [ARC_REG_IC_CTRL]\n" + "> > \302\240\302\240\n" "> > +\t; Invalidate entire I$\n" "> > +\tmov\tr5, 1\n" "> > +\tsr\tr5, [ARC_REG_IC_IVIC]\n" "> > +\n" - "> > ? 1:\n" - "> > ??\tlr\tr5, [ARC_REG_DC_BCR]\n" - "> > ??\tbreq????r5, 0, 1f\t\t; D$ doesn't exist\n" + "> > \302\240 1:\n" + "> > \302\240\302\240\tlr\tr5, [ARC_REG_DC_BCR]\n" + "> > \302\240\302\240\tbreq\302\240\302\240\302\240\302\240r5, 0, 1f\t\t; D$ doesn't exist\n" "> > @@ -46,6 +50,18 @@\n" - "> > ? #endif\n" - "> > ??\tsr\tr5, [ARC_REG_DC_CTRL]\n" - "> > ??\n" + "> > \302\240 #endif\n" + "> > \302\240\302\240\tsr\tr5, [ARC_REG_DC_CTRL]\n" + "> > \302\240\302\240\n" "> > +\t; Flush entire D$\n" "> > +\tmov\tr5, 1\n" "> > +\tsr\tr5, [ARC_REG_DC_FLSH]\n" @@ -53,9 +55,9 @@ "> > +\tsr\tr5, [ARC_REG_DC_IVDC]\n" "> > +\n" "> \n" - "> AFAIK uboot already flushes the caches before handing control over to kernel - so?\n" + "> AFAIK uboot already flushes the caches before handing control over to kernel - so\302\240\n" "> why do we need it here.\n" - "> If uboot is locking lines, it needs to fix that and not penalize the general case?\n" + "> If uboot is locking lines, it needs to fix that and not penalize the general case\302\240\n" "> with or w/o uboot !\n" "\n" "U-Boot indeed flushes caches.. but doesn't invalidate them!\n" @@ -66,4 +68,4 @@ "\n" -Alexey -87f4ec34e854e0891ca6cb99d15d1e5ff12695d80bf65a86ef2e0dda512f33dd +1731ad9f00480fff9a7424ed9f24d3a92f13a4f6395064e1cdfacc28908c6b6f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.