From: Radu Rendec <rrendec@arista.com>
To: virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>
Subject: virtio_net: ethtool supported link modes
Date: Thu, 31 Aug 2017 18:04:04 +0100 [thread overview]
Message-ID: <1504199044.22080.11.camel@arista.com> (raw)
Hello,
Looking at the code in virtnet_set_link_ksettings, it seems the speed
and duplex can be set to any valid value. The driver will "remember"
them and report them back in virtnet_get_link_ksettings.
However, the supported link modes (link_modes.supported in struct
ethtool_link_ksettings) is always 0, indicating that no speed/duplex
setting is supported.
Does it make more sense to set (at least a few of) the supported link
modes, such as 10baseT_Half ... 10000baseT_Full?
I would expect to see consistency between what is reported in
link_modes.supported and what can actually be set. Could you please
share your opinion on this?
Thank you,
Radu Rendec
next reply other threads:[~2017-08-31 17:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 17:04 Radu Rendec [this message]
2017-09-01 3:36 ` virtio_net: ethtool supported link modes Jason Wang
2017-09-01 3:36 ` Jason Wang
2017-09-01 12:01 ` Radu Rendec via Virtualization
2017-09-01 12:01 ` Radu Rendec
2017-09-01 15:43 ` Michael S. Tsirkin
2017-09-01 15:43 ` [virtio-dev] " Michael S. Tsirkin
2017-09-01 15:43 ` Michael S. Tsirkin
2017-09-01 16:19 ` Radu Rendec via Virtualization
2017-09-01 16:19 ` Radu Rendec
2017-09-01 17:45 ` Michael S. Tsirkin
2017-09-01 17:45 ` [virtio-dev] " Michael S. Tsirkin
2017-09-01 17:45 ` Michael S. Tsirkin
2017-09-04 14:59 ` Radu Rendec via Virtualization
2017-09-04 14:59 ` Radu Rendec
-- strict thread matches above, loose matches on Subject: below --
2017-08-31 17:04 Radu Rendec via Virtualization
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504199044.22080.11.camel@arista.com \
--to=rrendec@arista.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.