From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Vernon Mauery <vernon.mauery@linux.intel.com>,
Samuel Mendoza-Jonas <sam@mendozajonas.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: Re: [PATCH net-next] net/ncsi: Define {add, kill}_vid callbacks for !CONFIG_NET_NCSI
Date: Fri, 01 Sep 2017 07:14:10 +1000 [thread overview]
Message-ID: <1504214050.4974.52.camel@kernel.crashing.org> (raw)
In-Reply-To: <20170831152414.GB69617@mauery>
On Thu, 2017-08-31 at 08:24 -0700, Vernon Mauery wrote:
> +int ncsi_vlan_rx_add_vid(struct net_device *dev, __be16 proto, u16 vid)
> > +{
> > + return -ENOTTY;
> > +}
> > +int ncsi_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, u16 vid)
> > +{
> > + return -ENOTTY;
> > +}
>
> These should be static functions because they are defined in the header
> file or you will get multiple symbol definitions.
static inline even or you'll get warning about them being unused iirc.
Cheers,
Ben.
prev parent reply other threads:[~2017-08-31 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 3:38 [PATCH net-next] net/ncsi: Define {add, kill}_vid callbacks for !CONFIG_NET_NCSI Samuel Mendoza-Jonas
2017-08-31 3:38 ` [PATCH net-next] net/ncsi: Define {add,kill}_vid " Samuel Mendoza-Jonas
2017-08-31 3:59 ` [PATCH net-next] net/ncsi: Define {add, kill}_vid " Florian Fainelli
2017-08-31 3:59 ` [PATCH net-next] net/ncsi: Define {add,kill}_vid " Florian Fainelli
2017-08-31 15:24 ` [PATCH net-next] net/ncsi: Define {add, kill}_vid " Vernon Mauery
2017-08-31 21:14 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504214050.4974.52.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=sam@mendozajonas.com \
--cc=vernon.mauery@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.