Re: [PATCH 3/3] mac80211: fix VLAN handling with TXQs

[Johannes Berg <johannes@sipsolutions.net>]

On Tue, 2017-09-05 at 11:02 +0200, Toke Høiland-Jørgensen wrote:
> 
> > I'm not sure. However, I think it's less bad than one might guess
> > since it really should only affect multicast frames, right? All
> > unicast frames should go directly to the per-STA TXQ.
> 
> Ah, right, that is the interface txq that is being purged. Gotcha.
> 
> But, erm, what happens with unicast traffic sent on the VLAN
> interface when it goes down? Shouldn't that be purged from the per-
> station TXQs as well?

Well, those entire TXQs are destroyed with the station :)

> One nit with the patch:
> 
> > -	tx.sdata = vif_to_sdata(info->control.vif);
> > +	if (info->control.vif)
> > +		tx.sdata = vif_to_sdata(info->control.vif);
> 
> Why the conditional assignment? The code below unconditionally
> dereferences tx.sdata, so if info->control.vif is null it is going to
> crash anyway?

Yeah, I agree that makes no sense, I'll remove that piece again.

johannes