From: Johannes Berg <johannes@sipsolutions.net>
To: Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org, Ilan Peer <ilan.peer@intel.com>,
Luca Coelho <luciano.coelho@intel.com>
Subject: Re: [PATCH] mac80211: Complete ampdu work schedule during session tear down
Date: Wed, 06 Sep 2017 12:22:10 +0200 [thread overview]
Message-ID: <1504693330.13457.3.camel@sipsolutions.net> (raw)
In-Reply-To: <20170825081533.27916-1-luca@coelho.fi>
I was going to apply this, but running with lockdep enabled tells me
that this patch is broken.
In the callers of ieee80211_sta_tear_down_BA_sessions(), we only hold
the &local->sta_mtx.
However,
> + rcu_dereference_protected_tid_tx(sta, i);
requires (and checks, if you have lockdep) that you hold either
&sta->ampdu_mlme.mtx
or
&sta->lock.
Additionally, ieee80211_remove_tid_tx(), called via
ieee80211_stop_tx_ba_cb(), requires holding both - and
ieee80211_stop_tx_ba_cb() only requires the spinlock.
johannes
prev parent reply other threads:[~2017-09-06 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 8:15 [PATCH] mac80211: Complete ampdu work schedule during session tear down Luca Coelho
2017-09-06 10:22 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504693330.13457.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ilan.peer@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.