From: Johannes Berg <johannes@sipsolutions.net>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Matteo Croce <mcroce@redhat.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: hung task in mac80211
Date: Wed, 06 Sep 2017 16:30:00 +0200 [thread overview]
Message-ID: <1504708200.23905.3.camel@sipsolutions.net> (raw)
In-Reply-To: <20170906162748.071b040e@elisabeth>
On Wed, 2017-09-06 at 16:27 +0200, Stefano Brivio wrote:
>
> Sorry for the extended bothering :) but here, you're extending quite
> a bit the scope of the lock also
> when__ieee80211_start_rx_ba_session() is called by
> ieee80211_process_addba_request().
I know, but it doesn't matter.
> No idea what the hit can be, but we can't safely assume it's
> nothing either.
We don't really have to assume anything, we can read the code :-)
Trust me, I probably wrote most of it. It's fine, just sanity checks.
> What about simply introducing a 'ampdu_mlme_lock_held' argument
> instead?
Eww, no.
johannes
next prev parent reply other threads:[~2017-09-06 14:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 11:57 hung task in mac80211 Matteo Croce
2017-09-06 12:28 ` Christian Lamparter
2017-09-06 12:28 ` Christian Lamparter
2017-09-06 12:40 ` Stefano Brivio
2017-09-06 12:48 ` Johannes Berg
2017-09-06 13:03 ` Johannes Berg
2017-09-06 13:08 ` Sebastian Gottschall
2017-09-06 13:08 ` Sebastian Gottschall
2017-09-06 13:19 ` Stefano Brivio
2017-09-06 13:21 ` Johannes Berg
2017-09-06 13:27 ` Stefano Brivio
2017-09-06 13:30 ` Johannes Berg
2017-09-06 13:40 ` Stefano Brivio
2017-09-06 13:07 ` Matteo Croce
2017-09-06 13:07 ` Matteo Croce
2017-09-06 12:58 ` Johannes Berg
2017-09-06 14:27 ` Stefano Brivio
2017-09-06 14:30 ` Johannes Berg [this message]
2017-09-06 15:04 ` Matteo Croce
2017-09-06 15:11 ` Johannes Berg
2017-09-06 15:45 ` Sebastian Gottschall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504708200.23905.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.