All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: ERAMOTO Masaya <eramoto.masaya@jp.fujitsu.com>,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] autopair: Don't handle the iCade
Date: Thu, 07 Sep 2017 14:05:33 +0200	[thread overview]
Message-ID: <1504785933.6911.64.camel@hadess.net> (raw)
In-Reply-To: <973c2ecf-7916-b070-bbe5-1b92f7565b8c@jp.fujitsu.com>

On Thu, 2017-09-07 at 16:46 +0900, ERAMOTO Masaya wrote:
> Hi Bastien,
> 
> On 09/05/2017 02:54 AM, Bastien Nocera wrote:
> > We can't easily enter digits other than 1 through 4 (inclusive)
> > so leave it up to the agent to figure out a good passcode
> > for the iCade.
> > 
> > Note that we can not use the VID/PID of the device, as it is not
> > yet known at that point.
> 
> Does not the device class of iCade include its unique value or a
> value 
> for similar devices?

No, the iCade is configured as a keyboard so it can be paired with
Apple iOS devices which only recognise keyboards. Each keypress and key
release is a separate keyboard key press/release.

In mainline Linux, you can find the hid-icade driver that'll take care
of transforming those key presses and key releases into joypad events:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/hid/hid-icade.c

As we don't want the autopair keyboard to generate impossible to "type"
numbers, we need to do this somewhere else. It's done in gnome-
bluetooth's pairing agent as the device was deemed too niche to have
this handled in bluez. We still need the quirk however.

  reply	other threads:[~2017-09-07 12:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-04 17:54 [PATCH] autopair: Don't handle the iCade Bastien Nocera
2017-09-07  7:46 ` ERAMOTO Masaya
2017-09-07 12:05   ` Bastien Nocera [this message]
2017-10-17  9:53 ` Szymon Janc
  -- strict thread matches above, loose matches on Subject: below --
2013-12-09 17:08 Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504785933.6911.64.camel@hadess.net \
    --to=hadess@hadess.net \
    --cc=eramoto.masaya@jp.fujitsu.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.