From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "sagi@grimberg.me" <sagi@grimberg.me>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: Bart Van Assche <Bart.VanAssche@wdc.com>,
"hch@lst.de" <hch@lst.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 2/3] nvme: introduce nvme_reinit_tagset
Date: Thu, 7 Sep 2017 15:01:15 +0000 [thread overview]
Message-ID: <1504796474.2646.4.camel@wdc.com> (raw)
In-Reply-To: <1504711832-28425-3-git-send-email-sagi@grimberg.me>
T24gV2VkLCAyMDE3LTA5LTA2IGF0IDE4OjMwICswMzAwLCBTYWdpIEdyaW1iZXJnIHdyb3RlOg0K
PiAraW50IG52bWVfcmVpbml0X3RhZ3NldChzdHJ1Y3QgbnZtZV9jdHJsICpjdHJsLCBib29sIGFk
bWluKQ0KPiArew0KPiArCXN0cnVjdCBibGtfbXFfdGFnX3NldCAqc2V0ID0gYWRtaW4gPw0KPiAr
CQkJY3RybC0+YWRtaW5fdGFnc2V0IDogY3RybC0+dGFnc2V0Ow0KPiArDQo+ICsJaWYgKCFjdHJs
LT5vcHMtPnJlaW5pdF9yZXF1ZXN0KQ0KPiArCQlyZXR1cm4gMDsNCj4gKw0KPiArCXJldHVybiBi
bGtfbXFfdGFnc2V0X2l0ZXIoc2V0LCBzZXQtPmRyaXZlcl9kYXRhLA0KPiArCQkJY3RybC0+b3Bz
LT5yZWluaXRfcmVxdWVzdCk7DQo+ICt9DQo+ICtFWFBPUlRfU1lNQk9MX0dQTChudm1lX3JlaW5p
dF90YWdzZXQpOw0KDQpIZWxsbyBTYWdpLA0KDQpIYXZlIHlvdSBjb25zaWRlcmVkIHRvIHBhc3Mg
YSB0YWcgc2V0IHBvaW50ZXIgYXMgc2Vjb25kIGFyZ3VtZW50IHRvIHRoaXMNCm5ldyBmdW5jdGlv
biBpbnN0ZWFkIG9mIGEgYm9vbGVhbj8gSSB0aGluayB0aGF0IHdvdWxkIG5vdCBvbmx5IG1ha2Ug
dGhpcw0KZnVuY3Rpb24gc2hvcnRlciBidXQgYWxzbyB0aGF0IGl0IHdvdWxkIG1ha2UgdGhlIGNh
bGxlcnMgZWFzaWVyIHRvIHJlYWQuDQoNClRoYW5rcywNCg0KQmFydC4=
WARNING: multiple messages have this Message-ID (diff)
From: Bart.VanAssche@wdc.com (Bart Van Assche)
Subject: [PATCH 2/3] nvme: introduce nvme_reinit_tagset
Date: Thu, 7 Sep 2017 15:01:15 +0000 [thread overview]
Message-ID: <1504796474.2646.4.camel@wdc.com> (raw)
In-Reply-To: <1504711832-28425-3-git-send-email-sagi@grimberg.me>
On Wed, 2017-09-06@18:30 +0300, Sagi Grimberg wrote:
> +int nvme_reinit_tagset(struct nvme_ctrl *ctrl, bool admin)
> +{
> + struct blk_mq_tag_set *set = admin ?
> + ctrl->admin_tagset : ctrl->tagset;
> +
> + if (!ctrl->ops->reinit_request)
> + return 0;
> +
> + return blk_mq_tagset_iter(set, set->driver_data,
> + ctrl->ops->reinit_request);
> +}
> +EXPORT_SYMBOL_GPL(nvme_reinit_tagset);
Hello Sagi,
Have you considered to pass a tag set pointer as second argument to this
new function instead of a boolean? I think that would not only make this
function shorter but also that it would make the callers easier to read.
Thanks,
Bart.
next prev parent reply other threads:[~2017-09-07 15:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 15:30 [PATCH 0/3] Move tagset reinit to its only current consumer, nvme-core Sagi Grimberg
2017-09-06 15:30 ` Sagi Grimberg
2017-09-06 15:30 ` [PATCH 1/3] block: introduce blk_mq_tagset_iter Sagi Grimberg
2017-09-06 15:30 ` Sagi Grimberg
2017-09-07 9:39 ` Johannes Thumshirn
2017-09-07 9:39 ` Johannes Thumshirn
2017-09-07 14:59 ` Bart Van Assche
2017-09-07 14:59 ` Bart Van Assche
2017-09-06 15:30 ` [PATCH 2/3] nvme: introduce nvme_reinit_tagset Sagi Grimberg
2017-09-06 15:30 ` Sagi Grimberg
2017-09-07 9:42 ` Johannes Thumshirn
2017-09-07 9:42 ` Johannes Thumshirn
2017-09-07 15:01 ` Bart Van Assche [this message]
2017-09-07 15:01 ` Bart Van Assche
2017-09-06 15:30 ` [PATCH 3/3] block: remove blk_mq_reinit_tagset Sagi Grimberg
2017-09-06 15:30 ` Sagi Grimberg
2017-09-07 9:43 ` Johannes Thumshirn
2017-09-07 9:43 ` Johannes Thumshirn
2017-09-07 15:01 ` Bart Van Assche
2017-09-07 15:01 ` Bart Van Assche
2017-09-07 10:07 ` [PATCH 0/3] Move tagset reinit to its only current consumer, nvme-core Max Gurtovoy
2017-09-07 10:07 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504796474.2646.4.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.