From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Bart.VanAssche@wdc.com>
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "sagi@grimberg.me" <sagi@grimberg.me>, "axboe@kernel.dk" <axboe@kernel.dk>
CC: Bart Van Assche <Bart.VanAssche@wdc.com>, "hch@lst.de" <hch@lst.de>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH 2/3] nvme: introduce nvme_reinit_tagset
Date: Thu, 7 Sep 2017 15:01:15 +0000
Message-ID: <1504796474.2646.4.camel@wdc.com>
References: <1504711832-28425-1-git-send-email-sagi@grimberg.me>
	 <1504711832-28425-3-git-send-email-sagi@grimberg.me>
In-Reply-To: <1504711832-28425-3-git-send-email-sagi@grimberg.me>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
List-ID: <linux-block@vger.kernel.org>

T24gV2VkLCAyMDE3LTA5LTA2IGF0IDE4OjMwICswMzAwLCBTYWdpIEdyaW1iZXJnIHdyb3RlOg0K
PiAraW50IG52bWVfcmVpbml0X3RhZ3NldChzdHJ1Y3QgbnZtZV9jdHJsICpjdHJsLCBib29sIGFk
bWluKQ0KPiArew0KPiArCXN0cnVjdCBibGtfbXFfdGFnX3NldCAqc2V0ID0gYWRtaW4gPw0KPiAr
CQkJY3RybC0+YWRtaW5fdGFnc2V0IDogY3RybC0+dGFnc2V0Ow0KPiArDQo+ICsJaWYgKCFjdHJs
LT5vcHMtPnJlaW5pdF9yZXF1ZXN0KQ0KPiArCQlyZXR1cm4gMDsNCj4gKw0KPiArCXJldHVybiBi
bGtfbXFfdGFnc2V0X2l0ZXIoc2V0LCBzZXQtPmRyaXZlcl9kYXRhLA0KPiArCQkJY3RybC0+b3Bz
LT5yZWluaXRfcmVxdWVzdCk7DQo+ICt9DQo+ICtFWFBPUlRfU1lNQk9MX0dQTChudm1lX3JlaW5p
dF90YWdzZXQpOw0KDQpIZWxsbyBTYWdpLA0KDQpIYXZlIHlvdSBjb25zaWRlcmVkIHRvIHBhc3Mg
YSB0YWcgc2V0IHBvaW50ZXIgYXMgc2Vjb25kIGFyZ3VtZW50IHRvIHRoaXMNCm5ldyBmdW5jdGlv
biBpbnN0ZWFkIG9mIGEgYm9vbGVhbj8gSSB0aGluayB0aGF0IHdvdWxkIG5vdCBvbmx5IG1ha2Ug
dGhpcw0KZnVuY3Rpb24gc2hvcnRlciBidXQgYWxzbyB0aGF0IGl0IHdvdWxkIG1ha2UgdGhlIGNh
bGxlcnMgZWFzaWVyIHRvIHJlYWQuDQoNClRoYW5rcywNCg0KQmFydC4=

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bart.VanAssche@wdc.com (Bart Van Assche)
Date: Thu, 7 Sep 2017 15:01:15 +0000
Subject: [PATCH 2/3] nvme: introduce nvme_reinit_tagset
In-Reply-To: <1504711832-28425-3-git-send-email-sagi@grimberg.me>
References: <1504711832-28425-1-git-send-email-sagi@grimberg.me>
 <1504711832-28425-3-git-send-email-sagi@grimberg.me>
Message-ID: <1504796474.2646.4.camel@wdc.com>

On Wed, 2017-09-06@18:30 +0300, Sagi Grimberg wrote:
> +int nvme_reinit_tagset(struct nvme_ctrl *ctrl, bool admin)
> +{
> +	struct blk_mq_tag_set *set = admin ?
> +			ctrl->admin_tagset : ctrl->tagset;
> +
> +	if (!ctrl->ops->reinit_request)
> +		return 0;
> +
> +	return blk_mq_tagset_iter(set, set->driver_data,
> +			ctrl->ops->reinit_request);
> +}
> +EXPORT_SYMBOL_GPL(nvme_reinit_tagset);

Hello Sagi,

Have you considered to pass a tag set pointer as second argument to this
new function instead of a boolean? I think that would not only make this
function shorter but also that it would make the callers easier to read.

Thanks,

Bart.