diff for duplicates of <1504814332.2117.3.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index b304309..97e8307 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -5,19 +5,19 @@ Thanks for your feedback! I'll address some of your comments below. On Thu, 2017-09-07 at 07:34 +0200, Henrik Austad wrote: > > As for the shapers config interface: > > -> > ?* CBS (802.1Qav) +> > * CBS (802.1Qav) > > -> > ???This patchset is proposing a new qdisc called 'cbs'. Its 'tc' cmd line +> > This patchset is proposing a new qdisc called 'cbs'. Its 'tc' cmd line > > is: -> > ???$ tc qdisc add dev IFACE parent ID cbs locredit N hicredit M sendslope S +> > $ tc qdisc add dev IFACE parent ID cbs locredit N hicredit M sendslope S > > \ -> > ?????idleslope I +> > idleslope I > > So this confuses me a bit, why specify sendSlope? > -> ????sendSlope = portTransmitRate - idleSlope +> sendSlope = portTransmitRate - idleSlope > -> and portTransmitRate is the speed of the MAC (which you get from the? +> and portTransmitRate is the speed of the MAC (which you get from the > driver). Adding sendSlope here is just redundant I think. Yes, this was something we've spent quite a few time discussing before this RFC @@ -25,16 +25,16 @@ series. After reading the Annex L from 802.1Q-2014 (operation of CBS algorithm) so many times, we've came up with the rationale explained below. The rationale here is that sendSlope is just another parameter from CBS -algorithm like idleSlope, hiCredit and loCredit. As such,?its calculation +algorithm like idleSlope, hiCredit and loCredit. As such, its calculation should be done at the same "layer" as the others parameters (in this case, user space) in order to keep consistency. Moreover, in this design, the driver layer -is dead simple: all the device driver?has to do is applying CBS parameters to +is dead simple: all the device driver has to do is applying CBS parameters to hardware. Having any CBS parameter calculation in the driver layer means all device drivers must implement that calculation. -> Also, does this mean that when you create the qdisc, you have locked the? -> bandwidth for the scheduler? Meaning, if I later want to add another? -> stream that requires more bandwidth, I have to close all active streams,? +> Also, does this mean that when you create the qdisc, you have locked the +> bandwidth for the scheduler? Meaning, if I later want to add another +> stream that requires more bandwidth, I have to close all active streams, > reconfigure the qdisc and then restart? If we want to reserve more bandwidth to "accommodate" a new stream, we don't @@ -46,10 +46,10 @@ sendslope -980000 idleslope 20000 No application/stream is interrupted while new CBS parameters are applied. -> > ???Note that the parameters for this qdisc are the ones defined by the -> > ???802.1Q-2014 spec, so no hardware specific functionality is exposed here. +> > Note that the parameters for this qdisc are the ones defined by the +> > 802.1Q-2014 spec, so no hardware specific functionality is exposed here. > -> You do need to know if the link is brought up as 100 or 1000 though - which? +> You do need to know if the link is brought up as 100 or 1000 though - which > the driver already knows. User space knows that information via ethtool or /sys. @@ -70,11 +70,11 @@ support. > > 8) You can also run a Talker for class B (prio 2 here) > > $ ./talker -i enp3s0 -p 2 > > -> > ?* The bandwidth displayed on the listener output now should increase to +> > * The bandwidth displayed on the listener output now should increase to > > very -> > ???close to the one configured for class A + class B. +> > close to the one configured for class A + class B. > -> Because you grab both class A *and* B, or because B will eat what A does? +> Because you grab both class A *and* B, or because B will eat what A does > not use? Because the listener application grabs both class A and B traffic. @@ -82,10 +82,3 @@ Because the listener application grabs both class A and B traffic. Regards, Andre --------------- next part -------------- -A non-text attachment was scrubbed... -Name: smime.p7s -Type: application/x-pkcs7-signature -Size: 3262 bytes -Desc: not available -URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20170907/84197122/attachment.bin> diff --git a/N1/2.bin b/N1/2.bin new file mode 100644 index 0000000..4e17e5c Binary files /dev/null and b/N1/2.bin differ diff --git a/N1/2.hdr b/N1/2.hdr new file mode 100644 index 0000000..307aaef --- /dev/null +++ b/N1/2.hdr @@ -0,0 +1,3 @@ +Content-Type: application/x-pkcs7-signature; name="smime.p7s" +Content-Disposition: attachment; filename="smime.p7s" +Content-Transfer-Encoding: base64 diff --git a/a/content_digest b/N1/content_digest index 0ce29cd..62d04e1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,10 +1,24 @@ "ref\020170901012625.14838-1-vinicius.gomes@intel.com\0" "ref\020170907053411.GA6580@sisyphus.home.austad.us\0" "From\0Guedes, Andre <andre.guedes@intel.com>\0" - "Subject\0[Intel-wired-lan] [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers\0" + "Subject\0Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers\0" "Date\0Thu, 7 Sep 2017 19:58:53 +0000\0" - "To\0intel-wired-lan@osuosl.org\0" - "\00:1\0" + "To\0Gomes" + Vinicius <vinicius.gomes@intel.com> + " henrik@austad.us <henrik@austad.us>\0" + "Cc\0jiri@resnulli.us <jiri@resnulli.us>" + jhs@mojatatu.com <jhs@mojatatu.com> + Ong + Boon Leong <boon.leong.ong@intel.com> + xiyou.wangcong@gmail.com <xiyou.wangcong@gmail.com> + Sanchez-Palencia + Jesus <jesus.sanchez-palencia@intel.com> + richardcochran@gmail.com <richardcochran@gmail.com> + netdev@vger.kernel.org <netdev@vger.kernel.org> + Briano + Ivan <ivan.briano@intel.com> + " intel-wired-lan@lists.osuosl.org <intel-wired-lan@lists.osuosl.org>\0" + "\01:1\0" "b\0" "Hi Henrik,\n" "\n" @@ -13,19 +27,19 @@ "On Thu, 2017-09-07 at 07:34 +0200, Henrik Austad wrote:\n" "> > As for the shapers config interface:\n" "> > \n" - "> > ?* CBS (802.1Qav)\n" + "> > \302\240* CBS (802.1Qav)\n" "> > \n" - "> > ???This patchset is proposing a new qdisc called 'cbs'. Its 'tc' cmd line\n" + "> > \302\240\302\240\302\240This patchset is proposing a new qdisc called 'cbs'. Its 'tc' cmd line\n" "> > is:\n" - "> > ???$ tc qdisc add dev IFACE parent ID cbs locredit N hicredit M sendslope S\n" + "> > \302\240\302\240\302\240$ tc qdisc add dev IFACE parent ID cbs locredit N hicredit M sendslope S\n" "> > \\\n" - "> > ?????idleslope I\n" + "> > \302\240\302\240\302\240\302\240\302\240idleslope I\n" "> \n" "> So this confuses me a bit, why specify sendSlope?\n" "> \n" - "> ????sendSlope = portTransmitRate - idleSlope\n" + "> \302\240\302\240\302\240\302\240sendSlope = portTransmitRate - idleSlope\n" "> \n" - "> and portTransmitRate is the speed of the MAC (which you get from the?\n" + "> and portTransmitRate is the speed of the MAC (which you get from the\302\240\n" "> driver). Adding sendSlope here is just redundant I think.\n" "\n" "Yes, this was something we've spent quite a few time discussing before this RFC\n" @@ -33,16 +47,16 @@ "so many times, we've came up with the rationale explained below.\n" "\n" "The rationale here is that sendSlope is just another parameter from CBS\n" - "algorithm like idleSlope, hiCredit and loCredit. As such,?its calculation\n" + "algorithm like idleSlope, hiCredit and loCredit. As such,\302\240its calculation\n" "should be done at the same \"layer\" as the others parameters (in this case, user\n" "space) in order to keep consistency. Moreover, in this design, the driver layer\n" - "is dead simple: all the device driver?has to do is applying CBS parameters to\n" + "is dead simple: all the device driver\302\240has to do is applying CBS parameters to\n" "hardware. Having any CBS parameter calculation in the driver layer means all\n" "device drivers must implement that calculation.\n" "\n" - "> Also, does this mean that when you create the qdisc, you have locked the?\n" - "> bandwidth for the scheduler? Meaning, if I later want to add another?\n" - "> stream that requires more bandwidth, I have to close all active streams,?\n" + "> Also, does this mean that when you create the qdisc, you have locked the\302\240\n" + "> bandwidth for the scheduler? Meaning, if I later want to add another\302\240\n" + "> stream that requires more bandwidth, I have to close all active streams,\302\240\n" "> reconfigure the qdisc and then restart?\n" "\n" "If we want to reserve more bandwidth to \"accommodate\" a new stream, we don't\n" @@ -54,10 +68,10 @@ "\n" "No application/stream is interrupted while new CBS parameters are applied.\n" "\n" - "> > ???Note that the parameters for this qdisc are the ones defined by the\n" - "> > ???802.1Q-2014 spec, so no hardware specific functionality is exposed here.\n" + "> > \302\240\302\240\302\240Note that the parameters for this qdisc are the ones defined by the\n" + "> > \302\240\302\240\302\240802.1Q-2014 spec, so no hardware specific functionality is exposed here.\n" "> \n" - "> You do need to know if the link is brought up as 100 or 1000 though - which?\n" + "> You do need to know if the link is brought up as 100 or 1000 though - which\302\240\n" "> the driver already knows.\n" "\n" "User space knows that information via ethtool or /sys.\n" @@ -78,24 +92,47 @@ "> > 8) You can also run a Talker for class B (prio 2 here)\n" "> > $ ./talker -i enp3s0 -p 2\n" "> > \n" - "> > ?* The bandwidth displayed on the listener output now should increase to\n" + "> > \302\240* The bandwidth displayed on the listener output now should increase to\n" "> > very\n" - "> > ???close to the one configured for class A + class B.\n" + "> > \302\240\302\240\302\240close to the one configured for class A + class B.\n" "> \n" - "> Because you grab both class A *and* B, or because B will eat what A does?\n" + "> Because you grab both class A *and* B, or because B will eat what A does\302\240\n" "> not use?\n" "\n" "Because the listener application grabs both class A and B traffic.\n" "\n" "Regards,\n" "\n" - "Andre\n" - "-------------- next part --------------\n" - "A non-text attachment was scrubbed...\n" - "Name: smime.p7s\n" - "Type: application/x-pkcs7-signature\n" - "Size: 3262 bytes\n" - "Desc: not available\n" - URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20170907/84197122/attachment.bin> + Andre + "\01:2\0" + "fn\0smime.p7s\0" + "b\0" + "0\200\006\t*\206H\206\367\r\001\a\002\240\2000\200\002\001\0011\v0\t\006\005+\016\003\002\032\005\00\200\006\t*\206H\206\367\r\001\a\001\0\0\240\202\n" + "i0\202\004\3530\202\003\323\240\003\002\001\002\002\020R\351\002\312\021\350D\235\224e8/\243\0320\2730\r\006\t*\206H\206\367\r\001\001\005\005\00o1\v0\t\006\003U\004\006\023\002SE1\0240\022\006\003U\004\n" + "\023\vAddTrust AB1&0$\006\003U\004\v\023\035AddTrust External TTP Network1\"0 \006\003U\004\003\023\031AddTrust External CA Root0\036\027\r130319000000Z\027\r200530104838Z0y1\v0\t\006\003U\004\006\023\002US1\v0\t\006\003U\004\b\023\002CA1\0240\022\006\003U\004\a\023\vSanta Clara1\0320\030\006\003U\004\n" + "\023\021Intel Corporation1+0)\006\003U\004\003\023\"Intel External Basic Issuing CA 4A0\202\001\"0\r\006\t*\206H\206\367\r\001\001\001\005\0\003\202\001\017\00\202\001\n" + "\002\202\001\001\0\340\260\314\200\235\330IU\372\003\333\004\3728\307\335\277\205\335v\274\353=\313,\253\277\351k\343!\333\324o\031\350\317j\247\276_T)\0027\260MsQ\0241\255\370/\264\375\033>\vu\270<\0|\267:\037\227\252\237(\276\354Z\317\2611\202G\2100\016j\265ZD\320\200\320\315]H\033\357W\275\377\253\037\253\345\237\b:b\361'\032\202\\\213\t\032{\246\037\325\353G\033\212\320o\235\221^\224\240\203\006\035\367\331.\212\033v\300vsF\a\373\344\363\246\360\016V:\242`\354\353\364l|\3343A\\(\374\315\350>\273\261\353.\263\310\212\021\272W\344TC[3O\375F\274\320:\\\212\341nU\223\201\004\261\365\266\216P\225\341o7@\252\221q\300\n" + "!Lp\332\257\307\240uOm\261\023\256\262\346\023\244Qg\377\236ZY\006Z_\246\267\0366\034\350\016\231}\001E\324\321\243\333\307\357'\201\243\002\003\001\0\001\243\202\001w0\202\001s0\037\006\003U\035#\004\0300\026\200\024\255\275\230z4\264&\367\372\304&T\357\003\275\340$\313T\0320\035\006\003U\035\016\004\026\004\024\036i*\264\334(\376G\030N!\v?\274\254\021/\360\230\3650\016\006\003U\035\017\001\001\377\004\004\003\002\001\2060\022\006\003U\035\023\001\001\377\004\b0\006\001\001\377\002\001\006\006\003U\035%\004/0-\006\b+\006\001\005\005\a\003\004\006\n" + "+\006\001\004\001\2027\n" + "\003\004\006\n" + "+\006\001\004\001\2027\n" + "\003\f\006\t+\006\001\004\001\2027\025\0050\027\006\003U\035 \004\0200\0160\f\006\n" + "*\206H\206\370M\001\005\001i0I\006\003U\035\037\004B0@0>\240<\240:\2068http://crl.trust-provider.com/AddTrustExternalCARoot.crl0:\006\b+\006\001\005\005\a\001\001\004.0,0*\006\b+\006\001\005\005\a0\001\206\036http://ocsp.trust-provider.com05\006\003U\035\036\004.0,\240*0\v\201\tintel.com0\033\240\031\006\n" + "+\006\001\004\001\2027\024\002\003\240\v\f\tintel.com0\r\006\t*\206H\206\367\r\001\001\005\005\0\003\202\001\001\0)\302\315\243\375\222\243Rg\242/\006\355nP\350T\217\253W\346\310\245\267\261 \337\325\251\257\310y#\022\av\346~\314)\021\306\022dq\306\214\342<\252\\\231\267\327aO\211\322\016z\322p\250\346\003\305\357\305\235\355\231\263r`\234\233U\005\025\3621\177\016\220\003_[F\224\302\361\263\fi$\204\227\314\267\364\3700k\341\3046j\017f\303:\3347Y\3538\203\234\372\234I\267\037b\317*w\371\271wm\253\245z\271 eT\265~\213_\264\177\205$\260\377{\037\0019\301.\b\211\266)U\311\216\316\030i\230( \022\330\2158\212\333\322KU\255y\305\323\267\323\231\017#[\227\262\3559\260k\200\302\341fJI[\352NG\327\367\207\225F\331.n*@;N\037M\v\321(I\307p@ \b\303\345\026)\264\220\320\213#\331AK\355\361\312\276j\226)T\313\367\313\021\316\3627\261\343B\3400\202\005v0\202\004^\240\003\002\001\002\002\0233\0\0\213ucw\236\364\177-\307\302\0\0\0\0\213u0\r\006\t*\206H\206\367\r\001\001\005\005\00y1\v0\t\006\003U\004\006\023\002US1\v0\t\006\003U\004\b\023\002CA1\0240\022\006\003U\004\a\023\vSanta Clara1\0320\030\006\003U\004\n" + "\023\021Intel Corporation1+0)\006\003U\004\003\023\"Intel External Basic Issuing CA 4A0\036\027\r170103234034Z\027\r171229234034Z0?1\0260\024\006\003U\004\003\023\rGuedes, Andre1%0#\006\t*\206H\206\367\r\001\t\001\026\026andre.guedes@intel.com0\202\001\"0\r\006\t*\206H\206\367\r\001\001\001\005\0\003\202\001\017\00\202\001\n" + "\002\202\001\001\0\334\260\206\374{\0\\\361\270\204g*]\311\236\232\364\257\271\337!\260\257\371\244\003\032\345\356[\304%\032\364\002\237\307\202^\326\342\n" + "\275P\342\337l\f\b\037\321\b\365L.^\223\235\361\320\242\207_\261>\3669,v\355\210O>\025\022^\023\207\254\200\327=l\327\rM\002\252\301\371Z\"'\222\037&-7\334MO\360Rl3\240\372\250j\331\345\275\225\3610J\244A\246\027d`aOr\335\324\226\017\241\223\230\246\207N\332\343\261\002\306\001\r\315>~\243\342h\335\215\337\373\300\261Gz\257\205\310Y ,T\277\"&\366^\020\220c\371\r\037\256(\270\336|\375\270\235'\202U\026\304\020!\315q\024\240\261/\377\bfC\302|\376\262\207\256\311tR,\36082\364z5\205\274\213\002Q\346\022?hh\214\243\326\243\344]\337\032\225\212i\f\027\200mn\203\030\325\a\006\200z\324\317\355\375OL\244\213\002\003\001\0\001\243\202\002/0\202\002+0\035\006\003U\035\016\004\026\004\024l}6\3457\3271\2227\350\303\376\302/\263\232\030\355/\2670\037\006\003U\035#\004\0300\026\200\024\036i*\264\334(\376G\030N!\v?\274\254\021/\360\230\3650e\006\003U\035\037\004^0\\0Z\240X\240V\206Thttp://www.intel.com/repository/CRL/Intel%20External%20Basic%20Issuing%20CA%204A.crl0\201\237\006\b+\006\001\005\005\a\001\001\004\201\2220\201\2170i\006\b+\006\001\005\005\a0\002\206]http://www.intel.com/repository/certificates/Intel%20External%20Basic%20Issuing%20CA%204A.crt0\"\006\b+\006\001\005\005\a0\001\206\026http://ocsp.intel.com/0\v\006\003U\035\017\004\004\003\002\a\2000<\006\t+\006\001\004\001\2027\025\a\004/0-\006%+\006\001\004\001\2027\025\b\206\303\214u\204\231\345Q\203\375\201(\205\216\237S\202\221\300\tg\201\336\2759\225\360C\002\001d\002\001\t0\037\006\003U\035%\004\0300\026\006\b+\006\001\005\005\a\003\004\006\n" + "+\006\001\004\001\2027\n" + "\003\f0)\006\t+\006\001\004\001\2027\025\n" + "\004\0340\0320\n" + "\006\b+\006\001\005\005\a\003\0040\f\006\n" + "+\006\001\004\001\2027\n" + "\003\f0I\006\003U\035\021\004B0@\240&\006\n" + "+\006\001\004\001\2027\024\002\003\240\030\f\026andre.guedes@intel.com\201\026andre.guedes@intel.com0\r\006\t*\206H\206\367\r\001\001\005\005\0\003\202\001\001\0O\204]\250?7\223\344[[\227\261\254\226\307z\37036\005s9\312\334\335T\033\376\252G\345\024\a\363\303\342\326\340S\223>\"\203\375\200\352~\2074\316\304\315O[\030r\017n.\244L\356\212y\t\334\031'\020\325\036\025\221\032Zv\020\213}:H\314\311?p\263\022%\250\201\r\277\370\222Wa\275\257\275\b\336(F\252\230Wj\262\021\311\356\341qv9\202`yq\231\233^\332\200B\3506\332)\341\334\037!q{Lq\271\244\3609\0017:\202MU\314i7lJ\366\266\347\241\355\232\376\207\240,\271\375\324\373\361H\330#\037D\002\3757\230\346G\371>'\370D\002\242\365\233\b\350\354\017\204JE\205\226\323$\204\202\302h\035\031\302\277\231Q\262V\320Z]\310\216n\205I\023\n" + "\302.\306\276x\b[\032~\005\340\314\023\272j:\243,\331kd\244zu\322\344\316\334\206g\v\320[\311\350^1\202\002\0270\202\002\023\002\001\0010\201\2200y1\v0\t\006\003U\004\006\023\002US1\v0\t\006\003U\004\b\023\002CA1\0240\022\006\003U\004\a\023\vSanta Clara1\0320\030\006\003U\004\n" + "\023\021Intel Corporation1+0)\006\003U\004\003\023\"Intel External Basic Issuing CA 4A\002\0233\0\0\213ucw\236\364\177-\307\302\0\0\0\0\213u0\t\006\005+\016\003\002\032\005\0\240]0\030\006\t*\206H\206\367\r\001\t\0031\v\006\t*\206H\206\367\r\001\a\0010\034\006\t*\206H\206\367\r\001\t\0051\017\027\r170907195852Z0#\006\t*\206H\206\367\r\001\t\0041\026\004\024k{\207\020\301s\323\247\030\027np>x\272\275\252\232*\0040\r\006\t*\206H\206\367\r\001\001\001\005\0\004\202\001\0\004\001\317<\365\237\r\026\330\223\322{\254\267\2079\f\221Qr^\267~\225\256CJ2\263ZN\211\255\336\345\366y;7M\264\n" + "w\021\216\204\350h;\362\232\n" + " (&\2310\340\240Be6\"\351\a\v1,\377\237\304/\350\3357\306\321\343\375\030\\\310\036]\n" + "\325\023>6%hD\233\316E\361Q\307+Cy\323\312\347\311\355bO.\367\230\263o\032vR\314\222\b\202N\241\216dAxB\301\246Z\221\364a\260\206\222\226\005\301\343$\024@\274\264\350\356\333s\276\353\371\362\314\304\343\003\033S\215n1\367\332\242\346I\003\177\240\370\250R\321;5R\bV\331\020\265\030\247\267\233\252d\371\272al\277\333\232\362\275&'Ky\r\321\226r\016]\317c\262\331\212\372@r\204?\324O}to\301\304l\363^\217\035\203?{\355EX\334\322q\200v\333>\341M)\323\227~\022\234\323\355Nb\347\322\0\0\0\0\0\0" -fcc531d01221dafda67f0d0e9f83f558bf942259f895003a1e7dd74c61a1e2a0 +97a27d7495cbeabfff7680ca51b26d5c954bf627e5c7e4c01ca202895fa69f1f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.