From: Johannes Berg <johannes@sipsolutions.net>
To: Benjamin Beichler <benjamin.beichler@uni-rostock.de>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/4] mac80211_hwsim: add hwsim_tx_rate_flags to Netlink Attributes
Date: Fri, 08 Sep 2017 16:26:34 +0200 [thread overview]
Message-ID: <1504880794.20347.3.camel@sipsolutions.net> (raw)
In-Reply-To: <fb18fe18-c780-4073-886f-9c16788391ee@MAIL1.uni-rostock.de>
On Fri, 2017-09-08 at 16:11 +0200, Benjamin Beichler wrote:
> For correct interpretation of a tx rate, the corresponding rate flags
> are needed (e.g. whether a HT-MCS rate or a legacy rate) and
> moreover for more correct simulation the other infos of the flags are
> important (like short-GI). Keeping compability, the flags
> are not integrated into the existing hwsim_tx_rate, but transmitted
> as an additional netlink attribute.
This still exposes a lot of internal detail - perhaps it'd be better to
convert to some sort of stable rate representation, like in cfg80211?
Not sure that's sufficient though, it's a bit less detailed.
johannes
next prev parent reply other threads:[~2017-09-08 14:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170908141137.3941-1-benjamin.beichler@uni-rostock.de>
2017-09-08 14:11 ` [RFC 2/4] mac80211_hwsim: add hwsim_tx_rate_flags to Netlink Attributes Benjamin Beichler
2017-09-08 14:26 ` Johannes Berg [this message]
2017-09-11 9:49 ` Benjamin Beichler
2017-09-15 7:36 ` Johannes Berg
2017-09-08 14:11 ` [RFC 3/4] mac80211_hwsim: explicitly set netlink parallel ops to false Benjamin Beichler
2017-09-08 14:19 ` Johannes Berg
2017-09-08 15:07 ` Benjamin Beichler
2017-09-08 15:11 ` Johannes Berg
2017-09-08 14:11 ` [RFC 4/4] mac80211_hwsim: add radio idx param to netlink callback of radio creation Benjamin Beichler
2017-09-08 14:28 ` Johannes Berg
2017-09-08 14:43 ` Benjamin Beichler
2017-09-08 14:46 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504880794.20347.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=benjamin.beichler@uni-rostock.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.