From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqNkV-0008KT-Mg for qemu-devel@nongnu.org; Fri, 08 Sep 2017 14:11:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqNkS-0000EE-GZ for qemu-devel@nongnu.org; Fri, 08 Sep 2017 14:11:27 -0400 Received: from mail-pf0-x234.google.com ([2607:f8b0:400e:c00::234]:34464) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dqNkS-0000Dx-8v for qemu-devel@nongnu.org; Fri, 08 Sep 2017 14:11:24 -0400 Received: by mail-pf0-x234.google.com with SMTP id e1so5671078pfk.1 for ; Fri, 08 Sep 2017 11:11:24 -0700 (PDT) Date: Fri, 08 Sep 2017 11:11:21 -0700 From: Brandon Carpenter Message-Id: <1504894281.1214.0@smtp.gmail.com> In-Reply-To: References: <20170724184217.21381-1-brandon.carpenter@cypherpath.com> <20170724181544.20292-1-brandon.carpenter@cypherpath.com> <20170908173801.15205-1-brandon.carpenter@cypherpath.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII"; format=flowed Subject: Re: [Qemu-devel] [PATCH v2 0/6] Update websocket code to more fully support the RFC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org My apologies. I read that document before submitting the patch, but there was a lot to take in. Would you like me to resend the patch without the references? -- Brandon Carpenter | Software Engineer Cypherpath, Inc. 400 Columbia Point Drive Ste 101 | Richland, Washington USA Office: (650) 713-3060 On Fri, Sep 8, 2017 at 11:01 AM, Eric Blake wrote: > On 09/08/2017 12:37 PM, Brandon Carpenter wrote: >> We've been experiencing issues where the qemu websocket server >> closes >> connections from noVNC clients for no apparent reason. Debugging >> shows >> that certain web browsers are injecting ping and pong frames when >> the >> connection becomes idle. Some browsers send those frames without a >> payload, which also is causing closure. This patch series addresses >> these issues by making the websocket server more conformant to RFC >> 6455 - The WebSocket Protocol. > > meta-comment: sending v2 in-reply-to v1 makes it harder for automated > tooling to recognize that you are sending new patches. We prefer that > v2 be a top-level thread. More patch submission hints at: > https://wiki.qemu.org/index.php/Contribute/SubmitAPatch > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org > -- CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain proprietary, confidential or privileged information or otherwise be protected by law. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please notify the sender and destroy all copies and the original message.