From mboxrd@z Thu Jan 1 00:00:00 1970 From: onlywig@gmail.com (Wig C) Date: Sat, 9 Sep 2017 20:45:10 +0800 Subject: [PATCH v3] ARM: dts: Add initial Pistachio i.mx6q board support. In-Reply-To: <1504949308-13552-1-git-send-email-onlywig@gmail.com> References: <1504949308-13552-1-git-send-email-onlywig@gmail.com> Message-ID: <1504961110-9878-1-git-send-email-onlywig@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Sep 9, 2017 at 6:28 AM, Wig C wrote: > +&usdhc2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usdhc2>; > + bus-width = <4>; > + vmmc-supply = <&wlan_en_reg>; > + no-1-8-v; > + keep-power-in-suspend; > + non-removable; > + cap-power-off-card; As I mentioned previously the indentation is not correct here. You should use tab instead of spaces. checkpatch also complains about it: WARNING: please, no spaces at the start of a line #699: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:654: + non-removable;$ WARNING: please, no spaces at the start of a line #700: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:655: + cap-power-off-card;$ Hello Fabio: I will fix this on next patch, sorry I miss it. > +&wdog1 { > + status = "okay"; > +}; Why don't you use like this as you intended in the original patch? &wdog1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_wdog>; fsl,ext-reset-output; status = "okay"; }; My original patch has never support hardware watch dog as following link: https://www.spinics.net/lists/kernel/msg2594724.html I used soft reset on Pistachio, sorry for cause your misunderstand, and thanks for your kindly correction. Wig From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wig C Subject: [PATCH v3] ARM: dts: Add initial Pistachio i.mx6q board support. Date: Sat, 9 Sep 2017 20:45:10 +0800 Message-ID: <1504961110-9878-1-git-send-email-onlywig@gmail.com> References: <1504949308-13552-1-git-send-email-onlywig@gmail.com> Return-path: In-Reply-To: <1504949308-13552-1-git-send-email-onlywig-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: fabio.estevam-3arQi8VN3Tc@public.gmane.org Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Sat, Sep 9, 2017 at 6:28 AM, Wig C wrote: > +&usdhc2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usdhc2>; > + bus-width = <4>; > + vmmc-supply = <&wlan_en_reg>; > + no-1-8-v; > + keep-power-in-suspend; > + non-removable; > + cap-power-off-card; As I mentioned previously the indentation is not correct here. You should use tab instead of spaces. checkpatch also complains about it: WARNING: please, no spaces at the start of a line #699: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:654: + non-removable;$ WARNING: please, no spaces at the start of a line #700: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:655: + cap-power-off-card;$ Hello Fabio: I will fix this on next patch, sorry I miss it. > +&wdog1 { > + status = "okay"; > +}; Why don't you use like this as you intended in the original patch? &wdog1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_wdog>; fsl,ext-reset-output; status = "okay"; }; My original patch has never support hardware watch dog as following link: https://www.spinics.net/lists/kernel/msg2594724.html I used soft reset on Pistachio, sorry for cause your misunderstand, and thanks for your kindly correction. Wig -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757520AbdIIMpR (ORCPT ); Sat, 9 Sep 2017 08:45:17 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:38604 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753539AbdIIMpP (ORCPT ); Sat, 9 Sep 2017 08:45:15 -0400 X-Google-Smtp-Source: ADKCNb6lLvpczRPHZg4zPLFpMZGjWkUq6Ux1/DCq9mutQMK1lm4MwNsmEmZKa8cSeBB5QWi3SkWH8g== From: Wig C To: fabio.estevam@nxp.com Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, shawnguo@kernel.org, kernel@pengutronix.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] ARM: dts: Add initial Pistachio i.mx6q board support. Date: Sat, 9 Sep 2017 20:45:10 +0800 Message-Id: <1504961110-9878-1-git-send-email-onlywig@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504949308-13552-1-git-send-email-onlywig@gmail.com> References: <1504949308-13552-1-git-send-email-onlywig@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 9, 2017 at 6:28 AM, Wig C wrote: > +&usdhc2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usdhc2>; > + bus-width = <4>; > + vmmc-supply = <&wlan_en_reg>; > + no-1-8-v; > + keep-power-in-suspend; > + non-removable; > + cap-power-off-card; As I mentioned previously the indentation is not correct here. You should use tab instead of spaces. checkpatch also complains about it: WARNING: please, no spaces at the start of a line #699: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:654: + non-removable;$ WARNING: please, no spaces at the start of a line #700: FILE: arch/arm/boot/dts/imx6q-pistachio.dts:655: + cap-power-off-card;$ Hello Fabio: I will fix this on next patch, sorry I miss it. > +&wdog1 { > + status = "okay"; > +}; Why don't you use like this as you intended in the original patch? &wdog1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_wdog>; fsl,ext-reset-output; status = "okay"; }; My original patch has never support hardware watch dog as following link: https://www.spinics.net/lists/kernel/msg2594724.html I used soft reset on Pistachio, sorry for cause your misunderstand, and thanks for your kindly correction. Wig