From: Gerd Hoffmann <kraxel@redhat.com>
To: Varad Gautam <varadgautam@gmail.com>, dri-devel@lists.freedesktop.org
Cc: "Stéphane Marchesin" <marcheu@chromium.org>,
"Zach Reizner" <zachr@chromium.org>
Subject: Re: [PATCH 05/12] drm/cirrus: hardcode vram size
Date: Mon, 11 Sep 2017 10:31:03 +0200 [thread overview]
Message-ID: <1505118663.31639.3.camel@redhat.com> (raw)
In-Reply-To: <20170908133517.18715-6-varadgautam@gmail.com>
On Fri, 2017-09-08 at 19:05 +0530, Varad Gautam wrote:
> From: Zach Reizner <zachr@google.com>
>
> There is no reliable way of detecting actual VRAM size, which is
> important in the case of cirrus because cursor data is always stored
> in
> the last 16K of VRAM. Because qemu effectivaly hardcodes 4MB but
> reports
> 32MB, we hardcode 4MB in the cirrus driver to ensure the cursor works
> properly.
This comment is misleading. pci bar size != vram size. There is more
stuff in the pci bar than just the vram, thats why it is larger than
vram. It's not qemu mis-reporting something.
The actual vram size is 4MB. This is what the original hardware had,
so the qemu emulation uses that too. So the fix is correct, but please
adjust commit message and comment.
cheers,
Gerd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-09-11 8:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 13:35 [PATCH 00/12] atomic modesetting for cirrus v2 Varad Gautam
2017-09-08 13:35 ` [PATCH 01/12] drm/cirrus: split out bo unpinning from cirrus_bo_push_sysram Varad Gautam
2017-09-08 13:35 ` [PATCH 02/12] drm/cirrus: add drm_read to cirrus_driver_fops Varad Gautam
2017-09-08 13:35 ` [PATCH 03/12] drm/cirrus: do not disable outputs on fbdev init for atomic Varad Gautam
2017-09-08 13:35 ` [PATCH 04/12] drm/cirrus: initialize start and size fields Varad Gautam
2017-09-11 8:23 ` Gerd Hoffmann
2017-09-08 13:35 ` [PATCH 05/12] drm/cirrus: hardcode vram size Varad Gautam
2017-09-11 8:31 ` Gerd Hoffmann [this message]
2017-09-08 13:35 ` [PATCH 06/12] drm/cirrus: implement PRIME export for cirrus Varad Gautam
2017-09-08 13:35 ` [PATCH 07/12] drm/cirrus: use universal plane interfaces for primary plane Varad Gautam
2017-09-08 13:35 ` [PATCH 08/12] drm/cirrus: use atomic transition helpers for plane and crtc Varad Gautam
2017-09-08 13:35 ` [PATCH 09/12] drm/cirrus: send vblank on crtc atomic_flush Varad Gautam
2017-09-08 13:35 ` [PATCH 10/12] drm/cirrus: use atomic handlers for plane and crtc Varad Gautam
2017-09-08 13:35 ` [PATCH 11/12] drm/cirrus: implement atomic hardware cursor support Varad Gautam
2017-09-11 8:37 ` Gerd Hoffmann
2017-09-08 13:35 ` [PATCH 12/12] drm/cirrus: advertise DRIVER_ATOMIC Varad Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505118663.31639.3.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=marcheu@chromium.org \
--cc=varadgautam@gmail.com \
--cc=zachr@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.