From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1drfLI-0004Df-QP for mharc-grub-devel@gnu.org; Tue, 12 Sep 2017 03:10:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drfLG-0004DU-If for grub-devel@gnu.org; Tue, 12 Sep 2017 03:10:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drfLF-0005Tg-Gh for grub-devel@gnu.org; Tue, 12 Sep 2017 03:10:42 -0400 Received: from mail.gw90.de ([2a01:4f8:140:71f5::3]:45242) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drfLF-0005Sh-4l for grub-devel@gnu.org; Tue, 12 Sep 2017 03:10:41 -0400 Received: from [2a02:8109:8a80:2472:e39a:b8c3:6d51:df10] (helo=mattotaupa) by mail.gw90.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1drfLB-00043U-Eg; Tue, 12 Sep 2017 07:10:37 +0000 Message-ID: <1505200231.12343.126.camel@users.sourceforge.net> Subject: Re: [PATCH] tsc: Change default tsc calibration method to EFI on EFI systems From: Paul Menzel To: "David E. Box" Cc: grub-devel@gnu.org Date: Tue, 12 Sep 2017 09:10:31 +0200 In-Reply-To: <20170906202054.2214-1-david.e.box@linux.intel.com> References: <20170906202054.2214-1-david.e.box@linux.intel.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-A/pE81U6QUcCHtuA/7kq" X-Mailer: Evolution 3.26.0-1 Mime-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a01:4f8:140:71f5::3 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 07:10:43 -0000 --=-A/pE81U6QUcCHtuA/7kq Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dear David, Am Mittwoch, den 06.09.2017, 13:20 -0700 schrieb David E. Box: > On efi systems, make efi based tsc calibration the default, followed by > the pmtimer before using the pit. This prevents Grub boot failure on > newer x86 systems that power gate the pit. Could you please be specific, what =E2=80=9Cnewer x86 systems=E2=80=9D are?= Also, what is the =E2=80=9CGRUB boot failure=E2=80=9D? A hang? What about older EFI x86 systems? Is there a chance, that they hang now? > Signed-off-by: David E. Box > --- > grub-core/kern/i386/tsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/grub-core/kern/i386/tsc.c b/grub-core/kern/i386/tsc.c > index 2e85289d8..de4057ddb 100644 > --- a/grub-core/kern/i386/tsc.c > +++ b/grub-core/kern/i386/tsc.c > @@ -68,7 +68,7 @@ grub_tsc_init (void) > #ifdef GRUB_MACHINE_XEN > (void) (grub_tsc_calibrate_from_xen () || calibrate_tsc_hardcode()); > #elif defined (GRUB_MACHINE_EFI) > - (void) (grub_tsc_calibrate_from_pit () || grub_tsc_calibrate_from_pmti= mer () || grub_tsc_calibrate_from_efi() || calibrate_tsc_hardcode()); > + (void) (grub_tsc_calibrate_from_efi () || grub_tsc_calibrate_from_pmti= mer () || grub_tsc_calibrate_from_pit () || calibrate_tsc_hardcode()); > #elif defined (GRUB_MACHINE_COREBOOT) > (void) (grub_tsc_calibrate_from_pmtimer () || grub_tsc_calibrate_from_= pit () || calibrate_tsc_hardcode()); > #else Thanks, Paul --=-A/pE81U6QUcCHtuA/7kq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQQ8+w9d414FAVARIpk9fVorbA4dWAUCWbeIZwAKCRA9fVorbA4d WB1XAJ4wWkwXVySczRdpv+emw6yeJPZvTgCcDIZRxrPbcQ+O7OpKgsYcnRNzGYs= =qIMv -----END PGP SIGNATURE----- --=-A/pE81U6QUcCHtuA/7kq--