All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Chris Paterson <chris.paterson2@renesas.com>
Cc: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
	linux-kernel@vger.kernel.org, kuninori.morimoto.gx@renesas.com,
	ykaneko0929@gmail.com, arnd@arndb.de, geert+renesas@glider.be,
	kouichi.tomita.yn@renesas.com, takeshi.kihara.df@renesas.com,
	koji.matsuoka.xm@renesas.com
Subject: Re: [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation
Date: Wed, 10 Feb 2016 16:36:29 +0200	[thread overview]
Message-ID: <1505202.4RaxZJ1VUz@avalon> (raw)
In-Reply-To: <1455113221-18117-1-git-send-email-chris.paterson2@renesas.com>

Hi Chris,

Thank you for the patch.

On Wednesday 10 February 2016 14:07:01 Chris Paterson wrote:
> Commit 27cbd7e815a8 ("mmc: sh_mmcif: rework dma channel handling")
> introduced a typo causing the TX DMA channel allocation to be overwritten
> by the requested RX DMA channel.
> 
> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/mmc/host/sh_mmcif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index e0c076a..8d870ce 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
> @@ -445,7 +445,7 @@ static void sh_mmcif_request_dma(struct sh_mmcif_host
> *host) pdata->slave_id_rx);
>  	} else {
>  		host->chan_tx = dma_request_slave_channel(dev, "tx");
> -		host->chan_tx = dma_request_slave_channel(dev, "rx");
> +		host->chan_rx = dma_request_slave_channel(dev, "rx");
>  	}
>  	dev_dbg(dev, "%s: got channel TX %p RX %p\n", __func__, host->chan_tx,
>  		host->chan_rx);

-- 
Regards,

Laurent Pinchart


  parent reply	other threads:[~2016-02-10 14:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-10 14:07 [PATCH] mmc: sh_mmcif: Correct TX DMA channel allocation Chris Paterson
2016-02-10 14:33 ` Ulf Hansson
2016-02-10 14:36 ` Laurent Pinchart [this message]
2016-02-10 14:45 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505202.4RaxZJ1VUz@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=arnd@arndb.de \
    --cc=chris.paterson2@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=koji.matsuoka.xm@renesas.com \
    --cc=kouichi.tomita.yn@renesas.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=takeshi.kihara.df@renesas.com \
    --cc=ulf.hansson@linaro.org \
    --cc=ykaneko0929@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.