From: Justin Mitchell <jumitche@redhat.com>
To: Steve Dickson <SteveD@RedHat.com>
Cc: linux-nfs <linux-nfs@vger.kernel.org>, Bruce Fields <bfields@redhat.com>
Subject: Re: [PATCH 5/7] nfs-utils: Import libnfsidmap codebase
Date: Wed, 13 Sep 2017 16:58:25 +0100 [thread overview]
Message-ID: <1505318305.15819.33.camel@redhat.com> (raw)
In-Reply-To: <0c78c3e5-0ec8-1dcf-e608-77693596097d@RedHat.com>
On Wed, 2017-09-13 at 10:35 -0400, Steve Dickson wrote:
>
> On 09/13/2017 10:04 AM, Justin Mitchell wrote:
> > Merge the libnfsidmap code tree into nfs-utils.
> > These are the original unmodified files, cherry picked only the
> > necessary files that dont duplicate code, so will not build
> > correctly at this stage.
> >
> > Signed-off-by: Justin Mitchell <jumitche@redhat.com>
> > ---
> > utils/libnfsidmap/AUTHORS | 1 +
> > utils/libnfsidmap/COPYING | 30 +
> > utils/libnfsidmap/Makefile.am | 62 ++
> > utils/libnfsidmap/README | 126 ++++
> > utils/libnfsidmap/gums.c | 788 ++++++++++++++++++++
> > utils/libnfsidmap/idmapd.conf | 137 ++++
> > utils/libnfsidmap/idmapd.conf.5 | 308 ++++++++
> > utils/libnfsidmap/libnfsidmap.c | 709 ++++++++++++++++++
> > utils/libnfsidmap/libnfsidmap.pc.in | 11 +
> > utils/libnfsidmap/libtest.c | 160 ++++
> > utils/libnfsidmap/nfs4_uid_to_name.3 | 174 +++++
> > utils/libnfsidmap/nfsidmap.h | 67 ++
> > utils/libnfsidmap/nfsidmap_internal.h | 72 ++
> > utils/libnfsidmap/nss.c | 468 ++++++++++++
> > utils/libnfsidmap/static.c | 412 +++++++++++
> > utils/libnfsidmap/umich_ldap.c | 1302 +++++++++++++++++++++++++++++++++
> Quickly looking at this... I think the code should
> go under support/nfsidmap since that's where the
> other libraries live... Not sure how difficult it
> will be to change that...
>
> steved.
Okay, thats no problem, will wait and see what other comments there are
before i post the corrected version.
Justin
prev parent reply other threads:[~2017-09-13 15:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 13:58 [PATCH 0/7] nfs-utils: Merge libnfsidmap tree with nfs-utils Justin Mitchell
2017-09-13 14:00 ` [PATCH 1/7] nfs-utils: const-ify the config handling functions Justin Mitchell
2017-09-13 14:01 ` [PATCH 2/7] nfs-utils: Merge conf_get_str and conf_get_section Justin Mitchell
2017-09-13 14:02 ` [PATCH 3/7] nfs-utils: Add get_str with default value Justin Mitchell
2017-09-13 14:03 ` [PATCH 4/7] nfs-utils: split conffile to a separate convenience lib Justin Mitchell
2017-09-13 14:06 ` [PATCH 6/7] nfs-utils: integrate libnfsidmap code with rest of nfs-utils Justin Mitchell
2017-09-13 14:06 ` [PATCH 7/7] nfs-utils: cleanup warnings from merged libnfsidmap code Justin Mitchell
2017-09-13 15:29 ` [PATCH 0/7] nfs-utils: Merge libnfsidmap tree with nfs-utils J. Bruce Fields
[not found] ` <1505311491.15819.27.camel@redhat.com>
[not found] ` <0c78c3e5-0ec8-1dcf-e608-77693596097d@RedHat.com>
2017-09-13 15:58 ` Justin Mitchell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505318305.15819.33.camel@redhat.com \
--to=jumitche@redhat.com \
--cc=SteveD@RedHat.com \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.