All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Greg KH <gregkh@linuxfoundation.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	devel@driverdev.osuosl.org, daniel.baluta@gmail.com,
	Himanshi Jain <himshijain.hj@gmail.com>,
	Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, nick.desaulniers@gmail.com,
	outreachy-kernel@googlegroups.com, pmeerw@pmeerw.net,
	knaack.h@gmx.de, Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro
Date: Wed, 13 Sep 2017 14:58:23 -0700	[thread overview]
Message-ID: <1505339903.8969.20.camel@perches.com> (raw)
In-Reply-To: <20170913214333.mcw4f24fkzndwh5k@mwanda>

On Thu, 2017-09-14 at 00:43 +0300, Dan Carpenter wrote:
> He was exagerating a bit to call it a "static checker" warning...

Not really.

False positives and false negatives exist in just about
every static
checker.

> It's just checkpatch.pl complaining about adding spaces around the -
> operator.

checkpatch is a brain-damaged by design static checker.
regexes can only be sensitive to patterns, not compiled code.

> The sysfs file has a hyphen in the middle.

Another option would be to use an underscore instead.

  reply	other threads:[~2017-09-13 21:58 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13  8:42 [PATCH v2 0/2] Rewrite the IIO_DEVICE_ATTR_NAMED API to pass name as string Himanshi Jain
2017-09-13  8:55 ` Himanshi Jain
2017-09-13  8:44 ` [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro Himanshi Jain
2017-09-13  8:44   ` [PATCH v2 2/2] iio: Change to __ATTR_NAMED() Himanshi Jain
2017-09-13 17:03   ` [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro Jonathan Cameron
2017-09-13 18:58     ` Greg KH
2017-09-13 19:23       ` Lars-Peter Clausen
2017-09-13 20:50         ` Jonathan Cameron
2017-09-13 20:50           ` Jonathan Cameron
2017-09-18 10:49           ` Himanshi Jain
2017-09-21 13:54             ` Jonathan Cameron
2017-09-21 14:07               ` [Outreachy kernel] " Julia Lawall
2017-09-21 14:07                 ` Julia Lawall
2017-09-13 21:29         ` Greg KH
2017-09-13 21:43           ` Dan Carpenter
2017-09-13 21:58             ` Joe Perches [this message]
2017-09-13 23:16               ` Jonathan Cameron
2017-09-13 23:16                 ` Jonathan Cameron
2017-09-13 23:16                 ` Jonathan Cameron
2017-09-14  5:10               ` [Outreachy kernel] " Julia Lawall
2017-09-19 12:13           ` Lars-Peter Clausen
2017-09-13  8:46 ` [Outreachy kernel] [PATCH v2 0/2] Rewrite the IIO_DEVICE_ATTR_NAMED API to pass name as string Julia Lawall
2017-09-13 17:04   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505339903.8969.20.camel@perches.com \
    --to=joe@perches.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=dan.carpenter@oracle.com \
    --cc=daniel.baluta@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=himshijain.hj@gmail.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nick.desaulniers@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.