Re: [PATCH 1/3] credit2: libxc related changes to add support for runqueue per cpupool.

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1609 bytes --]

On Thu, 2017-09-14 at 08:42 +0200, Juergen Gross wrote:
> > --- a/tools/libxc/include/xenctrl.h
> > +++ b/tools/libxc/include/xenctrl.h
> > @@ -1077,17 +1077,21 @@ typedef struct xc_cpupoolinfo {
> >  
> >  #define XC_CPUPOOL_POOLID_ANY 0xFFFFFFFF
> >  
> > +typedef xen_sysctl_sched_param_t xc_schedparam_t;
> > +
> >  /**
> >   * Create a new cpupool.
> >   *
> >   * @parm xc_handle a handle to an open hypervisor interface
> >   * @parm ppoolid pointer to the new cpupool id (in/out)
> >   * @parm sched_id id of scheduler to use for pool
> > + * @parm sched_param parameter of the scheduler of the cpupool eg.
> > runq for credit2
> 
> I would drop "eg. runq for credit2"
> 
+1

> > --- a/tools/python/xen/lowlevel/xc/xc.c
> > +++ b/tools/python/xen/lowlevel/xc/xc.c
> > @@ -1704,6 +1704,7 @@ static PyObject *pyxc_cpupool_create(XcObject
> > *self,
> >                                       PyObject *kwds)
> >  {
> >      uint32_t cpupool = XC_CPUPOOL_POOLID_ANY, sched =
> > XEN_SCHEDULER_CREDIT;
> > +    xc_schedparam_t param;
> >  
> >      static char *kwd_list[] = { "pool", "sched", NULL };
> 
> [..]
> Another possibility would be to drop the cpupool python bindings
> completely (which I would prefer, TBH).
> 
+1

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel