From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Zhi Wang <zhi.a.wang@intel.com>,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH 2/2] drm/i915: add lockdep_assert_held in i915_ppat_{get, put}
Date: Fri, 15 Sep 2017 09:09:18 +0300 [thread overview]
Message-ID: <1505455758.5462.7.camel@linux.intel.com> (raw)
In-Reply-To: <150541438118.19729.3064402795121533009@mail.alporthouse.com>
On Thu, 2017-09-14 at 19:39 +0100, Chris Wilson wrote:
> Quoting Zhi Wang (2017-09-14 18:24:10)
> > struct_mutext needs to be held before call these two APIs.
>
> True for the moment. But raises a question of whether introducing a
> ppat->mutex would be beneficial? All depends on whether the caller is
> already forced to use struct_mutex and is likely to continue to need it
> next year...
I doubt this will be performance critical, so introducing separate
locking should not hurt.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-15 6:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 17:24 [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get() Zhi Wang
2017-09-14 17:24 ` [PATCH 2/2] drm/i915: add lockdep_assert_held in i915_ppat_{get, put} Zhi Wang
2017-09-14 18:39 ` Chris Wilson
2017-09-15 6:09 ` Joonas Lahtinen [this message]
2017-09-14 17:36 ` [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get() Rodrigo Vivi
2017-09-14 17:51 ` Wang, Zhi A
2017-09-18 13:08 ` Joonas Lahtinen
2017-09-18 13:14 ` Wang, Zhi A
2017-09-14 18:41 ` Chris Wilson
2017-09-15 3:03 ` Wang, Zhi A
2017-09-15 5:01 ` Widawsky, Benjamin
2017-09-15 5:08 ` Wang, Zhi A
2017-09-14 17:42 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2017-09-14 23:51 ` ✗ Fi.CI.IGT: warning " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2017-09-14 17:21 [PATCH 1/2] " Zhi Wang
2017-09-14 17:21 ` [PATCH 2/2] drm/i915: add lockdep_assert_held in i915_ppat_{get, put} Zhi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505455758.5462.7.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=benjamin.widawsky@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.