From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [Outreachy kernel] [PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV_* Date: Fri, 15 Sep 2017 00:28:43 -0700 Message-ID: <1505460523.27581.5.camel@perches.com> References: <20170915064742.GA8367@Haneen> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Julia Lawall , Haneen Mohammed Cc: linux-rockchip@lists.infradead.org, greg , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, outreachy-kernel , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gRnJpLCAyMDE3LTA5LTE1IGF0IDA4OjU4ICswMjAwLCBKdWxpYSBMYXdhbGwgd3JvdGU6Cj4g Cj4gT24gRnJpLCAxNSBTZXAgMjAxNywgSGFuZWVuIE1vaGFtbWVkIHdyb3RlOgo+IAo+ID4gVGhp cyBwYXRjaCByZXBsYWNlIGluc3RhbmNlcyBvZiBkZXZfaW5mby9lcnIvZGVidWcgd2l0aAo+ID4g RFJNX0RFVl9JTkZPL0VSUk9SL1dBUk4gcmVzcGVjdGl2ZWx5IGlub3JkZXIgdG8gdXNlIGEgZHJt LWZvcm1hdHRlZAo+ID4gc3BlY2lmaWMgbG9nIG1lc3NhZ2VzLiBJc3N1ZSBjb3JyZWN0ZWQgd2l0 aCB0aGUgaGVscCBvZiB0aGUgZm9sbG93aW5nCj4gPiBDb2NjaW5lbGxlIHNjcmlwdDoKW10KPiA+ IEBAIC05MzUsNyArOTQxLDggQEAgc3RhdGljIHZvaWQgZHdfbWlwaV9kc2lfZW5jb2Rlcl9kaXNh YmxlKHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlcikKPiA+ICAJCXJldHVybjsKPiA+IAo+ID4g IAlpZiAoY2xrX3ByZXBhcmVfZW5hYmxlKGRzaS0+cGNsaykpIHsKPiA+IC0JCWRldl9lcnIoZHNp LT5kZXYsICIlczogRmFpbGVkIHRvIGVuYWJsZSBwY2xrXG4iLCBfX2Z1bmNfXyk7Cj4gPiArCQlE Uk1fREVWX0VSUk9SKGRzaS0+ZGV2LAo+ID4gKwkJCSAgICAgICIlczogRmFpbGVkIHRvIGVuYWJs ZSBwY2xrXG4iLCBfX2Z1bmNfXyk7CgpUaGUgdXNlcyBvZiAiJXM6ICIgLi4uICwgX19mdW5jX18g d2l0aCBEUk1fREVWX0VSUk9SCmlzIHJlZHVuZGFudCBhbmQgc2hvdWxkIGJlIHJlbW92ZWQuCgo+ ID4gQEAgLTk2Nyw3ICs5NzQsOCBAQCBzdGF0aWMgdm9pZCBkd19taXBpX2RzaV9lbmNvZGVyX2Vu YWJsZShzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIpCj4gPiAgCQlyZXR1cm47Cj4gPiAKPiA+ ICAJaWYgKGNsa19wcmVwYXJlX2VuYWJsZShkc2ktPnBjbGspKSB7Cj4gPiAtCQlkZXZfZXJyKGRz aS0+ZGV2LCAiJXM6IEZhaWxlZCB0byBlbmFibGUgcGNsa1xuIiwgX19mdW5jX18pOwo+ID4gKwkJ RFJNX0RFVl9FUlJPUihkc2ktPmRldiwKPiA+ICsJCQkgICAgICAiJXM6IEZhaWxlZCB0byBlbmFi bGUgcGNsa1xuIiwgX19mdW5jX18pOwoKZXRjLi4uCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6465893160266498048 X-Received: by 10.202.83.19 with SMTP id h19mr13558326oib.107.1505460528575; Fri, 15 Sep 2017 00:28:48 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.36.50.5 with SMTP id j5ls619512ita.14.canary-gmail; Fri, 15 Sep 2017 00:28:47 -0700 (PDT) X-Google-Smtp-Source: ADKCNb49E83tot02h6rZoR3BLSdHN4OQhSsi3KvVCxsGZ/cnEXSGbNwVBlOi6gW81UjijKatWh0/ X-Received: by 10.101.73.198 with SMTP id t6mr15279908pgs.181.1505460527817; Fri, 15 Sep 2017 00:28:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505460527; cv=none; d=google.com; s=arc-20160816; b=lwyoVprcyzXfS34XlLcVkD/itPiLslw2PFIuIAJR/1J1D39VK7m+g3AQSyBlujLQEz hFI6GU/arlA32N9Zb5mFli5bEXdrCc1mms0L+tjJ4VGCOyFr5yOzqx1hjMUNP5TJLGR+ rI4hIQbDkc1d5AgVieaZ0G0hPBQ3SRVllvztJ3MIUgxochWssr/kLvpBf8iNzeIZutLw fE83NNxMjlJmjUunSaEQJP1m/JP7jv2UWp+T+Z3llghIGceh/GTKAjWL/Cv1EzuPd4VZ Gount8O03/YmD0cRbWCzqlCZR+OVOF807BwQ0nh6MCBDNhfxvAsPiF81rcOzg1dcHgnw CU7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to:date :cc:to:from:subject:message-id:arc-authentication-results; bh=LKvEQy8KsLcsPaJJ3GX1aUfPB/fvSCuhyEihTbkyWeI=; b=PsBLNl9fdV70muVWAFW7UUfQZpNLCYMYwJLYWNyxk9ctRsylTdyR5CUK2/VPMnHGnv bV8Qsl53mLLg3zHwHzTWUkeuute8qOYtf38sa/idmT/9GjL5q9wERgWMErn+pSemb/Y4 iFi7zlV+aS4yg40L94tH3yPNRTLGJ7dYhURdTDvzXta2gYsy9x1GG6ZbHwDmt7tVsfkh 1DB/3oEYMLp5IFbfcHNwQ80Adw1Q3KESUhkVwSQkJZwtSpSgg/o07sbr/jOa23sE3m4u Rq9XzGguA9UU5O/RVB42R44qMEjlb4Qdpv2pnW2W4ZUD9+iXBqbpqUC2aRvMnlnIWDbm N+3Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 216.40.44.147 is neither permitted nor denied by best guess record for domain of joe@perches.com) smtp.mailfrom=joe@perches.com Return-Path: Received: from smtprelay.hostedemail.com (smtprelay0147.hostedemail.com. [216.40.44.147]) by gmr-mx.google.com with ESMTPS id d125si101432itg.0.2017.09.15.00.28.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Sep 2017 00:28:47 -0700 (PDT) Received-SPF: neutral (google.com: 216.40.44.147 is neither permitted nor denied by best guess record for domain of joe@perches.com) client-ip=216.40.44.147; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 216.40.44.147 is neither permitted nor denied by best guess record for domain of joe@perches.com) smtp.mailfrom=joe@perches.com Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 2C4BD1805AAF9; Fri, 15 Sep 2017 07:28:47 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:968:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:4321:4605:5007:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12438:12740:12760:12895:13069:13161:13229:13311:13357:13439:14659:14721:21080:21433:21451:21627:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: park55_4c6cbaf02861d X-Filterd-Recvd-Size: 2214 Received: from XPS-9350 (unknown [47.151.132.55]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Fri, 15 Sep 2017 07:28:45 +0000 (UTC) Message-ID: <1505460523.27581.5.camel@perches.com> Subject: Re: [Outreachy kernel] [PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV_* From: Joe Perches To: Julia Lawall , Haneen Mohammed Cc: outreachy-kernel , Mark Yao , David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, greg Date: Fri, 15 Sep 2017 00:28:43 -0700 In-Reply-To: References: <20170915064742.GA8367@Haneen> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit On Fri, 2017-09-15 at 08:58 +0200, Julia Lawall wrote: > > On Fri, 15 Sep 2017, Haneen Mohammed wrote: > > > This patch replace instances of dev_info/err/debug with > > DRM_DEV_INFO/ERROR/WARN respectively inorder to use a drm-formatted > > specific log messages. Issue corrected with the help of the following > > Coccinelle script: [] > > @@ -935,7 +941,8 @@ static void dw_mipi_dsi_encoder_disable(struct drm_encoder *encoder) > > return; > > > > if (clk_prepare_enable(dsi->pclk)) { > > - dev_err(dsi->dev, "%s: Failed to enable pclk\n", __func__); > > + DRM_DEV_ERROR(dsi->dev, > > + "%s: Failed to enable pclk\n", __func__); The uses of "%s: " ... , __func__ with DRM_DEV_ERROR is redundant and should be removed. > > @@ -967,7 +974,8 @@ static void dw_mipi_dsi_encoder_enable(struct drm_encoder *encoder) > > return; > > > > if (clk_prepare_enable(dsi->pclk)) { > > - dev_err(dsi->dev, "%s: Failed to enable pclk\n", __func__); > > + DRM_DEV_ERROR(dsi->dev, > > + "%s: Failed to enable pclk\n", __func__); etc... From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Fri, 15 Sep 2017 00:28:43 -0700 Subject: [Outreachy kernel] [PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV_* In-Reply-To: References: <20170915064742.GA8367@Haneen> Message-ID: <1505460523.27581.5.camel@perches.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2017-09-15 at 08:58 +0200, Julia Lawall wrote: > > On Fri, 15 Sep 2017, Haneen Mohammed wrote: > > > This patch replace instances of dev_info/err/debug with > > DRM_DEV_INFO/ERROR/WARN respectively inorder to use a drm-formatted > > specific log messages. Issue corrected with the help of the following > > Coccinelle script: [] > > @@ -935,7 +941,8 @@ static void dw_mipi_dsi_encoder_disable(struct drm_encoder *encoder) > > return; > > > > if (clk_prepare_enable(dsi->pclk)) { > > - dev_err(dsi->dev, "%s: Failed to enable pclk\n", __func__); > > + DRM_DEV_ERROR(dsi->dev, > > + "%s: Failed to enable pclk\n", __func__); The uses of "%s: " ... , __func__ with DRM_DEV_ERROR is redundant and should be removed. > > @@ -967,7 +974,8 @@ static void dw_mipi_dsi_encoder_enable(struct drm_encoder *encoder) > > return; > > > > if (clk_prepare_enable(dsi->pclk)) { > > - dev_err(dsi->dev, "%s: Failed to enable pclk\n", __func__); > > + DRM_DEV_ERROR(dsi->dev, > > + "%s: Failed to enable pclk\n", __func__); etc...