diff for duplicates of <1505486153.2852.6.camel@wdc.com> diff --git a/a/1.txt b/N1/1.txt index d53609b..611642f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,22 +1,33 @@ -T24gRnJpLCAyMDE3LTA5LTE1IGF0IDE5OjA2ICswOTAwLCBEYW1pZW4gTGUgTW9hbCB3cm90ZToN -Cj4gVGhlIGZ1bmN0aW9ucyBibGtfbXFfc2NoZWRfZnJlZV9oY3R4X2RhdGEoKSwgYmxrX21xX3Nj -aGVkX3RyeV9tZXJnZSgpLA0KPiBibGtfbXFfc2NoZWRfdHJ5X2luc2VydF9tZXJnZSgpIGFuZCBi -bGtfbXFfc2NoZWRfcmVxdWVzdF9pbnNlcnRlZCgpIGFyZQ0KPiBhbGwgZXhwb3J0ZWQgc3ltYm9s -cyBidXQgYXJlIGRlY2xhcmVkIG9ubHkgaW50ZXJuYWxseSBpbg0KPiBibG9jay9ibGstbXEtc2No -ZWQuaC4gTW92ZSB0aGVzZSBkZWNsYXJhdGlvbnMgdG8gdGhlIG5ldyBmaWxlDQo+IGluY2x1ZGUv -bGludXgvYmxrLW1xLXNjaGVkLmggdG8gbWFrZSB0aGVtIGF2YWlsYWJsZSB0byBibG9jayBzY2hl -ZHVsZXINCj4gbW9kdWxlcyBpbXBsZW1lbnRlZCBvdXRzaWRlIG9mIHRoZSBibG9jayBkaXJlY3Rv -cnkuDQoNClNhbWUgY29tbWVudCBoZXJlOiBzaG91bGQgdGhlIHRpdGxlIG9mIHRoaXMgcGF0Y2gg -cGVyaGFwcyBoYXZlIGJlZW4gIk1vdmUNCmRlY2xhcmF0aW9ucyBvZiAuLi4iPw0KDQo+ICsjaWZu -ZGVmIEJMS19NUV9TQ0hFRF9IDQo+ICsjZGVmaW5lIEJMS19NUV9TQ0hFRF9IDQo+ICsNCj4gKy8q -DQo+ICsgKiBTY2hlZHVsZXIgaGVscGVyIGZ1bmN0aW9ucy4NCj4gKyAqLw0KPiArdm9pZCBibGtf -bXFfc2NoZWRfZnJlZV9oY3R4X2RhdGEoc3RydWN0IHJlcXVlc3RfcXVldWUgKnEsDQo+ICsJCQkJ -IHZvaWQgKCpleGl0KShzdHJ1Y3QgYmxrX21xX2h3X2N0eCAqKSk7DQo+ICt2b2lkIGJsa19tcV9z -Y2hlZF9yZXF1ZXN0X2luc2VydGVkKHN0cnVjdCByZXF1ZXN0ICpycSk7DQo+ICtib29sIGJsa19t -cV9zY2hlZF90cnlfbWVyZ2Uoc3RydWN0IHJlcXVlc3RfcXVldWUgKnEsIHN0cnVjdCBiaW8gKmJp -bywNCj4gKwkJCSAgICBzdHJ1Y3QgcmVxdWVzdCAqKm1lcmdlZF9yZXF1ZXN0KTsNCj4gK2Jvb2wg -YmxrX21xX3NjaGVkX3RyeV9pbnNlcnRfbWVyZ2Uoc3RydWN0IHJlcXVlc3RfcXVldWUgKnEsIHN0 -cnVjdCByZXF1ZXN0ICpycSk7DQo+ICsNCj4gKyNlbmRpZg0KDQpQbGVhc2UgbWFrZSBzdXJlIHRo -YXQgdGhlIG9yZGVyIG9mICNpbmNsdWRlIGRpcmVjdGl2ZXMgZG9lcyBub3QgYWZmZWN0IHRoZQ0K -Y29tcGlsYXRpb24gcmVzdWx0LCBlLmcuIGJ5IGFkZGluZyBmb3J3YXJkIGRlY2xhcmF0aW9ucyBm -b3IgdGhlIHN0cnVjdHVyZXMNCnVzZWQgYXMgYXJndW1lbnRzLg0KDQpUaGFua3MsDQoNCkJhcnQu +On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote: +> The functions blk_mq_sched_free_hctx_data(), blk_mq_sched_try_merge(), +> blk_mq_sched_try_insert_merge() and blk_mq_sched_request_inserted() are +> all exported symbols but are declared only internally in +> block/blk-mq-sched.h. Move these declarations to the new file +> include/linux/blk-mq-sched.h to make them available to block scheduler +> modules implemented outside of the block directory. + +Same comment here: should the title of this patch perhaps have been "Move +declarations of ..."? + +> +#ifndef BLK_MQ_SCHED_H +> +#define BLK_MQ_SCHED_H +> + +> +/* +> + * Scheduler helper functions. +> + */ +> +void blk_mq_sched_free_hctx_data(struct request_queue *q, +> + void (*exit)(struct blk_mq_hw_ctx *)); +> +void blk_mq_sched_request_inserted(struct request *rq); +> +bool blk_mq_sched_try_merge(struct request_queue *q, struct bio *bio, +> + struct request **merged_request); +> +bool blk_mq_sched_try_insert_merge(struct request_queue *q, struct request *rq); +> + +> +#endif + +Please make sure that the order of #include directives does not affect the +compilation result, e.g. by adding forward declarations for the structures +used as arguments. + +Thanks, + +Bart. diff --git a/a/content_digest b/N1/content_digest index e913f4c..5a0a597 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -11,27 +11,38 @@ "Cc\0hch@lst.de <hch@lst.de>\0" "\00:1\0" "b\0" - "T24gRnJpLCAyMDE3LTA5LTE1IGF0IDE5OjA2ICswOTAwLCBEYW1pZW4gTGUgTW9hbCB3cm90ZToN\n" - "Cj4gVGhlIGZ1bmN0aW9ucyBibGtfbXFfc2NoZWRfZnJlZV9oY3R4X2RhdGEoKSwgYmxrX21xX3Nj\n" - "aGVkX3RyeV9tZXJnZSgpLA0KPiBibGtfbXFfc2NoZWRfdHJ5X2luc2VydF9tZXJnZSgpIGFuZCBi\n" - "bGtfbXFfc2NoZWRfcmVxdWVzdF9pbnNlcnRlZCgpIGFyZQ0KPiBhbGwgZXhwb3J0ZWQgc3ltYm9s\n" - "cyBidXQgYXJlIGRlY2xhcmVkIG9ubHkgaW50ZXJuYWxseSBpbg0KPiBibG9jay9ibGstbXEtc2No\n" - "ZWQuaC4gTW92ZSB0aGVzZSBkZWNsYXJhdGlvbnMgdG8gdGhlIG5ldyBmaWxlDQo+IGluY2x1ZGUv\n" - "bGludXgvYmxrLW1xLXNjaGVkLmggdG8gbWFrZSB0aGVtIGF2YWlsYWJsZSB0byBibG9jayBzY2hl\n" - "ZHVsZXINCj4gbW9kdWxlcyBpbXBsZW1lbnRlZCBvdXRzaWRlIG9mIHRoZSBibG9jayBkaXJlY3Rv\n" - "cnkuDQoNClNhbWUgY29tbWVudCBoZXJlOiBzaG91bGQgdGhlIHRpdGxlIG9mIHRoaXMgcGF0Y2gg\n" - "cGVyaGFwcyBoYXZlIGJlZW4gIk1vdmUNCmRlY2xhcmF0aW9ucyBvZiAuLi4iPw0KDQo+ICsjaWZu\n" - "ZGVmIEJMS19NUV9TQ0hFRF9IDQo+ICsjZGVmaW5lIEJMS19NUV9TQ0hFRF9IDQo+ICsNCj4gKy8q\n" - "DQo+ICsgKiBTY2hlZHVsZXIgaGVscGVyIGZ1bmN0aW9ucy4NCj4gKyAqLw0KPiArdm9pZCBibGtf\n" - "bXFfc2NoZWRfZnJlZV9oY3R4X2RhdGEoc3RydWN0IHJlcXVlc3RfcXVldWUgKnEsDQo+ICsJCQkJ\n" - "IHZvaWQgKCpleGl0KShzdHJ1Y3QgYmxrX21xX2h3X2N0eCAqKSk7DQo+ICt2b2lkIGJsa19tcV9z\n" - "Y2hlZF9yZXF1ZXN0X2luc2VydGVkKHN0cnVjdCByZXF1ZXN0ICpycSk7DQo+ICtib29sIGJsa19t\n" - "cV9zY2hlZF90cnlfbWVyZ2Uoc3RydWN0IHJlcXVlc3RfcXVldWUgKnEsIHN0cnVjdCBiaW8gKmJp\n" - "bywNCj4gKwkJCSAgICBzdHJ1Y3QgcmVxdWVzdCAqKm1lcmdlZF9yZXF1ZXN0KTsNCj4gK2Jvb2wg\n" - "YmxrX21xX3NjaGVkX3RyeV9pbnNlcnRfbWVyZ2Uoc3RydWN0IHJlcXVlc3RfcXVldWUgKnEsIHN0\n" - "cnVjdCByZXF1ZXN0ICpycSk7DQo+ICsNCj4gKyNlbmRpZg0KDQpQbGVhc2UgbWFrZSBzdXJlIHRo\n" - "YXQgdGhlIG9yZGVyIG9mICNpbmNsdWRlIGRpcmVjdGl2ZXMgZG9lcyBub3QgYWZmZWN0IHRoZQ0K\n" - "Y29tcGlsYXRpb24gcmVzdWx0LCBlLmcuIGJ5IGFkZGluZyBmb3J3YXJkIGRlY2xhcmF0aW9ucyBm\n" - b3IgdGhlIHN0cnVjdHVyZXMNCnVzZWQgYXMgYXJndW1lbnRzLg0KDQpUaGFua3MsDQoNCkJhcnQu + "On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote:\n" + "> The functions blk_mq_sched_free_hctx_data(), blk_mq_sched_try_merge(),\n" + "> blk_mq_sched_try_insert_merge() and blk_mq_sched_request_inserted() are\n" + "> all exported symbols but are declared only internally in\n" + "> block/blk-mq-sched.h. Move these declarations to the new file\n" + "> include/linux/blk-mq-sched.h to make them available to block scheduler\n" + "> modules implemented outside of the block directory.\n" + "\n" + "Same comment here: should the title of this patch perhaps have been \"Move\n" + "declarations of ...\"?\n" + "\n" + "> +#ifndef BLK_MQ_SCHED_H\n" + "> +#define BLK_MQ_SCHED_H\n" + "> +\n" + "> +/*\n" + "> + * Scheduler helper functions.\n" + "> + */\n" + "> +void blk_mq_sched_free_hctx_data(struct request_queue *q,\n" + "> +\t\t\t\t void (*exit)(struct blk_mq_hw_ctx *));\n" + "> +void blk_mq_sched_request_inserted(struct request *rq);\n" + "> +bool blk_mq_sched_try_merge(struct request_queue *q, struct bio *bio,\n" + "> +\t\t\t struct request **merged_request);\n" + "> +bool blk_mq_sched_try_insert_merge(struct request_queue *q, struct request *rq);\n" + "> +\n" + "> +#endif\n" + "\n" + "Please make sure that the order of #include directives does not affect the\n" + "compilation result, e.g. by adding forward declarations for the structures\n" + "used as arguments.\n" + "\n" + "Thanks,\n" + "\n" + Bart. -b4cdd7c252076464636b944d6a2531e397f4d6b7038c98792922ac274ea51745 +f910050b17e46d73baac08640cdb9d3ff90a06c1128647f7d0ecac9038be0332
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.