diff for duplicates of <1505486334.2852.8.camel@wdc.com> diff --git a/a/1.txt b/N1/1.txt index 7b56085..b452330 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,16 +1,28 @@ -T24gRnJpLCAyMDE3LTA5LTE1IGF0IDE5OjA2ICswOTAwLCBEYW1pZW4gTGUgTW9hbCB3cm90ZToN -Cj4gQEAgLTQ5Miw2ICs0OTcsMTAgQEAgc3RydWN0IHJlcXVlc3RfcXVldWUgew0KPiAgCXN0cnVj -dCBibGtfaW50ZWdyaXR5IGludGVncml0eTsNCj4gICNlbmRpZgkvKiBDT05GSUdfQkxLX0RFVl9J -TlRFR1JJVFkgKi8NCj4gIA0KPiArI2lmZGVmIENPTkZJR19CTEtfREVWX1pPTkVEDQo+ICsJc3Ry -dWN0IGJsa196b25lZAl6b25lZDsNCj4gKyNlbmRpZg0KPiArDQo+ICAjaWZkZWYgQ09ORklHX1BN -DQo+ICAJc3RydWN0IGRldmljZQkJKmRldjsNCj4gIAlpbnQJCQlycG1fc3RhdHVzOw0KPiBAQCAt -Nzg1LDYgKzc5NCwxMSBAQCBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBibGtfcXVldWVfem9u -ZV9zZWN0b3JzKHN0cnVjdCByZXF1ZXN0X3F1ZXVlICpxKQ0KPiAgCXJldHVybiBibGtfcXVldWVf -aXNfem9uZWQocSkgPyBxLT5saW1pdHMuY2h1bmtfc2VjdG9ycyA6IDA7DQo+ICB9DQo+ICANCj4g -K3N0YXRpYyBpbmxpbmUgdW5zaWduZWQgaW50IGJsa19xdWV1ZV9ucl96b25lcyhzdHJ1Y3QgcmVx -dWVzdF9xdWV1ZSAqcSkNCj4gK3sNCj4gKwlyZXR1cm4gYmxrX3F1ZXVlX2lzX3pvbmVkKHEpID8g -cS0+em9uZWQubnJfem9uZXMgOiAwOw0KPiArfQ0KDQpEb2VzIHRoaXMgY29kZSBjb21waWxlIGNv -cnJlY3RseSBpZiBDT05GSUdfQkxLX0RFVl9aT05FRCBpcyBkaXNhYmxlZD8gU2hvdWxkDQp0aGUg -ZGVmaW5pdGlvbiBvZiBibGtfcXVldWVfbnJfem9uZXMoKSBwZXJoYXBzIGJlIHN1cnJvdW5kZWQg -YnkgI2lmZGVmDQpDT05GSUdfQkxLX0RFVl9aT05FRCAvICNlbmRpZj8NCg0KVGhhbmtzLA0KDQpC -YXJ0Lg== +On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote: +> @@ -492,6 +497,10 @@ struct request_queue { +> struct blk_integrity integrity; +> #endif /* CONFIG_BLK_DEV_INTEGRITY */ +> +> +#ifdef CONFIG_BLK_DEV_ZONED +> + struct blk_zoned zoned; +> +#endif +> + +> #ifdef CONFIG_PM +> struct device *dev; +> int rpm_status; +> @@ -785,6 +794,11 @@ static inline unsigned int blk_queue_zone_sectors(struct request_queue *q) +> return blk_queue_is_zoned(q) ? q->limits.chunk_sectors : 0; +> } +> +> +static inline unsigned int blk_queue_nr_zones(struct request_queue *q) +> +{ +> + return blk_queue_is_zoned(q) ? q->zoned.nr_zones : 0; +> +} + +Does this code compile correctly if CONFIG_BLK_DEV_ZONED is disabled? Should +the definition of blk_queue_nr_zones() perhaps be surrounded by #ifdef +CONFIG_BLK_DEV_ZONED / #endif? + +Thanks, + +Bart. diff --git a/a/content_digest b/N1/content_digest index 78b14ea..d3585b9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -11,21 +11,33 @@ "Cc\0hch@lst.de <hch@lst.de>\0" "\00:1\0" "b\0" - "T24gRnJpLCAyMDE3LTA5LTE1IGF0IDE5OjA2ICswOTAwLCBEYW1pZW4gTGUgTW9hbCB3cm90ZToN\n" - "Cj4gQEAgLTQ5Miw2ICs0OTcsMTAgQEAgc3RydWN0IHJlcXVlc3RfcXVldWUgew0KPiAgCXN0cnVj\n" - "dCBibGtfaW50ZWdyaXR5IGludGVncml0eTsNCj4gICNlbmRpZgkvKiBDT05GSUdfQkxLX0RFVl9J\n" - "TlRFR1JJVFkgKi8NCj4gIA0KPiArI2lmZGVmIENPTkZJR19CTEtfREVWX1pPTkVEDQo+ICsJc3Ry\n" - "dWN0IGJsa196b25lZAl6b25lZDsNCj4gKyNlbmRpZg0KPiArDQo+ICAjaWZkZWYgQ09ORklHX1BN\n" - "DQo+ICAJc3RydWN0IGRldmljZQkJKmRldjsNCj4gIAlpbnQJCQlycG1fc3RhdHVzOw0KPiBAQCAt\n" - "Nzg1LDYgKzc5NCwxMSBAQCBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBibGtfcXVldWVfem9u\n" - "ZV9zZWN0b3JzKHN0cnVjdCByZXF1ZXN0X3F1ZXVlICpxKQ0KPiAgCXJldHVybiBibGtfcXVldWVf\n" - "aXNfem9uZWQocSkgPyBxLT5saW1pdHMuY2h1bmtfc2VjdG9ycyA6IDA7DQo+ICB9DQo+ICANCj4g\n" - "K3N0YXRpYyBpbmxpbmUgdW5zaWduZWQgaW50IGJsa19xdWV1ZV9ucl96b25lcyhzdHJ1Y3QgcmVx\n" - "dWVzdF9xdWV1ZSAqcSkNCj4gK3sNCj4gKwlyZXR1cm4gYmxrX3F1ZXVlX2lzX3pvbmVkKHEpID8g\n" - "cS0+em9uZWQubnJfem9uZXMgOiAwOw0KPiArfQ0KDQpEb2VzIHRoaXMgY29kZSBjb21waWxlIGNv\n" - "cnJlY3RseSBpZiBDT05GSUdfQkxLX0RFVl9aT05FRCBpcyBkaXNhYmxlZD8gU2hvdWxkDQp0aGUg\n" - "ZGVmaW5pdGlvbiBvZiBibGtfcXVldWVfbnJfem9uZXMoKSBwZXJoYXBzIGJlIHN1cnJvdW5kZWQg\n" - "YnkgI2lmZGVmDQpDT05GSUdfQkxLX0RFVl9aT05FRCAvICNlbmRpZj8NCg0KVGhhbmtzLA0KDQpC\n" - YXJ0Lg== + "On Fri, 2017-09-15 at 19:06 +0900, Damien Le Moal wrote:\n" + "> @@ -492,6 +497,10 @@ struct request_queue {\n" + "> \tstruct blk_integrity integrity;\n" + "> #endif\t/* CONFIG_BLK_DEV_INTEGRITY */\n" + "> \n" + "> +#ifdef CONFIG_BLK_DEV_ZONED\n" + "> +\tstruct blk_zoned\tzoned;\n" + "> +#endif\n" + "> +\n" + "> #ifdef CONFIG_PM\n" + "> \tstruct device\t\t*dev;\n" + "> \tint\t\t\trpm_status;\n" + "> @@ -785,6 +794,11 @@ static inline unsigned int blk_queue_zone_sectors(struct request_queue *q)\n" + "> \treturn blk_queue_is_zoned(q) ? q->limits.chunk_sectors : 0;\n" + "> }\n" + "> \n" + "> +static inline unsigned int blk_queue_nr_zones(struct request_queue *q)\n" + "> +{\n" + "> +\treturn blk_queue_is_zoned(q) ? q->zoned.nr_zones : 0;\n" + "> +}\n" + "\n" + "Does this code compile correctly if CONFIG_BLK_DEV_ZONED is disabled? Should\n" + "the definition of blk_queue_nr_zones() perhaps be surrounded by #ifdef\n" + "CONFIG_BLK_DEV_ZONED / #endif?\n" + "\n" + "Thanks,\n" + "\n" + Bart. -7fd89509035143d364db42760a64764ab3b286d3548b3e6a517810af52e46e2a +3e883d83bdaa6393065c943170ca98d993c57cc0f03a75174b2b9aa6f2edb889
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.