From: Johannes Berg <johannes@sipsolutions.net>
To: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>,
linux-wireless@vger.kernel.org
Cc: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>,
Avinash Patil <avinashp@quantenna.com>
Subject: Re: [PATCH 2/2] qtnfmac: abort scans on wireless interface changes
Date: Mon, 18 Sep 2017 10:41:08 +0200 [thread overview]
Message-ID: <1505724068.13691.0.camel@sipsolutions.net> (raw)
In-Reply-To: <20170918080446.21763-3-sergey.matyukevich.os@quantenna.com> (sfid-20170918_100515_833823_05EC3731)
On Mon, 2017-09-18 at 11:04 +0300, Sergey Matyukevich wrote:
>
> */
> static int qtnf_netdev_close(struct net_device *ndev)
> {
> - netif_carrier_off(ndev);
> qtnf_virtual_intf_cleanup(ndev);
> qtnf_netdev_updown(ndev, 0);
> + netif_carrier_off(ndev);
> return 0;
> }
This seems unrelated?
> - if (timer_pending(&mac->scan_timeout))
> - del_timer_sync(&mac->scan_timeout);
> qtnf_scan_done(mac, le32_to_cpu(status->flags) &
> QLINK_SCAN_ABORTED);
and that's related perhaps but not really explained in the changelog,
not sure?
johannes
next prev parent reply other threads:[~2017-09-18 8:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 8:04 [PATCH RESEND 0/2] qtnfmac: misc fixes intended for 4.14 Sergey Matyukevich
2017-09-18 8:04 ` [PATCH 1/2] qtnfmac: lock access to h/w in tx path Sergey Matyukevich
2017-09-18 8:04 ` [PATCH 2/2] qtnfmac: abort scans on wireless interface changes Sergey Matyukevich
2017-09-18 8:41 ` Johannes Berg [this message]
2017-09-18 9:57 ` Sergey Matyukevich
2017-09-18 10:03 ` Johannes Berg
2017-09-18 10:16 ` Sergey Matyukevich
2017-09-18 10:20 ` Johannes Berg
2017-09-18 10:31 ` Sergey Matyukevich
2017-09-18 12:51 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2017-09-15 11:52 [PATCH 0/2] qtnfmac: misc fixes intended for 4.14 Sergey Matyukevich
2017-09-15 11:53 ` [PATCH 2/2] qtnfmac: abort scans on wireless interface changes Sergey Matyukevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505724068.13691.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=avinashp@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sergey.matyukevich.os@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.