Re: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb

[Gerd Hoffmann <kraxel@redhat.com>]

  Hi,

> > So I did the keymaps build with a recursive make call too, which
> > doesn't look that pretty ...
> 
> I don't think that's too ugly, but I wonder if there's some way to
> avoid
> the recursive make call.
> 
> It feels like this is a similar scenario to 'config-host.mak' being
> outdated. I don't entirely understand the logic yet, but we manage to
> automatically re-run configure and rebuild config-host.make, when
> configure changes, and that in turn affects which dependancies need
> rebuild.

Can't spot anything special in the Makefile.  Maybe make is clever
enough to figure that a rule updates a include file and starts over
then.

> I wonder if we can somehow integrate into that process, so
> that configure is responsible for checking out the git submodules,
> then make the re-running of configure trigger when .gitmodules
> changes content.

.gitmodules only has the repo links, not the checkout hashes.  So it
wouldn't be touched on updates.

I can't see an easy way for make to figure a submodule has changed,
other than running "git submodule update".

cheers,
  Gerd