From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Wed, 20 Sep 2017 02:35:23 +0000 Subject: Re: [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly Message-Id: <1505874923.2067.14.camel@perches.com> List-Id: References: <20170919155534.25334-1-colin.king@canonical.com> <20170919214614.cfiolgznopouv34e@zhen-hp.sh.intel.com> In-Reply-To: <20170919214614.cfiolgznopouv34e@zhen-hp.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Zhenyu Wang , Colin King Cc: fred gao , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi , intel-gvt-dev@lists.freedesktop.org, Zhi Wang On Wed, 2017-09-20 at 05:46 +0800, Zhenyu Wang wrote: > On 2017.09.19 16:55:34 +0100, Colin King wrote: > > From: Colin Ian King > > > > An earlier fix changed the return type from find_bb_size however the > > integer return is being assigned to a unsigned int so the -ve error > > check will never be detected. Make bb_size an int to fix this. > > > > Detected by CoverityScan CID#1456886 ("Unsigned compared against 0") > > > > Fixes: 1e3197d6ad73 ("drm/i915/gvt: Refine error handling for perform_bb_shadow") > > Signed-off-by: Colin Ian King > > --- > > drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c > > index 2c0ccbb817dc..f41cbf664b69 100644 > > --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c > > +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c > > @@ -1628,7 +1628,7 @@ static int perform_bb_shadow(struct parser_exec_state *s) > > struct intel_shadow_bb_entry *entry_obj; > > struct intel_vgpu *vgpu = s->vgpu; > > unsigned long gma = 0; > > - uint32_t bb_size; > > + int bb_size; > > void *dst = NULL; > > int ret = 0; > > > > Applied this, thanks! Is it possible for bb_size to be both >= 2g and valid? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly Date: Tue, 19 Sep 2017 19:35:23 -0700 Message-ID: <1505874923.2067.14.camel@perches.com> References: <20170919155534.25334-1-colin.king@canonical.com> <20170919214614.cfiolgznopouv34e@zhen-hp.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtprelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by gabe.freedesktop.org (Postfix) with ESMTPS id B1C306E179 for ; Wed, 20 Sep 2017 02:35:29 +0000 (UTC) In-Reply-To: <20170919214614.cfiolgznopouv34e@zhen-hp.sh.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Zhenyu Wang , Colin King Cc: fred gao , intel-gfx@lists.freedesktop.org, Joonas Lahtinen , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi , intel-gvt-dev@lists.freedesktop.org, Zhi Wang List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAyMDE3LTA5LTIwIGF0IDA1OjQ2ICswODAwLCBaaGVueXUgV2FuZyB3cm90ZToKPiBP biAyMDE3LjA5LjE5IDE2OjU1OjM0ICswMTAwLCBDb2xpbiBLaW5nIHdyb3RlOgo+ID4gRnJvbTog Q29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4KPiA+IAo+ID4gQW4gZWFy bGllciBmaXggY2hhbmdlZCB0aGUgcmV0dXJuIHR5cGUgZnJvbSBmaW5kX2JiX3NpemUgaG93ZXZl ciB0aGUKPiA+IGludGVnZXIgcmV0dXJuIGlzIGJlaW5nIGFzc2lnbmVkIHRvIGEgdW5zaWduZWQg aW50IHNvIHRoZSAtdmUgZXJyb3IKPiA+IGNoZWNrIHdpbGwgbmV2ZXIgYmUgZGV0ZWN0ZWQuIE1h a2UgYmJfc2l6ZSBhbiBpbnQgdG8gZml4IHRoaXMuCj4gPiAKPiA+IERldGVjdGVkIGJ5IENvdmVy aXR5U2NhbiBDSUQjMTQ1Njg4NiAoIlVuc2lnbmVkIGNvbXBhcmVkIGFnYWluc3QgMCIpCj4gPiAK PiA+IEZpeGVzOiAxZTMxOTdkNmFkNzMgKCJkcm0vaTkxNS9ndnQ6IFJlZmluZSBlcnJvciBoYW5k bGluZyBmb3IgcGVyZm9ybV9iYl9zaGFkb3ciKQo+ID4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFu IEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2d2dC9jbWRfcGFyc2VyLmMgfCAyICstCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDEg aW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9ndnQvY21kX3BhcnNlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0 L2NtZF9wYXJzZXIuYwo+ID4gaW5kZXggMmMwY2NiYjgxN2RjLi5mNDFjYmY2NjRiNjkgMTAwNjQ0 Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvY21kX3BhcnNlci5jCj4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvY21kX3BhcnNlci5jCj4gPiBAQCAtMTYyOCw3ICsx NjI4LDcgQEAgc3RhdGljIGludCBwZXJmb3JtX2JiX3NoYWRvdyhzdHJ1Y3QgcGFyc2VyX2V4ZWNf c3RhdGUgKnMpCj4gPiAgCXN0cnVjdCBpbnRlbF9zaGFkb3dfYmJfZW50cnkgKmVudHJ5X29iajsK PiA+ICAJc3RydWN0IGludGVsX3ZncHUgKnZncHUgPSBzLT52Z3B1Owo+ID4gIAl1bnNpZ25lZCBs b25nIGdtYSA9IDA7Cj4gPiAtCXVpbnQzMl90IGJiX3NpemU7Cj4gPiArCWludCBiYl9zaXplOwo+ ID4gIAl2b2lkICpkc3QgPSBOVUxMOwo+ID4gIAlpbnQgcmV0ID0gMDsKPiA+ICAKPiAKPiBBcHBs aWVkIHRoaXMsIHRoYW5rcyEKCklzIGl0IHBvc3NpYmxlIGZvciBiYl9zaXplIHRvIGJlIGJvdGgg Pj0gMmcgYW5kIHZhbGlkPwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751509AbdITCf3 (ORCPT ); Tue, 19 Sep 2017 22:35:29 -0400 Received: from smtprelay0116.hostedemail.com ([216.40.44.116]:33153 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750872AbdITCf2 (ORCPT ); Tue, 19 Sep 2017 22:35:28 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3871:3872:4321:5007:6119:6238:6742:7576:7903:8957:9040:10004:10400:10848:10967:11026:11232:11473:11657:11658:11914:12043:12296:12438:12555:12740:12760:12895:13069:13255:13311:13357:13439:14096:14097:14181:14659:14721:21080:21324:21451:21627:30054:30055:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: smile74_86a52a56e8b2c X-Filterd-Recvd-Size: 2594 Message-ID: <1505874923.2067.14.camel@perches.com> Subject: Re: [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly From: Joe Perches To: Zhenyu Wang , Colin King Cc: fred gao , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 19 Sep 2017 19:35:23 -0700 In-Reply-To: <20170919214614.cfiolgznopouv34e@zhen-hp.sh.intel.com> References: <20170919155534.25334-1-colin.king@canonical.com> <20170919214614.cfiolgznopouv34e@zhen-hp.sh.intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-09-20 at 05:46 +0800, Zhenyu Wang wrote: > On 2017.09.19 16:55:34 +0100, Colin King wrote: > > From: Colin Ian King > > > > An earlier fix changed the return type from find_bb_size however the > > integer return is being assigned to a unsigned int so the -ve error > > check will never be detected. Make bb_size an int to fix this. > > > > Detected by CoverityScan CID#1456886 ("Unsigned compared against 0") > > > > Fixes: 1e3197d6ad73 ("drm/i915/gvt: Refine error handling for perform_bb_shadow") > > Signed-off-by: Colin Ian King > > --- > > drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c > > index 2c0ccbb817dc..f41cbf664b69 100644 > > --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c > > +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c > > @@ -1628,7 +1628,7 @@ static int perform_bb_shadow(struct parser_exec_state *s) > > struct intel_shadow_bb_entry *entry_obj; > > struct intel_vgpu *vgpu = s->vgpu; > > unsigned long gma = 0; > > - uint32_t bb_size; > > + int bb_size; > > void *dst = NULL; > > int ret = 0; > > > > Applied this, thanks! Is it possible for bb_size to be both >= 2g and valid?