From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 51DA020945B6F for ; Thu, 21 Sep 2017 14:04:39 -0700 (PDT) From: "Williams, Dan J" Subject: [GIT PULL] libnvdimm fixes for 4.14-rc2 Date: Thu, 21 Sep 2017 21:07:45 +0000 Message-ID: <1506028051.30769.1.camel@intel.com> Content-Language: en-US Content-ID: <9CA13E54D2EDE14F8EC140AD5FF7BE1D@intel.com> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-7" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "torvalds@linux-foundation.org" Cc: "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" List-ID: SGkgTGludXMsIHBsZWFzZSBwdWxsIGZyb206CgogIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9z Y20vbGludXgva2VybmVsL2dpdC9udmRpbW0vbnZkaW1tIGxpYm52ZGltbS1maXhlcwoKLi4udG8g cmVjZWl2ZSBhIGNyYXNoK0FLQS1maXggYW5kIGNvcnJlc3BvbmRpbmcgcmVncmVzc2lvbiB0ZXN0 IGVuYWJsaW5nCmZvciB0aGUgY3Jhc2ggc2NlbmFyaW8uIFRoZSB1bml0IHRlc3QgZm9yIHRoaXMg Y3Jhc2ggaXMgYXZhaWxhYmxlIGluCm5kY3RsLXY1OC4yLiBUaGlzIGJyYW5jaCBoYXMgcmVjZWl2 ZWQgYSBidWlsZCBzdWNjZXNzIG5vdGlmaWNhdGlvbiBmcm9tCnRoZSAwZGF5LWtidWlsZCByb2Jv dCBvdmVyIDE0OCBjb25maWdzLiBUaGUgZml4IGlzIHRhZ2dlZCBmb3IgLXN0YWJsZSAvCmJhY2tw b3J0IHRvIDQuMTMuCgotLS0KClRoZSBmb2xsb3dpbmcgY2hhbmdlcyBzaW5jZSBjb21taXQgMmJk NmJmMDNmNGMxYzU5MzgxZDYyYzYxZDAzZjZjYzNmZTcxZjY2ZToKCiAgTGludXggNC4xNC1yYzEg KDIwMTctMDktMTYgMTU6NDc6NTEgLTA3MDApCgphcmUgYXZhaWxhYmxlIGluIHRoZSBnaXQgcmVw b3NpdG9yeSBhdDoKCiAgZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwv Z2l0L252ZGltbS9udmRpbW0gbGlibnZkaW1tLWZpeGVzCgpmb3IgeW91IHRvIGZldGNoIGNoYW5n ZXMgdXAgdG8gMzNhNTYwODY3MTI1NjFiOGI5Y2RjODgxZTAzMTdmNGMzNjg2MWY3MjoKCiAgbGli bnZkaW1tLCBuYW1lc3BhY2U6IGZpeCBidHQgY2xhaW0gY2xhc3MgY3Jhc2ggKDIwMTctMDktMTgg MTc6Mjk6MDEgLTA3MDApCgotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkRhbiBXaWxsaWFtcyAoMik6CiAgICAgIHRvb2xzL3Rl c3RpbmcvbnZkaW1tOiBkaXNhYmxlIGxhYmVscyBmb3IgbmZpdF90ZXN0LjEKICAgICAgbGlibnZk aW1tLCBuYW1lc3BhY2U6IGZpeCBidHQgY2xhaW0gY2xhc3MgY3Jhc2gKCiBkcml2ZXJzL252ZGlt bS9uYW1lc3BhY2VfZGV2cy5jICB8IDkgKy0rLSstKy0rLSstKy0rLSstCiB0b29scy90ZXN0aW5n L252ZGltbS90ZXN0L25maXQuYyB8IDMgLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9u cygrLSksIDMgZGVsZXRpb25zKC0pCgpjb21taXQgNWU3NWZlMzkyNzU1OTUwNTY4MmIwMDUzYjU3 NDVlM2Y0MmQ2NmU4YwpBdXRob3I6IERhbiBXaWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwu Y29tPgpEYXRlOiAgIE1vbiBTZXAgMTggMTc6MTk6MTAgMjAxNyAtMDcwMAoKICAgIHRvb2xzL3Rl c3RpbmcvbnZkaW1tOiBkaXNhYmxlIGxhYmVscyBmb3IgbmZpdF90ZXN0LjEKICAgIAogICAgSW1w cm92ZSBjb3ZlcmFnZSBvZiBOVkRJTU0tTiB0ZXN0IHNjZW5hcmlvcyBieSBwcm92aWRpbmcgYSB0 ZXN0IGJ1cwogICAgaW5jYXBhYmxlIG9mIGxhYmVsIG9wZXJhdGlvbnMuCiAgICAKICAgIFNpZ25l ZC1vZmYtYnk6IERhbiBXaWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29tPgoKY29tbWl0 IDMzYTU2MDg2NzEyNTYxYjhiOWNkYzg4MWUwMzE3ZjRjMzY4NjFmNzIKQXV0aG9yOiBEYW4gV2ls bGlhbXMgPGRhbi5qLndpbGxpYW1zQGludGVsLmNvbT4KRGF0ZTogICBNb24gU2VwIDE4IDE0OjQ4 OjU4IDIwMTcgLTA3MDAKCiAgICBsaWJudmRpbW0sIG5hbWVzcGFjZTogZml4IGJ0dCBjbGFpbSBj bGFzcyBjcmFzaAogICAgCiAgICBNYXVyaWNlIHJlcG9ydHM6CiAgICAKICAgICAgICBCVUc6IHVu YWJsZSB0byBoYW5kbGUga2VybmVsIE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZSBhdCAwMDAwMDAw MDAwMDAwMDI4CiAgICAgICAgSVA6IGhvbGRlcl9jbGFzc19zdG9yZSstMHgyNTMvMHgyYjAgW2xp Ym52ZGltbV0KICAgIAogICAgLi4ud2hpbGUgdHJ5aW5nIHRvIHJlY29uZmlndXJlIGFuIE5WRElN TS1OIG5hbWVzcGFjZSBpbnRvICdzZWN0b3InIC8KICAgICdidHQnIG1vZGUuIFRoZSBjcmFzaCBw b2ludHMgdG8gdGhpcyBsaW5lOgogICAgCiAgICAgICAgKGdkYikgbGkgKihob2xkZXJfY2xhc3Nf c3RvcmUrLTB4MjUzKQogICAgICAgIDB4Nzc3MyBpcyBpbiBob2xkZXJfY2xhc3Nfc3RvcmUgKGRy aXZlcnMvbnZkaW1tL25hbWVzcGFjZV9kZXZzLmM6MTQyMCkuCiAgICAgICAgMTQxNSAgICAgICAg ICAgIGZvciAoaSA9IDA7IGkgPCBuZF9yZWdpb24tPm5kcl9tYXBwaW5nczsgaSstKy0pIHsKICAg ICAgICAxNDE2ICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgbmRfbWFwcGluZyAqbmRfbWFwcGlu ZyA9ICZuZF9yZWdpb24tPm1hcHBpbmdbaV07CiAgICAgICAgMTQxNyAgICAgICAgICAgICAgICAg ICAgc3RydWN0IG52ZGltbV9kcnZkYXRhICpuZGQgPSB0b19uZGQobmRfbWFwcGluZyk7CiAgICAg ICAgMTQxOCAgICAgICAgICAgICAgICAgICAgc3RydWN0IG5kX25hbWVzcGFjZV9pbmRleCAqbnNp bmRleDsKICAgICAgICAxNDE5CiAgICAgICAgMTQyMCAgICAgICAgICAgICAgICAgICAgbnNpbmRl eCA9IHRvX25hbWVzcGFjZV9pbmRleChuZGQsIG5kZC0+bnNfY3VycmVudCk7CiAgICAKICAgIC4u LndoZXJlIHdlIGFyZSBmYWlsaW5nIGJlY2F1c2UgbmRkIGlzIE5VTEwgZHVlIHRvIE5WRElNTS1O IGRpbW1zIG5vdAogICAgc3VwcG9ydGluZyBsYWJlbHMuCiAgICAKICAgIExvbmcgc3Rvcnkgc2hv cnQsIGRlZmF1bHQgdG8gdGhlIEJUVHYxIGZvcm1hdCBpbiB0aGUgbGFiZWwtbGVzcyAvCiAgICBO VkRJTU0tTiBjYXNlLgogICAgCiAgICBGaXhlczogMTRlNDk0NTQyNjM2ICgibGlibnZkaW1tLCBi dHQ6IEJUVCB1cGRhdGVzIGZvciBVRUZJIDIuNyBmb3JtYXQiKQogICAgQ2M6IDxzdGFibGVAdmdl ci5rZXJuZWwub3JnPgogICAgQ2M6IFZpc2hhbCBWZXJtYSA8dmlzaGFsLmwudmVybWFAaW50ZWwu Y29tPgogICAgUmVwb3J0ZWQtYnk6IE1hdXJpY2UgQS4gU2FsZGl2YXIgPG1hdXJpY2UuYS5zYWxk aXZhckBocGUuY29tPgogICAgVGVzdGVkLWJ5OiBNYXVyaWNlIEEuIFNhbGRpdmFyIDxtYXVyaWNl LmEuc2FsZGl2YXJAaHBlLmNvbT4KICAgIFNpZ25lZC1vZmYtYnk6IERhbiBXaWxsaWFtcyA8ZGFu Lmoud2lsbGlhbXNAaW50ZWwuY29tPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpMaW51eC1udmRpbW0gbWFpbGluZyBsaXN0CkxpbnV4LW52ZGltbUBsaXN0 cy4wMS5vcmcKaHR0cHM6Ly9saXN0cy4wMS5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1udmRp bW0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751833AbdIUVHs convert rfc822-to-8bit (ORCPT ); Thu, 21 Sep 2017 17:07:48 -0400 Received: from mga01.intel.com ([192.55.52.88]:40627 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751785AbdIUVHr (ORCPT ); Thu, 21 Sep 2017 17:07:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,426,1500966000"; d="scan'208";a="151975254" From: "Williams, Dan J" To: "torvalds@linux-foundation.org" CC: "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" Subject: [GIT PULL] libnvdimm fixes for 4.14-rc2 Thread-Topic: [GIT PULL] libnvdimm fixes for 4.14-rc2 Thread-Index: AQHTMx2rom8vbXtuDk2CCLBULl69Sw== Date: Thu, 21 Sep 2017 21:07:45 +0000 Message-ID: <1506028051.30769.1.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.24.8.109] Content-Type: text/plain; charset="utf-7" Content-ID: <9CA13E54D2EDE14F8EC140AD5FF7BE1D@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm libnvdimm-fixes ...to receive a crash+AKA-fix and corresponding regression test enabling for the crash scenario. The unit test for this crash is available in ndctl-v58.2. This branch has received a build success notification from the 0day-kbuild robot over 148 configs. The fix is tagged for -stable / backport to 4.13. --- The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e: Linux 4.14-rc1 (2017-09-16 15:47:51 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm libnvdimm-fixes for you to fetch changes up to 33a56086712561b8b9cdc881e0317f4c36861f72: libnvdimm, namespace: fix btt claim class crash (2017-09-18 17:29:01 -0700) ---------------------------------------------------------------- Dan Williams (2): tools/testing/nvdimm: disable labels for nfit+AF8-test.1 libnvdimm, namespace: fix btt claim class crash drivers/nvdimm/namespace+AF8-devs.c +AHw- 9 +-+-+-+-+-+-+-+-+- tools/testing/nvdimm/test/nfit.c +AHw- 3 --- 2 files changed, 9 insertions(+-), 3 deletions(-) commit 5e75fe3927559505682b0053b5745e3f42d66e8c Author: Dan Williams +ADw-dan.j.williams+AEA-intel.com+AD4- Date: Mon Sep 18 17:19:10 2017 -0700 tools/testing/nvdimm: disable labels for nfit+AF8-test.1 Improve coverage of NVDIMM-N test scenarios by providing a test bus incapable of label operations. Signed-off-by: Dan Williams +ADw-dan.j.williams+AEA-intel.com+AD4- commit 33a56086712561b8b9cdc881e0317f4c36861f72 Author: Dan Williams +ADw-dan.j.williams+AEA-intel.com+AD4- Date: Mon Sep 18 14:48:58 2017 -0700 libnvdimm, namespace: fix btt claim class crash Maurice reports: BUG: unable to handle kernel NULL pointer dereference at 0000000000000028 IP: holder+AF8-class+AF8-store+-0x253/0x2b0 +AFs-libnvdimm+AF0- ...while trying to reconfigure an NVDIMM-N namespace into 'sector' / 'btt' mode. The crash points to this line: (gdb) li +ACo-(holder+AF8-class+AF8-store+-0x253) 0x7773 is in holder+AF8-class+AF8-store (drivers/nvdimm/namespace+AF8-devs.c:1420). 1415 for (i +AD0- 0+ADs- i +ADw- nd+AF8-region-+AD4-ndr+AF8-mappings+ADs- i+-+-) +AHs- 1416 struct nd+AF8-mapping +ACo-nd+AF8-mapping +AD0- +ACY-nd+AF8-region-+AD4-mapping+AFs-i+AF0AOw- 1417 struct nvdimm+AF8-drvdata +ACo-ndd +AD0- to+AF8-ndd(nd+AF8-mapping)+ADs- 1418 struct nd+AF8-namespace+AF8-index +ACo-nsindex+ADs- 1419 1420 nsindex +AD0- to+AF8-namespace+AF8-index(ndd, ndd-+AD4-ns+AF8-current)+ADs- ...where we are failing because ndd is NULL due to NVDIMM-N dimms not supporting labels. Long story short, default to the BTTv1 format in the label-less / NVDIMM-N case. Fixes: 14e494542636 (+ACI-libnvdimm, btt: BTT updates for UEFI 2.7 format+ACI-) Cc: +ADw-stable+AEA-vger.kernel.org+AD4- Cc: Vishal Verma +ADw-vishal.l.verma+AEA-intel.com+AD4- Reported-by: Maurice A. Saldivar +ADw-maurice.a.saldivar+AEA-hpe.com+AD4- Tested-by: Maurice A. Saldivar +ADw-maurice.a.saldivar+AEA-hpe.com+AD4- Signed-off-by: Dan Williams +ADw-dan.j.williams+AEA-intel.com+AD4-