All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6] mx6sabresd: Avoid calling setup_display() from SPL code
Date: Fri, 22 Sep 2017 23:45:28 -0300	[thread overview]
Message-ID: <1506134733-30962-1-git-send-email-festevam@gmail.com> (raw)

From: Fabio Estevam <fabio.estevam@nxp.com>

There is no need call setup_display() from SPL code, so move it to
board_init(), which executes only in U-Boot proper.

Reported-by: Stefano Babic <sbabic@denx.de>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 board/freescale/mx6sabresd/mx6sabresd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
index 5b50bc8..f14b759 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -620,9 +620,6 @@ int board_ehci_power(int port, int on)
 int board_early_init_f(void)
 {
 	setup_iomux_uart();
-#if defined(CONFIG_VIDEO_IPUV3)
-	setup_display();
-#endif
 
 	return 0;
 }
@@ -639,6 +636,9 @@ int board_init(void)
 		setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &mx6q_i2c_pad_info1);
 	else
 		setup_i2c(1, CONFIG_SYS_I2C_SPEED, 0x7f, &mx6dl_i2c_pad_info1);
+#if defined(CONFIG_VIDEO_IPUV3)
+	setup_display();
+#endif
 #ifdef CONFIG_USB_EHCI_MX6
 	setup_usb();
 #endif
-- 
2.7.4

             reply	other threads:[~2017-09-23  2:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-23  2:45 Fabio Estevam [this message]
2017-09-23  2:45 ` [U-Boot] [PATCH 2/6] cgtqmx6eval: Avoid calling setup_display() from SPL code Fabio Estevam
2017-09-23  8:07   ` Stefano Babic
2017-09-23  2:45 ` [U-Boot] [PATCH 3/6] wandboard: " Fabio Estevam
2017-09-23  8:07   ` Stefano Babic
2017-09-23  2:45 ` [U-Boot] [PATCH 4/6] mx6cuboxi: " Fabio Estevam
2017-09-23  8:07   ` Stefano Babic
2017-09-23  2:45 ` [U-Boot] [PATCH 5/6] apalis_imx6: " Fabio Estevam
2017-09-23  8:43   ` Stefano Babic
2017-09-23 13:01     ` Fabio Estevam
2017-09-23 15:11       ` Fabio Estevam
2017-09-25 13:46         ` Stefano Babic
2017-09-23 19:06     ` Anatolij Gustschin
2017-09-24 11:27       ` Max Krummenacher
2017-09-25 13:47         ` Stefano Babic
2017-09-23  2:45 ` [U-Boot] [PATCH 6/6] colibri_imx6: " Fabio Estevam
2017-09-24 11:31   ` Max Krummenacher
2017-09-23  8:06 ` [U-Boot] [PATCH 1/6] mx6sabresd: " Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1506134733-30962-1-git-send-email-festevam@gmail.com \
    --to=festevam@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.