From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753839AbdIYGQj (ORCPT ); Mon, 25 Sep 2017 02:16:39 -0400 Received: from mga05.intel.com ([192.55.52.43]:35640 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753469AbdIYGQh (ORCPT ); Mon, 25 Sep 2017 02:16:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,435,1500966000"; d="scan'208";a="1198616597" From: "Winkler, Tomas" To: "rafael@kernel.org" CC: "linux-kernel@vger.kernel.org" , "gregkh@linuxfoundation.org" , "Usyskin, Alexander" , "stable@vger.kernel.org" Subject: Re: [char-misc 1/2] mei: always use domain runtime pm callbacks. Thread-Topic: [char-misc 1/2] mei: always use domain runtime pm callbacks. Thread-Index: AQHTNYW6HZTs/F2BZEuLI+DqCwIVvaLE7QgA Date: Mon, 25 Sep 2017 06:16:33 +0000 Message-ID: <1506319914.18468.1.camel@intel.com> References: <20170924083534.20394-1-tomas.winkler@intel.com> <20170924083534.20394-2-tomas.winkler@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.91.43] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v8P6HKvA005098 On Mon, 2017-09-25 at 00:37 +0200, Rafael J. Wysocki wrote: > On Sun, Sep 24, 2017 at 10:35 AM, Tomas Winkler wrote: > > From: Alexander Usyskin > > > > This patch fixes a regression caused by the new changes > > in the run wake handlers, pci_dev_run_wake() return true > > when wake is possible from the software perspective > > not whether it is actually enabled. > > This isn't exactly accurate, because "run wake" used to mean "wakeup > signals can be generated for this device in the working state of the > system", so it could not be enabled or disabled before too. It's just > that the function returns "true" for (at least) some devices for which > it used to return "false" (arguably incorrectly). > > Other than that I agree with the patch. Thanks for the correction, I will respin the patch with your explanation. Thanks Tomas