From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] usb: Fix usb-host build
Date: Tue, 26 Sep 2017 08:36:06 +0200 [thread overview]
Message-ID: <1506407766.32072.5.camel@redhat.com> (raw)
In-Reply-To: <CAFEAcA-Am0f7-6B=6GevEf6o9+OyAs-BDk1wxJER4Y43oZaVQA@mail.gmail.com>
On Mon, 2017-09-25 at 20:29 +0100, Peter Maydell wrote:
> Gerd, ping? If you provide a reviewed-by or acked-by
> I can apply this to master as a buildfix...
>
> thanks
> -- PMM
>
> On 22 September 2017 at 08:42, Jan Kiszka <jan.kiszka@siemens.com>
> wrote:
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > This reverts the incorrect commit 2041649f0b04 (these are
> > machine-independent objects)
Commit is correct. The objects are machine-independent indeed, but not
all machines need it. s390x (host) doesn't support usb in the first
place, so usb-passthrough is rather pointless. So this drops the
compiled object files from the list for the linker ...
> > and fixes the name of the config var.
That one is needed.
cheers,
Gerd
prev parent reply other threads:[~2017-09-26 6:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 7:42 [Qemu-devel] [PATCH] usb: Fix usb-host build Jan Kiszka
2017-09-25 19:29 ` Peter Maydell
2017-09-26 6:36 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506407766.32072.5.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.