From: Dario Faggioli <dario.faggioli@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH 1/2] xen/credit2: add missing unlock
Date: Wed, 27 Sep 2017 14:10:51 +0200 [thread overview]
Message-ID: <1506514251.17428.4.camel@citrix.com> (raw)
In-Reply-To: <20170927114622.14789-2-wei.liu2@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 953 bytes --]
On Wed, 2017-09-27 at 12:46 +0100, Wei Liu wrote:
> Coverity-ID: 1418531
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
> index d33c881c3d..18f39cafe4 100644
> --- a/xen/common/sched_credit2.c
> +++ b/xen/common/sched_credit2.c
> @@ -2831,6 +2831,7 @@ csched2_dom_cntl(
> if ( op->u.credit2.cap > 100 * sdom->nr_vcpus )
> {
> rc = -EINVAL;
> + write_unlock_irqrestore(&prv->lock, flags);
>
Indeed... :-/
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-27 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 11:46 [PATCH 0/2] Coverity issues for credit2 CAP series Wei Liu
2017-09-27 11:46 ` [PATCH 1/2] xen/credit2: add missing unlock Wei Liu
2017-09-27 12:10 ` Dario Faggioli [this message]
2017-09-27 11:46 ` [PATCH 2/2] python/libxc: extend the call to get/set cap for credit2 Wei Liu
2017-09-27 12:18 ` Dario Faggioli
2017-09-27 12:38 ` Marek Marczykowski-Górecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506514251.17428.4.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.