diff for duplicates of <1506553861.4536.2.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index 30b74cc..24bcebd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -11,19 +11,19 @@ On Wed, 2017-09-27 at 15:57 -0700, Jesus Sanchez-Palencia wrote: > > > <vinicius.gomes@intel.com> wrote: > > > > +static int cbs_init(struct Qdisc *sch, struct nlattr *opt) > > > > +{ -> > > > +???????struct cbs_sched_data *q = qdisc_priv(sch); -> > > > +???????struct net_device *dev = qdisc_dev(sch); +> > > > + struct cbs_sched_data *q = qdisc_priv(sch); +> > > > + struct net_device *dev = qdisc_dev(sch); > > > > + -> > > > +???????if (!opt) -> > > > +???????????????return -EINVAL; +> > > > + if (!opt) +> > > > + return -EINVAL; > > > > + -> > > > +???????/* FIXME: this means that we can only install this qdisc -> > > > +????????* "under" mqprio. Do we need a more generic way to retrieve -> > > > +????????* the queue, or do we pass the netdev_queue to the driver? -> > > > +????????*/ -> > > > +???????q->queue = TC_H_MIN(sch->parent) - 1 - netdev_get_num_tc(dev); +> > > > + /* FIXME: this means that we can only install this qdisc +> > > > + * "under" mqprio. Do we need a more generic way to retrieve +> > > > + * the queue, or do we pass the netdev_queue to the driver? +> > > > + */ +> > > > + q->queue = TC_H_MIN(sch->parent) - 1 - netdev_get_num_tc(dev); > > > > + -> > > > +???????return cbs_change(sch, opt); +> > > > + return cbs_change(sch, opt); > > > > +} > > > > > > Yeah it is ugly to assume its parent is mqprio, at least you should @@ -46,17 +46,10 @@ layer (qdisc) looks right to me. > What if we keep passing the index, but calculate it from the netdev_queue > pointer instead? > -> i.e.:??q->queue = sch->dev_queue - netdev_get_tx_queue(dev, 0); +> i.e.: q->queue = sch->dev_queue - netdev_get_tx_queue(dev, 0); > > At least it wouldn't rely on the root qdisc being of any specific type. +1 - Andre --------------- next part -------------- -A non-text attachment was scrubbed... -Name: smime.p7s -Type: application/x-pkcs7-signature -Size: 3262 bytes -Desc: not available -URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20170927/a1a550c0/attachment-0001.bin> diff --git a/N1/2.bin b/N1/2.bin new file mode 100644 index 0000000..a14cc94 Binary files /dev/null and b/N1/2.bin differ diff --git a/N1/2.hdr b/N1/2.hdr new file mode 100644 index 0000000..307aaef --- /dev/null +++ b/N1/2.hdr @@ -0,0 +1,3 @@ +Content-Type: application/x-pkcs7-signature; name="smime.p7s" +Content-Disposition: attachment; filename="smime.p7s" +Content-Transfer-Encoding: base64 diff --git a/a/content_digest b/N1/content_digest index f0fcf2e..ceb98a1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,10 +4,24 @@ "ref\087lgkzg7xv.fsf@intel.com\0" "ref\04b0e1610-c9df-191d-496e-4be04c785d2f@intel.com\0" "From\0Guedes, Andre <andre.guedes@intel.com>\0" - "Subject\0[Intel-wired-lan] [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc\0" + "Subject\0Re: [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc\0" "Date\0Wed, 27 Sep 2017 23:11:01 +0000\0" - "To\0intel-wired-lan@osuosl.org\0" - "\00:1\0" + "To\0Sanchez-Palencia" + Jesus <jesus.sanchez-palencia@intel.com> + Gomes + Vinicius <vinicius.gomes@intel.com> + " xiyou.wangcong@gmail.com <xiyou.wangcong@gmail.com>\0" + "Cc\0jiri@resnulli.us <jiri@resnulli.us>" + jhs@mojatatu.com <jhs@mojatatu.com> + Ong + Boon Leong <boon.leong.ong@intel.com> + richardcochran@gmail.com <richardcochran@gmail.com> + netdev@vger.kernel.org <netdev@vger.kernel.org> + henrik@austad.us <henrik@austad.us> + Briano + Ivan <ivan.briano@intel.com> + " intel-wired-lan@lists.osuosl.org <intel-wired-lan@lists.osuosl.org>\0" + "\01:1\0" "b\0" "On Wed, 2017-09-27 at 15:57 -0700, Jesus Sanchez-Palencia wrote:\n" "> Hi,\n" @@ -22,19 +36,19 @@ "> > > <vinicius.gomes@intel.com> wrote:\n" "> > > > +static int cbs_init(struct Qdisc *sch, struct nlattr *opt)\n" "> > > > +{\n" - "> > > > +???????struct cbs_sched_data *q = qdisc_priv(sch);\n" - "> > > > +???????struct net_device *dev = qdisc_dev(sch);\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct cbs_sched_data *q = qdisc_priv(sch);\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct net_device *dev = qdisc_dev(sch);\n" "> > > > +\n" - "> > > > +???????if (!opt)\n" - "> > > > +???????????????return -EINVAL;\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (!opt)\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return -EINVAL;\n" "> > > > +\n" - "> > > > +???????/* FIXME: this means that we can only install this qdisc\n" - "> > > > +????????* \"under\" mqprio. Do we need a more generic way to retrieve\n" - "> > > > +????????* the queue, or do we pass the netdev_queue to the driver?\n" - "> > > > +????????*/\n" - "> > > > +???????q->queue = TC_H_MIN(sch->parent) - 1 - netdev_get_num_tc(dev);\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240/* FIXME: this means that we can only install this qdisc\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240* \"under\" mqprio. Do we need a more generic way to retrieve\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240* the queue, or do we pass the netdev_queue to the driver?\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240*/\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240q->queue = TC_H_MIN(sch->parent) - 1 - netdev_get_num_tc(dev);\n" "> > > > +\n" - "> > > > +???????return cbs_change(sch, opt);\n" + "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240return cbs_change(sch, opt);\n" "> > > > +}\n" "> > > \n" "> > > Yeah it is ugly to assume its parent is mqprio, at least you should\n" @@ -57,19 +71,39 @@ "> What if we keep passing the index, but calculate it from the netdev_queue\n" "> pointer instead?\n" "> \n" - "> i.e.:??q->queue = sch->dev_queue - netdev_get_tx_queue(dev, 0);\n" + "> i.e.:\302\240\302\240q->queue = sch->dev_queue - netdev_get_tx_queue(dev, 0);\n" "> \n" "> At least it wouldn't rely on the root qdisc being of any specific type.\n" "\n" "+1\n" "\n" - "- Andre\n" - "-------------- next part --------------\n" - "A non-text attachment was scrubbed...\n" - "Name: smime.p7s\n" - "Type: application/x-pkcs7-signature\n" - "Size: 3262 bytes\n" - "Desc: not available\n" - URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20170927/a1a550c0/attachment-0001.bin> + - Andre + "\01:2\0" + "fn\0smime.p7s\0" + "b\0" + "0\200\006\t*\206H\206\367\r\001\a\002\240\2000\200\002\001\0011\v0\t\006\005+\016\003\002\032\005\00\200\006\t*\206H\206\367\r\001\a\001\0\0\240\202\n" + "i0\202\004\3530\202\003\323\240\003\002\001\002\002\020R\351\002\312\021\350D\235\224e8/\243\0320\2730\r\006\t*\206H\206\367\r\001\001\005\005\00o1\v0\t\006\003U\004\006\023\002SE1\0240\022\006\003U\004\n" + "\023\vAddTrust AB1&0$\006\003U\004\v\023\035AddTrust External TTP Network1\"0 \006\003U\004\003\023\031AddTrust External CA Root0\036\027\r130319000000Z\027\r200530104838Z0y1\v0\t\006\003U\004\006\023\002US1\v0\t\006\003U\004\b\023\002CA1\0240\022\006\003U\004\a\023\vSanta Clara1\0320\030\006\003U\004\n" + "\023\021Intel Corporation1+0)\006\003U\004\003\023\"Intel External Basic Issuing CA 4A0\202\001\"0\r\006\t*\206H\206\367\r\001\001\001\005\0\003\202\001\017\00\202\001\n" + "\002\202\001\001\0\340\260\314\200\235\330IU\372\003\333\004\3728\307\335\277\205\335v\274\353=\313,\253\277\351k\343!\333\324o\031\350\317j\247\276_T)\0027\260MsQ\0241\255\370/\264\375\033>\vu\270<\0|\267:\037\227\252\237(\276\354Z\317\2611\202G\2100\016j\265ZD\320\200\320\315]H\033\357W\275\377\253\037\253\345\237\b:b\361'\032\202\\\213\t\032{\246\037\325\353G\033\212\320o\235\221^\224\240\203\006\035\367\331.\212\033v\300vsF\a\373\344\363\246\360\016V:\242`\354\353\364l|\3343A\\(\374\315\350>\273\261\353.\263\310\212\021\272W\344TC[3O\375F\274\320:\\\212\341nU\223\201\004\261\365\266\216P\225\341o7@\252\221q\300\n" + "!Lp\332\257\307\240uOm\261\023\256\262\346\023\244Qg\377\236ZY\006Z_\246\267\0366\034\350\016\231}\001E\324\321\243\333\307\357'\201\243\002\003\001\0\001\243\202\001w0\202\001s0\037\006\003U\035#\004\0300\026\200\024\255\275\230z4\264&\367\372\304&T\357\003\275\340$\313T\0320\035\006\003U\035\016\004\026\004\024\036i*\264\334(\376G\030N!\v?\274\254\021/\360\230\3650\016\006\003U\035\017\001\001\377\004\004\003\002\001\2060\022\006\003U\035\023\001\001\377\004\b0\006\001\001\377\002\001\006\006\003U\035%\004/0-\006\b+\006\001\005\005\a\003\004\006\n" + "+\006\001\004\001\2027\n" + "\003\004\006\n" + "+\006\001\004\001\2027\n" + "\003\f\006\t+\006\001\004\001\2027\025\0050\027\006\003U\035 \004\0200\0160\f\006\n" + "*\206H\206\370M\001\005\001i0I\006\003U\035\037\004B0@0>\240<\240:\2068http://crl.trust-provider.com/AddTrustExternalCARoot.crl0:\006\b+\006\001\005\005\a\001\001\004.0,0*\006\b+\006\001\005\005\a0\001\206\036http://ocsp.trust-provider.com05\006\003U\035\036\004.0,\240*0\v\201\tintel.com0\033\240\031\006\n" + "+\006\001\004\001\2027\024\002\003\240\v\f\tintel.com0\r\006\t*\206H\206\367\r\001\001\005\005\0\003\202\001\001\0)\302\315\243\375\222\243Rg\242/\006\355nP\350T\217\253W\346\310\245\267\261 \337\325\251\257\310y#\022\av\346~\314)\021\306\022dq\306\214\342<\252\\\231\267\327aO\211\322\016z\322p\250\346\003\305\357\305\235\355\231\263r`\234\233U\005\025\3621\177\016\220\003_[F\224\302\361\263\fi$\204\227\314\267\364\3700k\341\3046j\017f\303:\3347Y\3538\203\234\372\234I\267\037b\317*w\371\271wm\253\245z\271 eT\265~\213_\264\177\205$\260\377{\037\0019\301.\b\211\266)U\311\216\316\030i\230( \022\330\2158\212\333\322KU\255y\305\323\267\323\231\017#[\227\262\3559\260k\200\302\341fJI[\352NG\327\367\207\225F\331.n*@;N\037M\v\321(I\307p@ \b\303\345\026)\264\220\320\213#\331AK\355\361\312\276j\226)T\313\367\313\021\316\3627\261\343B\3400\202\005v0\202\004^\240\003\002\001\002\002\0233\0\0\213ucw\236\364\177-\307\302\0\0\0\0\213u0\r\006\t*\206H\206\367\r\001\001\005\005\00y1\v0\t\006\003U\004\006\023\002US1\v0\t\006\003U\004\b\023\002CA1\0240\022\006\003U\004\a\023\vSanta Clara1\0320\030\006\003U\004\n" + "\023\021Intel Corporation1+0)\006\003U\004\003\023\"Intel External Basic Issuing CA 4A0\036\027\r170103234034Z\027\r171229234034Z0?1\0260\024\006\003U\004\003\023\rGuedes, Andre1%0#\006\t*\206H\206\367\r\001\t\001\026\026andre.guedes@intel.com0\202\001\"0\r\006\t*\206H\206\367\r\001\001\001\005\0\003\202\001\017\00\202\001\n" + "\002\202\001\001\0\334\260\206\374{\0\\\361\270\204g*]\311\236\232\364\257\271\337!\260\257\371\244\003\032\345\356[\304%\032\364\002\237\307\202^\326\342\n" + "\275P\342\337l\f\b\037\321\b\365L.^\223\235\361\320\242\207_\261>\3669,v\355\210O>\025\022^\023\207\254\200\327=l\327\rM\002\252\301\371Z\"'\222\037&-7\334MO\360Rl3\240\372\250j\331\345\275\225\3610J\244A\246\027d`aOr\335\324\226\017\241\223\230\246\207N\332\343\261\002\306\001\r\315>~\243\342h\335\215\337\373\300\261Gz\257\205\310Y ,T\277\"&\366^\020\220c\371\r\037\256(\270\336|\375\270\235'\202U\026\304\020!\315q\024\240\261/\377\bfC\302|\376\262\207\256\311tR,\36082\364z5\205\274\213\002Q\346\022?hh\214\243\326\243\344]\337\032\225\212i\f\027\200mn\203\030\325\a\006\200z\324\317\355\375OL\244\213\002\003\001\0\001\243\202\002/0\202\002+0\035\006\003U\035\016\004\026\004\024l}6\3457\3271\2227\350\303\376\302/\263\232\030\355/\2670\037\006\003U\035#\004\0300\026\200\024\036i*\264\334(\376G\030N!\v?\274\254\021/\360\230\3650e\006\003U\035\037\004^0\\0Z\240X\240V\206Thttp://www.intel.com/repository/CRL/Intel%20External%20Basic%20Issuing%20CA%204A.crl0\201\237\006\b+\006\001\005\005\a\001\001\004\201\2220\201\2170i\006\b+\006\001\005\005\a0\002\206]http://www.intel.com/repository/certificates/Intel%20External%20Basic%20Issuing%20CA%204A.crt0\"\006\b+\006\001\005\005\a0\001\206\026http://ocsp.intel.com/0\v\006\003U\035\017\004\004\003\002\a\2000<\006\t+\006\001\004\001\2027\025\a\004/0-\006%+\006\001\004\001\2027\025\b\206\303\214u\204\231\345Q\203\375\201(\205\216\237S\202\221\300\tg\201\336\2759\225\360C\002\001d\002\001\t0\037\006\003U\035%\004\0300\026\006\b+\006\001\005\005\a\003\004\006\n" + "+\006\001\004\001\2027\n" + "\003\f0)\006\t+\006\001\004\001\2027\025\n" + "\004\0340\0320\n" + "\006\b+\006\001\005\005\a\003\0040\f\006\n" + "+\006\001\004\001\2027\n" + "\003\f0I\006\003U\035\021\004B0@\240&\006\n" + "+\006\001\004\001\2027\024\002\003\240\030\f\026andre.guedes@intel.com\201\026andre.guedes@intel.com0\r\006\t*\206H\206\367\r\001\001\005\005\0\003\202\001\001\0O\204]\250?7\223\344[[\227\261\254\226\307z\37036\005s9\312\334\335T\033\376\252G\345\024\a\363\303\342\326\340S\223>\"\203\375\200\352~\2074\316\304\315O[\030r\017n.\244L\356\212y\t\334\031'\020\325\036\025\221\032Zv\020\213}:H\314\311?p\263\022%\250\201\r\277\370\222Wa\275\257\275\b\336(F\252\230Wj\262\021\311\356\341qv9\202`yq\231\233^\332\200B\3506\332)\341\334\037!q{Lq\271\244\3609\0017:\202MU\314i7lJ\366\266\347\241\355\232\376\207\240,\271\375\324\373\361H\330#\037D\002\3757\230\346G\371>'\370D\002\242\365\233\b\350\354\017\204JE\205\226\323$\204\202\302h\035\031\302\277\231Q\262V\320Z]\310\216n\205I\023\n" + "\302.\306\276x\b[\032~\005\340\314\023\272j:\243,\331kd\244zu\322\344\316\334\206g\v\320[\311\350^1\202\002\0270\202\002\023\002\001\0010\201\2200y1\v0\t\006\003U\004\006\023\002US1\v0\t\006\003U\004\b\023\002CA1\0240\022\006\003U\004\a\023\vSanta Clara1\0320\030\006\003U\004\n" + "\023\021Intel Corporation1+0)\006\003U\004\003\023\"Intel External Basic Issuing CA 4A\002\0233\0\0\213ucw\236\364\177-\307\302\0\0\0\0\213u0\t\006\005+\016\003\002\032\005\0\240]0\030\006\t*\206H\206\367\r\001\t\0031\v\006\t*\206H\206\367\r\001\a\0010\034\006\t*\206H\206\367\r\001\t\0051\017\027\r170927231101Z0#\006\t*\206H\206\367\r\001\t\0041\026\004\024\354\277\035\267\031\033\350qJ2\\E\334\2730\027AF\21140\r\006\t*\206H\206\367\r\001\001\001\005\0\004\202\001\0\245\327\r0\360E\3779Q;z(\307\317\3518\b\3340\257\352\221\322\230i>\364*]\0\303\206\320!\033N[\fO\245*uD\035\322\262*o\246\210\331\374\354T\220\311\271\206\317^\322\240\361\325L\3617\246V\327Z\267\227\300=\\\023\244e+\345>\025\250\376\377\211\331\375}q\023s\320\262\302\222,X\364\317%\a\250F\206\t:\262\262l\323\265\322\2433\236j\202\3502\232o\200\322\303\a>/\324\224\362u\370vKZ\266\275?B#s9\217\232\357\256\004\021\317\204\275x,\220\0\263\263\214\250\340\\\255\363Z~\200#\365\301\245\364\006{\340\3501\222\230S\223\215K\360\260\221H\003\366Y\344\245fg\003C\020\272M\237y\222\360:\023\313\025E\325\321c\273\204\v\335\201\202\\7\030\345\332\216*\261\246B\2323!\307\220\352\366\f\246\r$\356R\251\341\211\376\b\337\022\246\304\022\305k\242@\316\0\0\0\0\0\0" -3f78f9451f6c72b786af24f2d1aa81c71a215ed8109ac7cefdb1b141266b7947 +2124c1e8b42e571a6641aa8794cecfc53feb9af08914565ff785c2bff2c2e389
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.