Re: [PATCH v2 2/3] xen: RCU: make the period of the idle timer configurable.

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2064 bytes --]

On Thu, 2017-09-28 at 07:06 -0600, Jan Beulich wrote:
> > > > On 28.09.17 at 12:16, <dario.faggioli@citrix.com> wrote:
> > 
> And then, as a cosmetic thing, idle_timer_period_ms now isn't
> really needed outside of this function. I'd prefer if you moved it
> and the integer_param() into this function, to limit their scopes
> as much as possible.
> 
On an unrelated (to this series) note, does this means that patches
like the one below are welcome/accepted?

Not that I plan to start sending them (not right now, at least). I was
rather thinking that it could be a nice bite project for beginners and
GSoC/Outreacy applicants.

Dario
---
diff --git a/xen/arch/x86/acpi/boot.c b/xen/arch/x86/acpi/boot.c
index 8e6c96d..a6cb263 100644
--- a/xen/arch/x86/acpi/boot.c
+++ b/xen/arch/x86/acpi/boot.c
@@ -50,10 +50,6 @@ bool __initdata acpi_ht = true; /* enable HT */
 bool __initdata acpi_lapic;
 bool __initdata acpi_ioapic;
 
-/* acpi_skip_timer_override: Skip IRQ0 overrides. */
-static bool __initdata acpi_skip_timer_override;
-boolean_param("acpi_skip_timer_override", acpi_skip_timer_override);
-
 static u64 acpi_lapic_addr __initdata = APIC_DEFAULT_PHYS_BASE;
 
 /* --------------------------------------------------------------------------
@@ -225,6 +221,9 @@ static int __init
 acpi_parse_int_src_ovr(struct acpi_subtable_header * header,
                       const unsigned long end)
 {
+       /* acpi_skip_timer_override: Skip IRQ0 overrides. */
+       static bool __initdata acpi_skip_timer_override;
+       boolean_param("acpi_skip_timer_override", acpi_skip_timer_override);
        struct acpi_madt_interrupt_override *intsrc =
                container_of(header, struct acpi_madt_interrupt_override,
                             header);
---
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel