diff for duplicates of <1506643967.5691.46.camel@linux.vnet.ibm.com> diff --git a/a/1.txt b/N1/1.txt index 55f231d..6989bd6 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -21,11 +21,16 @@ On Thu, 2017-09-28 at 16:39 -0700, Linus Torvalds wrote: > with the xattr writing, but since IMA does those both, why isn't IMA > just using its own lock (not the filesystem lock) to do that? -Originally IMA did define it's own lock, prior to IMA-appraisal. IMA- +Originally IMA did define it's own lock, prior to IMA-appraisal. ?IMA- appraisal introduced writing the file hash as an xattr, which required -taking the i_mutex. process_measurement() and ima_file_free() took +taking the i_mutex. ?process_measurement() and ima_file_free() took the iint->mutex first and then the i_mutex, while setxattr, chmod and -chown took the locks in reverse order. To resolve the potential +chown took the locks in reverse order. ?To resolve the potential deadlock, the iint->mutex was eliminated. Mimi + +-- +To unsubscribe from this list: send the line "unsubscribe linux-security-module" in +the body of a message to majordomo at vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 3d37d07..c2543b3 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,18 +2,10 @@ "ref\01506602373-4799-4-git-send-email-zohar@linux.vnet.ibm.com\0" "ref\020170928220215.GC15067@dastard\0" "ref\0CA+55aFy-kDL5jQb0q2gHkcmhAwMatEf8YPx8Gh=yGp_VMoVxQA@mail.gmail.com\0" - "From\0Mimi Zohar <zohar@linux.vnet.ibm.com>\0" - "Subject\0Re: [RFC PATCH 3/3] fs: detect that the i_rwsem has already been taken exclusively\0" + "From\0zohar@linux.vnet.ibm.com (Mimi Zohar)\0" + "Subject\0[RFC PATCH 3/3] fs: detect that the i_rwsem has already been taken exclusively\0" "Date\0Thu, 28 Sep 2017 20:12:47 -0400\0" - "To\0Linus Torvalds <torvalds@linux-foundation.org>" - " Dave Chinner <david@fromorbit.com>\0" - "Cc\0LSM List <linux-security-module@vger.kernel.org>" - linux-fsdevel <linux-fsdevel@vger.kernel.org> - linux-integrity@vger.kernel.org - Christoph Hellwig <hch@infradead.org> - Linux Kernel Mailing List <linux-kernel@vger.kernel.org> - Jan Kara <jack@suse.cz> - " Theodore Ts'o <tytso@mit.edu>\0" + "To\0linux-security-module@vger.kernel.org\0" "\00:1\0" "b\0" "On Thu, 2017-09-28 at 16:39 -0700, Linus Torvalds wrote:\n" @@ -39,13 +31,18 @@ "> with the xattr writing, but since IMA does those both, why isn't IMA\n" "> just using its own lock (not the filesystem lock) to do that?\n" "\n" - "Originally IMA did define it's own lock, prior to IMA-appraisal. IMA-\n" + "Originally IMA did define it's own lock, prior to IMA-appraisal. ?IMA-\n" "appraisal introduced writing the file hash as an xattr, which required\n" - "taking the i_mutex. process_measurement() and ima_file_free() took\n" + "taking the i_mutex. ?process_measurement() and ima_file_free() took\n" "the iint->mutex first and then the i_mutex, while setxattr, chmod and\n" - "chown took the locks in reverse order. To resolve the potential\n" + "chown took the locks in reverse order. ?To resolve the potential\n" "deadlock, the iint->mutex was eliminated.\n" "\n" - Mimi + "Mimi\n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-security-module\" in\n" + "the body of a message to majordomo at vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -771f1aaed4c14808c7c569dd77bc2b7b6b1bbafde048bf6ccb1148285e25d33f +1ad4cc5555cd219f7ed2870a7446ea4926b1a8a9667c79fb3143bacce6d7b314
diff --git a/a/1.txt b/N2/1.txt index 55f231d..4e699e2 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -21,11 +21,11 @@ On Thu, 2017-09-28 at 16:39 -0700, Linus Torvalds wrote: > with the xattr writing, but since IMA does those both, why isn't IMA > just using its own lock (not the filesystem lock) to do that? -Originally IMA did define it's own lock, prior to IMA-appraisal. IMA- +Originally IMA did define it's own lock, prior to IMA-appraisal. IMA- appraisal introduced writing the file hash as an xattr, which required -taking the i_mutex. process_measurement() and ima_file_free() took +taking the i_mutex. process_measurement() and ima_file_free() took the iint->mutex first and then the i_mutex, while setxattr, chmod and -chown took the locks in reverse order. To resolve the potential +chown took the locks in reverse order. To resolve the potential deadlock, the iint->mutex was eliminated. Mimi diff --git a/a/content_digest b/N2/content_digest index 3d37d07..fd1148b 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -39,13 +39,13 @@ "> with the xattr writing, but since IMA does those both, why isn't IMA\n" "> just using its own lock (not the filesystem lock) to do that?\n" "\n" - "Originally IMA did define it's own lock, prior to IMA-appraisal. IMA-\n" + "Originally IMA did define it's own lock, prior to IMA-appraisal. \302\240IMA-\n" "appraisal introduced writing the file hash as an xattr, which required\n" - "taking the i_mutex. process_measurement() and ima_file_free() took\n" + "taking the i_mutex. \302\240process_measurement() and ima_file_free() took\n" "the iint->mutex first and then the i_mutex, while setxattr, chmod and\n" - "chown took the locks in reverse order. To resolve the potential\n" + "chown took the locks in reverse order. \302\240To resolve the potential\n" "deadlock, the iint->mutex was eliminated.\n" "\n" Mimi -771f1aaed4c14808c7c569dd77bc2b7b6b1bbafde048bf6ccb1148285e25d33f +a8aa1cbb252b7111be280ca1892342382036b21ba6918f6f2137cb9cc25d44cc
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.