Re: [PATCH igt] igt/gem_exec_schedule: Detect too slow setup in deep-*

From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH igt] igt/gem_exec_schedule: Detect too slow setup in deep-*
Date: Fri, 29 Sep 2017 11:48:42 +0300	[thread overview]
Message-ID: <1506674922.4729.25.camel@linux.intel.com> (raw)
In-Reply-To: <20170928112023.17536-1-chris@chris-wilson.co.uk>

On Thu, 2017-09-28 at 12:20 +0100, Chris Wilson wrote:
> Using vgem as our cork for building the request queue limits us to 10s
> of setup (or else the fence autoexpires and we start executing too
> early). Add timeouts to the setup loops and SKIP if we cannot establish
> the workload within 10s, the machine and driver is too slow to evaluate
> the expected results.
> 
> To avoid the artificial limit of 10s requires lifting the dependency on
> vgem and switching to sw_sync and explicit fencing. Just a matter of
> plumbing!
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

<SNIP>

> @@ -483,21 +485,48 @@ static void deep(int fd, unsigned ring)
>  	for (int m = 0; m < XS; m ++)
>  		dep[m] = gem_create(fd, size);
>  
> +	/* Bind the surfaces into each of the contexts */

"before starting timeout measurement."

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx