Re: [RFC PATCH v2 1/5] drm/i915: expose helper mapping exec flag engine to intel_engine_cs

[Joonas Lahtinen <joonas.lahtinen@linux.intel.com>]

On Fri, 2017-09-22 at 16:10 +0100, Lionel Landwerlin wrote:
> This function will be used later by the per (context,engine) power
> programming interface.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.h            |  3 +++
>  drivers/gpu/drm/i915/i915_gem_execbuffer.c | 18 +++++++++---------
>  2 files changed, 12 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index f5d0e816008d..60c63f141a47 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -3380,6 +3380,9 @@ int i915_gem_set_domain_ioctl(struct drm_device *dev, void *data,
>  			      struct drm_file *file_priv);
>  int i915_gem_sw_finish_ioctl(struct drm_device *dev, void *data,
>  			     struct drm_file *file_priv);
> +struct intel_engine_cs *i915_gem_engine_from_flags(struct drm_i915_private *dev_priv,

May wanna cut before function name here, too, to keep the readability.

Also, why would i915_select_engine be a bad name?

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx