From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Date: Fri, 29 Sep 2017 15:27:15 +0000 Subject: Re: [PATCH][rdma-next] RDMA/hns: make various function static, fixes warnings Message-Id: <1506698835.2919.20.camel@redhat.com> List-Id: References: <20170929131601.7111-1-colin.king@canonical.com> In-Reply-To: <20170929131601.7111-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King , Lijun Ou , Wei Hu , Sean Hefty , Hal Rosenstock , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Fri, 2017-09-29 at 14:16 +0100, Colin King wrote: > From: Colin Ian King > > The functions hns_roce_table_mhop_get, hns_roce_table_mhop_put, > hns_roce_cleanup_mhop_hem_table, hns_roce_v1_post_mbox, > hns_roce_cmq_setup_basic_desc, hns_roce_cmq_send, > hns_roce_cmq_query_hw_info are all local to the source and do > not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'hns_roce_table_mhop_get' was not declared. Should it be > static? > symbol 'hns_roce_table_mhop_put' was not declared. Should it be > static? > symbol 'hns_roce_cleanup_mhop_hem_table' was not declared. Should it > be > static? > symbol 'hns_roce_v1_post_mbox' was not declared. Should it be static? > symbol 'hns_roce_cmq_setup_basic_desc' was not declared. Should it be > static? > symbol 'hns_roce_cmq_send' was not declared. Should it be static? > symbol 'hns_roce_cmq_query_hw_info' was not declared. Should it be > static? > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: [PATCH][rdma-next] RDMA/hns: make various function static, fixes warnings Date: Fri, 29 Sep 2017 11:27:15 -0400 Message-ID: <1506698835.2919.20.camel@redhat.com> References: <20170929131601.7111-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170929131601.7111-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Colin King , Lijun Ou , Wei Hu , Sean Hefty , Hal Rosenstock , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Fri, 2017-09-29 at 14:16 +0100, Colin King wrote: > From: Colin Ian King > > The functions hns_roce_table_mhop_get, hns_roce_table_mhop_put, > hns_roce_cleanup_mhop_hem_table, hns_roce_v1_post_mbox, > hns_roce_cmq_setup_basic_desc, hns_roce_cmq_send, > hns_roce_cmq_query_hw_info are all local to the source and do > not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'hns_roce_table_mhop_get' was not declared. Should it be > static? > symbol 'hns_roce_table_mhop_put' was not declared. Should it be > static? > symbol 'hns_roce_cleanup_mhop_hem_table' was not declared. Should it > be > static? > symbol 'hns_roce_v1_post_mbox' was not declared. Should it be static? > symbol 'hns_roce_cmq_setup_basic_desc' was not declared. Should it be > static? > symbol 'hns_roce_cmq_send' was not declared. Should it be static? > symbol 'hns_roce_cmq_query_hw_info' was not declared. Should it be > static? > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752523AbdI2P1S (ORCPT ); Fri, 29 Sep 2017 11:27:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41172 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752326AbdI2P1R (ORCPT ); Fri, 29 Sep 2017 11:27:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 30022A4F91 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dledford@redhat.com Message-ID: <1506698835.2919.20.camel@redhat.com> Subject: Re: [PATCH][rdma-next] RDMA/hns: make various function static, fixes warnings From: Doug Ledford To: Colin King , Lijun Ou , Wei Hu , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 29 Sep 2017 11:27:15 -0400 In-Reply-To: <20170929131601.7111-1-colin.king@canonical.com> References: <20170929131601.7111-1-colin.king@canonical.com> Organization: Red Hat, Inc. Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 29 Sep 2017 15:27:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-09-29 at 14:16 +0100, Colin King wrote: > From: Colin Ian King > > The functions hns_roce_table_mhop_get, hns_roce_table_mhop_put, > hns_roce_cleanup_mhop_hem_table, hns_roce_v1_post_mbox, > hns_roce_cmq_setup_basic_desc, hns_roce_cmq_send, > hns_roce_cmq_query_hw_info are all local to the source and do > not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'hns_roce_table_mhop_get' was not declared. Should it be > static? > symbol 'hns_roce_table_mhop_put' was not declared. Should it be > static? > symbol 'hns_roce_cleanup_mhop_hem_table' was not declared. Should it > be > static? > symbol 'hns_roce_v1_post_mbox' was not declared. Should it be static? > symbol 'hns_roce_cmq_setup_basic_desc' was not declared. Should it be > static? > symbol 'hns_roce_cmq_send' was not declared. Should it be static? > symbol 'hns_roce_cmq_query_hw_info' was not declared. Should it be > static? > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD