From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: torvalds@osdl.org, akpm@osdl.org, davidm@snapgear.com,
linux-kernel@vger.kernel.org, uclinux-dev@uclinux.org
Subject: Re: [PATCH] VM routine fixes
Date: Tue, 09 Nov 2004 13:53:06 +0000 [thread overview]
Message-ID: <15068.1100008386@redhat.com> (raw)
In-Reply-To: <20041109125539.GA4867@infradead.org>
> Please don't stick CONFIG_MMU all over the place but keep them in as small
> as possible blocks.
You seem to have changed your mind. Last I heard from you wanted them in as
few large blocks as possible. Now you want them in many small blocks. If you
want it changing, please feel free to supply me with a patch.
> As I told you before please move registration of MMU-only sysctls
> to a MMU-only file in mm/
No. These belong in the vm_table. It doesn't seem especially straightforward
to do what you want. If you want it doing your way, then feel free to send
Andrew a patch.
> > +extern void set_page_refs(struct page *page, int order);
>
> this should probably be an inline.
Probably. I'll deal with that after Andrew/Linus take my patches, if they take
my patches.
> this is nasty. The right thing would probably to swich !MMU arches
> to use the compount-page mechanism from the hugetlb code for this.
Supply me with a patch and I'll test it. I don't know how the compound-page
stuff works, but it's quite possibly the wrong way to do it. There is no MMU
available, so you can't generate adjacency that way.
> And you ocmpletely ignored the previous comment here aswell.
No, I didn't; you're wrong.
Feel free to supply a patch to change it to what you think is correct. I'll
test it for you.
David
next prev parent reply other threads:[~2004-11-09 13:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-08 14:32 [PATCH] VM routine fixes dhowells
2004-11-09 12:55 ` Christoph Hellwig
2004-11-09 13:53 ` David Howells [this message]
2004-11-09 14:01 ` Christoph Hellwig
2004-11-10 13:37 ` David Howells
2004-11-10 19:01 ` Andrew Morton
2004-11-11 1:17 ` David Woodhouse
2004-11-11 2:26 ` Andrew Morton
2004-11-11 11:29 ` David Howells
2004-11-11 11:43 ` Andrew Morton
2004-11-11 12:03 ` David Howells
2004-11-11 22:31 ` Andrew Morton
2004-11-12 10:33 ` David Howells
2004-11-12 10:38 ` Andrew Morton
2004-11-12 11:05 ` David Howells
2004-11-14 5:07 ` Linus Torvalds
2004-11-15 13:14 ` David Howells
2004-11-15 15:35 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15068.1100008386@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=davidm@snapgear.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.