From: Benjamin Herrenschmidt <benh@au1.ibm.com>
To: Stewart Smith <stewart@linux.vnet.ibm.com>,
Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>,
mpe@ellerman.id.au
Cc: ego@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
akshay.adiga@linux.vnet.ibm.com
Subject: Re: [PATCH] powernv: Add OCC driver to mmap sensor area
Date: Mon, 02 Oct 2017 10:35:02 +0200 [thread overview]
Message-ID: <1506933302.25065.3.camel@au1.ibm.com> (raw)
In-Reply-To: <87bmlqutq5.fsf@linux.vnet.ibm.com>
On Mon, 2017-10-02 at 14:14 +1100, Stewart Smith wrote:
> Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> writes:
> > This driver provides interface to mmap the OCC sensor area
> > to userspace to parse and read OCC inband sensors.
>
> Why?
>
> Is this for debug? If so, the existing exports interface should be used.
>
> If there's actual sensors, we already have two ways of exposing sensors
> to Linux: the OPAL_SENSOR API and the IMC API.
>
> Why this method and not use the existing ones?
More than that, a sensor should be exposed to userspace via hwmon, not
some random direct userspace map.
Ben.
prev parent reply other threads:[~2017-10-02 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 6:47 [PATCH] powernv: Add OCC driver to mmap sensor area Shilpasri G Bhat
2017-09-29 7:46 ` Oliver
2017-10-02 3:14 ` Stewart Smith
2017-10-02 8:35 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1506933302.25065.3.camel@au1.ibm.com \
--to=benh@au1.ibm.com \
--cc=akshay.adiga@linux.vnet.ibm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=shilpa.bhat@linux.vnet.ibm.com \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.