All of lore.kernel.org
 help / color / mirror / Atom feed
From: <gregkh@linuxfoundation.org>
To: smfrench@gmail.com, gregkh@linuxfoundation.org, lsahlber@redhat.com
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "SMB3: Fix endian warning" has been added to the 4.13-stable tree
Date: Mon, 02 Oct 2017 13:42:47 +0200	[thread overview]
Message-ID: <150694456787192@kroah.com> (raw)


This is a note to let you know that I've just added the patch titled

    SMB3: Fix endian warning

to the 4.13-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     smb3-fix-endian-warning.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 590d08d3da45e9fed423b08ab38d71886c07abc8 Mon Sep 17 00:00:00 2001
From: Steve French <smfrench@gmail.com>
Date: Tue, 19 Sep 2017 11:43:47 -0500
Subject: SMB3: Fix endian warning

From: Steve French <smfrench@gmail.com>

commit 590d08d3da45e9fed423b08ab38d71886c07abc8 upstream.

Multi-dialect negotiate patch had a minor endian error.

Signed-off-by: Steve French <smfrench@gmail.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 fs/cifs/smb2pdu.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -558,10 +558,11 @@ SMB2_negotiate(const unsigned int xid, s
 			/* ops set to 3.0 by default for default so update */
 			ses->server->ops = &smb21_operations;
 		}
-	} else if (rsp->DialectRevision != ses->server->vals->protocol_id) {
+	} else if (le16_to_cpu(rsp->DialectRevision) !=
+				ses->server->vals->protocol_id) {
 		/* if requested single dialect ensure returned dialect matched */
 		cifs_dbg(VFS, "Illegal 0x%x dialect returned: not requested\n",
-			cpu_to_le16(rsp->DialectRevision));
+			le16_to_cpu(rsp->DialectRevision));
 		return -EIO;
 	}
 


Patches currently in stable-queue which might be from smfrench@gmail.com are

queue-4.13/cifs-release-cifs-root_cred-after-exit_cifs.patch
queue-4.13/smb3-warn-user-if-trying-to-sign-connection-that-authenticated-as-guest.patch
queue-4.13/smb3-handle-new-statx-fields.patch
queue-4.13/smb3-add-support-for-multidialect-negotiate-smb2.1-and-later.patch
queue-4.13/smb3-don-t-ignore-o_sync-o_dsync-and-o_direct-flags.patch
queue-4.13/fix-smb3.1.1-guest-authentication-to-samba.patch
queue-4.13/cifs-release-auth_key.response-for-reconnect.patch
queue-4.13/smb3-fix-endian-warning.patch
queue-4.13/smb-validate-negotiate-to-protect-against-downgrade-even-if-signing-off.patch
queue-4.13/cifs-check-rsp-for-null-before-dereferencing-in-smb2_open.patch

                 reply	other threads:[~2017-10-02 11:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150694456787192@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=lsahlber@redhat.com \
    --cc=smfrench@gmail.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.