From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jikos@kernel.org" <jikos@kernel.org>
Cc: "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
"ONeukum@suse.com" <ONeukum@suse.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nborisov@suse.com" <nborisov@suse.com>,
"oleg.b.antonyan@gmail.com" <oleg.b.antonyan@gmail.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"darrick.wong@oracle.com" <darrick.wong@oracle.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"ming.lei@redhat.com" <ming.lei@redhat.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"jgross@suse.com" <jgross@suse.com>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
"todd.e.brandt@linux.intel.com" <todd.e.brandt@linux.intel.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"len.brown@intel.com" <len.brown@intel.com>,
"tytso@mit.edu" <tytso@mit.edu>, "jack@suse.cz" <jack@suse.cz>
Subject: Re: [RFC 5/5] pm: remove kernel thread freezing
Date: Tue, 3 Oct 2017 20:21:42 +0000 [thread overview]
Message-ID: <1507062101.2567.16.camel@wdc.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.1710032215140.17517@jbgna.fhfr.qr>
T24gVHVlLCAyMDE3LTEwLTAzIGF0IDIyOjE3ICswMjAwLCBKaXJpIEtvc2luYSB3cm90ZToNCj4g
T24gVHVlLCAzIE9jdCAyMDE3LCBCYXJ0IFZhbiBBc3NjaGUgd3JvdGU6DQo+ID4gV2hhdCBhYm91
dCB0aGUgbWFueSBkcml2ZXJzIG91dHNpZGUgZmlsZXN5c3RlbXMgdGhhdCB1c2UgdGhlIA0KPiA+
IHNldF9mcmVlemFibGUoKSAvIHRyeV90b19mcmVlemUoKSAvIHdhaXRfZXZlbnRfZnJlZXphYmxl
KCkgQVBJPw0KPiANCj4gTWFueS9tb3N0IG9mIHRoZW0gYXJlIGp1c3QgY29tcGxldGVseSBib2d1
cyBhbmQgcG9pbnRsZXNzLiBJJ3ZlIGtpbGxlZCBhIA0KPiBsb3Qgb2YgdGhvc2UgaW4gdGhlIHBh
c3QsIGJ1dCB0aGUgY29weS9wYXN0ZSBwcm9ncmFtbWluZyBpcyBqdXN0IHRvbyANCj4gc3Ryb25n
IGVuZW15IHRvIGZpZ2h0IGFnYWluc3QuDQoNCklmIGp1c3QgYSBzaW5nbGUgZHJpdmVyIHdvdWxk
IHVzZSB0aGF0IEFQSSB0byBwcmV2ZW50IHRoYXQgSS9PIG9jY3VycyB3aGlsZQ0KcHJvY2Vzc2Vz
IGFyZSBmcm96ZW4gdGhlbiB0aGlzIHBhdGNoIHdpbGwgYnJlYWsgdGhhdCBkcml2ZXIuIEkgd291
bGQgbGlrZSB0bw0Ka25vdyB5b3VyIG9waW5pb24gYWJvdXQgdGhlIGZvbGxvd2luZyBwYXRjaCBp
biBwYXJ0aWN1bGFyOiAiW1BBVENIIHY0IDEvN10gbWQ6DQpNYWtlIG1kIHJlc3luYyBhbmQgcmVz
aGFwZSB0aHJlYWRzIGZyZWV6YWJsZSINCihodHRwczovL3d3dy5zcGluaWNzLm5ldC9saXN0cy9s
aW51eC1ibG9jay9tc2cxNzg1NC5odG1sKS4NCg0KVGhhbmtzLA0KDQpCYXJ0Lg==
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jikos@kernel.org" <jikos@kernel.org>
Cc: "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
"ONeukum@suse.com" <ONeukum@suse.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nborisov@suse.com" <nborisov@suse.com>,
"oleg.b.antonyan@gmail.com" <oleg.b.antonyan@gmail.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"darrick.wong@oracle.com" <darrick.wong@oracle.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"ming.lei@redhat.com" <ming.lei@redhat.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"jgross@suse.com" <jgross@suse.com>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
todd.e.brandt@linux.intel.co
Subject: Re: [RFC 5/5] pm: remove kernel thread freezing
Date: Tue, 3 Oct 2017 20:21:42 +0000 [thread overview]
Message-ID: <1507062101.2567.16.camel@wdc.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.1710032215140.17517@jbgna.fhfr.qr>
On Tue, 2017-10-03 at 22:17 +0200, Jiri Kosina wrote:
> On Tue, 3 Oct 2017, Bart Van Assche wrote:
> > What about the many drivers outside filesystems that use the
> > set_freezable() / try_to_freeze() / wait_event_freezable() API?
>
> Many/most of them are just completely bogus and pointless. I've killed a
> lot of those in the past, but the copy/paste programming is just too
> strong enemy to fight against.
If just a single driver would use that API to prevent that I/O occurs while
processes are frozen then this patch will break that driver. I would like to
know your opinion about the following patch in particular: "[PATCH v4 1/7] md:
Make md resync and reshape threads freezable"
(https://www.spinics.net/lists/linux-block/msg17854.html).
Thanks,
Bart.
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jikos@kernel.org" <jikos@kernel.org>
Cc: "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
"ONeukum@suse.com" <ONeukum@suse.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"nborisov@suse.com" <nborisov@suse.com>,
"oleg.b.antonyan@gmail.com" <oleg.b.antonyan@gmail.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"darrick.wong@oracle.com" <darrick.wong@oracle.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"ming.lei@redhat.com" <ming.lei@redhat.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"jgross@suse.com" <jgross@suse.com>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
"todd.e.brandt@linux.intel.com" <todd.e.brandt@linux.intel.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"len.brown@intel.com" <len.brown@intel.com>,
"tytso@mit.edu" <tytso@mit.edu>, "jack@suse.cz" <jack@suse.cz>
Subject: Re: [RFC 5/5] pm: remove kernel thread freezing
Date: Tue, 3 Oct 2017 20:21:42 +0000 [thread overview]
Message-ID: <1507062101.2567.16.camel@wdc.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.1710032215140.17517@jbgna.fhfr.qr>
On Tue, 2017-10-03 at 22:17 +0200, Jiri Kosina wrote:
> On Tue, 3 Oct 2017, Bart Van Assche wrote:
> > What about the many drivers outside filesystems that use the
> > set_freezable() / try_to_freeze() / wait_event_freezable() API?
>
> Many/most of them are just completely bogus and pointless. I've killed a
> lot of those in the past, but the copy/paste programming is just too
> strong enemy to fight against.
If just a single driver would use that API to prevent that I/O occurs while
processes are frozen then this patch will break that driver. I would like to
know your opinion about the following patch in particular: "[PATCH v4 1/7] md:
Make md resync and reshape threads freezable"
(https://www.spinics.net/lists/linux-block/msg17854.html).
Thanks,
Bart.
next prev parent reply other threads:[~2017-10-03 20:22 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 18:53 [RFC 0/5] fs: replace kthread freezing with filesystem freeze/thaw Luis R. Rodriguez
2017-10-03 18:53 ` [RFC 1/5] fs: add iterate_supers_reverse() Luis R. Rodriguez
2017-10-03 18:53 ` [RFC 2/5] fs: freeze on suspend and thaw on resume Luis R. Rodriguez
2017-10-03 20:02 ` Bart Van Assche
2017-10-03 20:02 ` Bart Van Assche
2017-10-03 20:23 ` Luis R. Rodriguez
2017-10-03 20:23 ` Luis R. Rodriguez
2017-10-03 20:32 ` Bart Van Assche
2017-10-03 20:32 ` Bart Van Assche
2017-10-03 20:32 ` Bart Van Assche
2017-10-03 20:32 ` Bart Van Assche
2017-10-03 20:39 ` Luis R. Rodriguez
2017-10-03 20:39 ` Luis R. Rodriguez
2017-10-03 20:06 ` Jiri Kosina
2017-10-03 20:58 ` Dave Chinner
2017-10-03 21:16 ` Luis R. Rodriguez
2017-10-03 18:53 ` [RFC 3/5] xfs: allow fs freeze on suspend/hibernation Luis R. Rodriguez
2017-10-03 18:53 ` [RFC 4/5] ext4: add fs freezing support " Luis R. Rodriguez
2017-10-03 19:59 ` Theodore Ts'o
2017-10-03 20:13 ` Luis R. Rodriguez
2017-10-04 1:42 ` Theodore Ts'o
2017-10-04 7:05 ` Dave Chinner
2017-10-04 15:25 ` Bart Van Assche
2017-10-04 15:25 ` Bart Van Assche
2017-10-04 15:25 ` Bart Van Assche
2017-10-04 15:25 ` Bart Van Assche
2017-10-04 16:48 ` Theodore Ts'o
2017-10-04 22:22 ` Dave Chinner
2017-10-03 18:53 ` [RFC 5/5] pm: remove kernel thread freezing Luis R. Rodriguez
2017-10-03 18:59 ` Rafael J. Wysocki
2017-10-03 21:15 ` Rafael J. Wysocki
2017-10-04 0:47 ` Luis R. Rodriguez
2017-10-04 1:03 ` Bart Van Assche
2017-10-04 1:03 ` Bart Van Assche
2017-10-04 1:03 ` Bart Van Assche
2017-11-29 23:05 ` Luis R. Rodriguez
2017-11-29 23:05 ` Luis R. Rodriguez
2017-10-04 7:18 ` Dave Chinner
2017-10-03 20:12 ` Pavel Machek
2017-10-03 20:15 ` Jiri Kosina
2017-10-03 20:21 ` Pavel Machek
2017-10-03 20:38 ` Jiri Kosina
2017-10-03 20:41 ` Rafael J. Wysocki
2017-10-03 20:57 ` Pavel Machek
2017-10-03 21:00 ` Jiri Kosina
2017-10-03 21:09 ` Shuah Khan
2017-10-03 21:18 ` Luis R. Rodriguez
2017-10-03 20:49 ` Luis R. Rodriguez
2017-10-06 12:07 ` Pavel Machek
2017-10-06 12:54 ` Theodore Ts'o
2017-10-03 20:13 ` Bart Van Assche
2017-10-03 20:13 ` Bart Van Assche
2017-10-03 20:17 ` Jiri Kosina
2017-10-03 20:17 ` Jiri Kosina
2017-10-03 20:21 ` Bart Van Assche [this message]
2017-10-03 20:21 ` Bart Van Assche
2017-10-03 20:21 ` Bart Van Assche
2017-10-03 20:24 ` Jiri Kosina
2017-10-03 20:24 ` Jiri Kosina
2017-10-03 20:27 ` Luis R. Rodriguez
2017-10-03 20:27 ` Luis R. Rodriguez
2017-10-03 20:51 ` Jiri Kosina
2017-10-03 20:51 ` Jiri Kosina
2017-10-03 21:04 ` Dave Chinner
2017-10-03 21:07 ` Luis R. Rodriguez
2017-10-04 6:07 ` Hannes Reinecke
2017-10-03 19:33 ` [RFC 0/5] fs: replace kthread freezing with filesystem freeze/thaw Ming Lei
2017-10-03 20:05 ` Luis R. Rodriguez
2017-10-03 20:47 ` Matthew Wilcox
2017-10-03 20:54 ` Luis R. Rodriguez
2017-10-03 20:59 ` Bart Van Assche
2017-10-03 20:59 ` Bart Van Assche
2017-10-03 20:59 ` Bart Van Assche
2017-10-04 15:43 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507062101.2567.16.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=ONeukum@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=jgross@suse.com \
--cc=jikos@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ming.lei@redhat.com \
--cc=nborisov@suse.com \
--cc=oleg.b.antonyan@gmail.com \
--cc=oleksandr@natalenko.name \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=todd.e.brandt@linux.intel.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.