From: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] branch: change the error messages to be more meaningful
Date: Wed, 04 Oct 2017 18:16:14 +0530 [thread overview]
Message-ID: <1507121174.2245.3.camel@gmail.com> (raw)
In-Reply-To: <xmqqwp4beemb.fsf@gitster.mtv.corp.google.com>
On Wed, 2017-10-04 at 13:11 +0900, Junio C Hamano wrote:
>
> It is a bit dissapointing that we do not need to touch tests, as it
> indicates that the logic to diagnose extra arguments as an error has
> no coverage.
Even if there were tests I don't think they would have needed any
updation as most of the tests (at least those that I came across) that
check for failure seem not to be checking for what error message gets
printed. They seem to test only if the command fails (using
test_must_fail in most cases, I guess).
Moreover, as a consequence of my assumption that the tests don't check
for the error messages themselves; I haven't even thought of checking
whether the tests or the travis-ci build succeeded as a consequence of
my patches that touch "only" the error messages!
---
Kaartic
next prev parent reply other threads:[~2017-10-04 12:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 14:39 [PATCH] branch: change the error messages to be more meaningful Kaartic Sivaraam
2017-07-25 18:28 ` Kaartic Sivaraam
2017-07-25 18:31 ` Kaartic Sivaraam
2017-07-30 11:59 ` Kaartic Sivaraam
2017-08-21 13:36 ` [PATCH v2] " Kaartic Sivaraam
2017-10-02 17:19 ` Kaartic Sivaraam
2017-10-03 0:21 ` Junio C Hamano
2017-10-03 19:14 ` Kaartic Sivaraam
2017-10-04 4:11 ` Junio C Hamano
2017-10-04 12:46 ` Kaartic Sivaraam [this message]
2017-10-05 1:13 ` Junio C Hamano
2017-10-05 12:13 ` Kaartic Sivaraam
-- strict thread matches above, loose matches on Subject: below --
2017-07-15 8:33 [PATCH] commit & merge: modularize the empty message validator Kaartic Sivaraam
2017-08-21 13:34 ` [PATCH v2] branch: change the error messages to be more meaningful Kaartic Sivaraam
2017-08-21 13:52 ` Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507121174.2245.3.camel@gmail.com \
--to=kaarticsivaraam91196@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.