From: Luciano Coelho <luciano.coelho@intel.com>
To: "Christoph Böhmwalder" <christoph@boehmwalder.at>,
johannes.berg@intel.com, emmanuel.grumbach@intel.com,
kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] wireless: iwlwifi: function definition cosmetic fix
Date: Wed, 04 Oct 2017 19:13:30 +0300 [thread overview]
Message-ID: <1507133610.908.89.camel@intel.com> (raw)
In-Reply-To: <20171004155700.18048-3-christoph@boehmwalder.at>
On Wed, 2017-10-04 at 17:56 +0200, Christoph Böhmwalder wrote:
> Separate the function from the previous definition with a newline and
> put the `static` keyword on the same line, as it just looks nicer.
>
> Signed-off-by: Christoph Böhmwalder <christoph@boehmwalder.at>
> ---
> drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c b/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c
> index 0eb815ae97e8..249ee1c7b02f 100644
> --- a/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c
> +++ b/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c
> @@ -325,8 +325,8 @@ static u16 channel_id_to_txp(struct iwl_phy_db *phy_db, u16 ch_id)
> }
> return 0xff;
> }
> -static
> -int iwl_phy_db_get_section_data(struct iwl_phy_db *phy_db,
> +
> +static int iwl_phy_db_get_section_data(struct iwl_phy_db *phy_db,
> u32 type, u8 **data, u16 *size, u16 ch_id)
> {
> struct iwl_phy_db_entry *entry;
Sorry, but this now looks much uglier because the second line is not
even aligned to the parenthesis.
NACK.
--
Luca.
next prev parent reply other threads:[~2017-10-04 16:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 15:56 [PATCH 0/3] iwlwifi: cosmetic fixes Christoph Böhmwalder
2017-10-04 15:56 ` [PATCH 1/3] wireless: iwlwifi: use bool instead of int Christoph Böhmwalder
2017-10-04 16:15 ` Luciano Coelho
2017-10-04 16:26 ` Joe Perches
2017-10-04 16:39 ` Luciano Coelho
2017-10-04 17:55 ` Joe Perches
2017-10-04 19:18 ` Luciano Coelho
2017-10-04 15:56 ` [PATCH 2/3] wireless: iwlwifi: function definition cosmetic fix Christoph Böhmwalder
2017-10-04 16:13 ` Luciano Coelho [this message]
2017-10-04 15:57 ` [PATCH 3/3] wireless: iwlwifi: wrap macro into braces Christoph Böhmwalder
2017-10-04 16:08 ` Johannes Berg
2017-10-04 16:14 ` Joe Perches
2017-10-04 16:21 ` [PATCH 0/3] iwlwifi: cosmetic fixes Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507133610.908.89.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=christoph@boehmwalder.at \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.