* [PATCH] RDMA/hns: return 0 rather than return a garbage status value
@ 2017-09-29 20:13 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2017-09-29 20:13 UTC (permalink / raw)
To: Lijun Ou, Wei Hu, Doug Ledford, Sean Hefty, Hal Rosenstock,
linux-rdma
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
For the case where hr_qp->state == IB_QPS_RESET, an uninitialized
value in ret is being returned by function hns_roce_v2_query_qp.
Fix this by setting ret to 0 for this specific return condition.
Detected by CoverityScan, CID#1457203 ("Unitialized scalar variable")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
index 4870b51caab9..791dae72e775 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
@@ -2805,6 +2805,7 @@ static int hns_roce_v2_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr,
if (hr_qp->state == IB_QPS_RESET) {
qp_attr->qp_state = IB_QPS_RESET;
+ ret = 0;
goto done;
}
--
2.14.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] RDMA/hns: return 0 rather than return a garbage status value
@ 2017-09-29 20:13 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2017-09-29 20:13 UTC (permalink / raw)
To: Lijun Ou, Wei Hu, Doug Ledford, Sean Hefty, Hal Rosenstock,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
For the case where hr_qp->state == IB_QPS_RESET, an uninitialized
value in ret is being returned by function hns_roce_v2_query_qp.
Fix this by setting ret to 0 for this specific return condition.
Detected by CoverityScan, CID#1457203 ("Unitialized scalar variable")
Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
---
drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
index 4870b51caab9..791dae72e775 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
@@ -2805,6 +2805,7 @@ static int hns_roce_v2_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr,
if (hr_qp->state == IB_QPS_RESET) {
qp_attr->qp_state = IB_QPS_RESET;
+ ret = 0;
goto done;
}
--
2.14.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status value
2017-09-29 20:13 ` Colin King
(?)
@ 2017-09-30 7:11 ` Wei Hu (Xavier)
-1 siblings, 0 replies; 8+ messages in thread
From: Wei Hu (Xavier) @ 2017-09-30 7:11 UTC (permalink / raw)
To: Colin King, Doug Ledford, Sean Hefty
Cc: Lijun Ou, Hal Rosenstock, linux-rdma, kernel-janitors,
linux-kernel
Thanks, Colin Ian King
Acked-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
On 2017/9/30 4:13, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> For the case where hr_qp->state = IB_QPS_RESET, an uninitialized
> value in ret is being returned by function hns_roce_v2_query_qp.
> Fix this by setting ret to 0 for this specific return condition.
>
> Detected by CoverityScan, CID#1457203 ("Unitialized scalar variable")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> index 4870b51caab9..791dae72e775 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> @@ -2805,6 +2805,7 @@ static int hns_roce_v2_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr,
>
> if (hr_qp->state = IB_QPS_RESET) {
> qp_attr->qp_state = IB_QPS_RESET;
> + ret = 0;
> goto done;
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status value
@ 2017-09-30 7:11 ` Wei Hu (Xavier)
0 siblings, 0 replies; 8+ messages in thread
From: Wei Hu (Xavier) @ 2017-09-30 7:11 UTC (permalink / raw)
To: Colin King, Doug Ledford, Sean Hefty
Cc: Lijun Ou, Hal Rosenstock, linux-rdma, kernel-janitors,
linux-kernel
Thanks, Colin Ian King
Acked-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
On 2017/9/30 4:13, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> For the case where hr_qp->state == IB_QPS_RESET, an uninitialized
> value in ret is being returned by function hns_roce_v2_query_qp.
> Fix this by setting ret to 0 for this specific return condition.
>
> Detected by CoverityScan, CID#1457203 ("Unitialized scalar variable")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> index 4870b51caab9..791dae72e775 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> @@ -2805,6 +2805,7 @@ static int hns_roce_v2_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr,
>
> if (hr_qp->state == IB_QPS_RESET) {
> qp_attr->qp_state = IB_QPS_RESET;
> + ret = 0;
> goto done;
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status value
@ 2017-09-30 7:11 ` Wei Hu (Xavier)
0 siblings, 0 replies; 8+ messages in thread
From: Wei Hu (Xavier) @ 2017-09-30 7:11 UTC (permalink / raw)
To: Colin King, Doug Ledford, Sean Hefty
Cc: Lijun Ou, Hal Rosenstock, linux-rdma, kernel-janitors,
linux-kernel
Thanks, Colin Ian King
Acked-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
On 2017/9/30 4:13, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> For the case where hr_qp->state == IB_QPS_RESET, an uninitialized
> value in ret is being returned by function hns_roce_v2_query_qp.
> Fix this by setting ret to 0 for this specific return condition.
>
> Detected by CoverityScan, CID#1457203 ("Unitialized scalar variable")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> index 4870b51caab9..791dae72e775 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> @@ -2805,6 +2805,7 @@ static int hns_roce_v2_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr,
>
> if (hr_qp->state == IB_QPS_RESET) {
> qp_attr->qp_state = IB_QPS_RESET;
> + ret = 0;
> goto done;
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status value
2017-09-29 20:13 ` Colin King
@ 2017-10-04 18:40 ` Doug Ledford
-1 siblings, 0 replies; 8+ messages in thread
From: Doug Ledford @ 2017-10-04 18:40 UTC (permalink / raw)
To: Colin King, Lijun Ou, Wei Hu, Sean Hefty, Hal Rosenstock,
linux-rdma
Cc: kernel-janitors, linux-kernel
On Fri, 2017-09-29 at 21:13 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> For the case where hr_qp->state = IB_QPS_RESET, an uninitialized
> value in ret is being returned by function hns_roce_v2_query_qp.
> Fix this by setting ret to 0 for this specific return condition.
>
> Detected by CoverityScan, CID#1457203 ("Unitialized scalar variable")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status value
@ 2017-10-04 18:40 ` Doug Ledford
0 siblings, 0 replies; 8+ messages in thread
From: Doug Ledford @ 2017-10-04 18:40 UTC (permalink / raw)
To: Colin King, Lijun Ou, Wei Hu, Sean Hefty, Hal Rosenstock,
linux-rdma
Cc: kernel-janitors, linux-kernel
On Fri, 2017-09-29 at 21:13 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> For the case where hr_qp->state == IB_QPS_RESET, an uninitialized
> value in ret is being returned by function hns_roce_v2_query_qp.
> Fix this by setting ret to 0 for this specific return condition.
>
> Detected by CoverityScan, CID#1457203 ("Unitialized scalar variable")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
^ permalink raw reply [flat|nested] 8+ messages in thread