All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard =?unknown-8bit?q?R=C3=B6jfors?= <richard.rojfors@gmail.com>
To: ofono@ofono.org
Subject: [PATCH] ublox: Disable DCD to avoid HUP when leaving data mode.
Date: Wed, 04 Oct 2017 20:49:30 +0200	[thread overview]
Message-ID: <1507142970.10910.2.camel@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

The HUP results in errors in gatio which will deref parts
of the AT channel. This makes it impossible to recover and
send further AT commands after the HUP.
---
 plugins/ublox.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/plugins/ublox.c b/plugins/ublox.c
index 250a5be4..5611ef5c 100644
--- a/plugins/ublox.c
+++ b/plugins/ublox.c
@@ -200,6 +200,8 @@ static int ublox_enable(struct ofono_modem *modem)
 
 		g_at_chat_send(data->modem, "ATE0 +CMEE=1", none_prefix,
 						NULL, NULL, NULL);
+
+		g_at_chat_send(data->modem, "AT&C0", NULL, NULL, NULL, NULL);
 	}
 
 	/* The modem can take a while to wake up if just powered on. */
-- 
2.11.0

             reply	other threads:[~2017-10-04 18:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04 18:49 Richard =?unknown-8bit?q?R=C3=B6jfors?= [this message]
2017-10-05 16:21 ` [PATCH] ublox: Disable DCD to avoid HUP when leaving data mode Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507142970.10910.2.camel@gmail.com \
    --to=richard.rojfors@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.