From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbrunet@baylibre.com (Jerome Brunet) Date: Thu, 05 Oct 2017 13:47:48 +0200 Subject: [PATCH 1/8] pinctrl: meson: remove offset from pinctrl In-Reply-To: References: <20170920133927.17390-1-jbrunet@baylibre.com> <20170920133927.17390-2-jbrunet@baylibre.com> Message-ID: <1507204068.17300.204.camel@baylibre.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Thu, 2017-10-05 at 13:22 +0200, Linus Walleij wrote: > On Wed, Sep 20, 2017 at 3:39 PM, Jerome Brunet wrote: > > > Offset on meson pinctrl and gpios is something that was carried from the > > vendor driver, where there is a weird link between the 2 > > controllers. Since these 2 controllers are independent, this offset adds > > an unnecessary complexity. > > > > This patch remove this manually set offset and rely on pinctrl to figure > > out the gpio base offset > > > > Tested-by: Martin Blumenstingl > > Signed-off-by: Jerome Brunet > > Patch applied. Thx Linus. Just to be sure, did you remember to squash patch 1 to 5 together ? I know it is a bit unusual but, as explained earlier, those patches were only split to ease the review. Keeping the change split would break bisect. > > Yours, > Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Subject: Re: [PATCH 1/8] pinctrl: meson: remove offset from pinctrl Date: Thu, 05 Oct 2017 13:47:48 +0200 Message-ID: <1507204068.17300.204.camel@baylibre.com> References: <20170920133927.17390-1-jbrunet@baylibre.com> <20170920133927.17390-2-jbrunet@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Kevin Hilman , Carlo Caione , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Amlogic Meson..." , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Martin Blumenstingl List-Id: linux-gpio@vger.kernel.org On Thu, 2017-10-05 at 13:22 +0200, Linus Walleij wrote: > On Wed, Sep 20, 2017 at 3:39 PM, Jerome Brunet wrote: > > > Offset on meson pinctrl and gpios is something that was carried from the > > vendor driver, where there is a weird link between the 2 > > controllers. Since these 2 controllers are independent, this offset adds > > an unnecessary complexity. > > > > This patch remove this manually set offset and rely on pinctrl to figure > > out the gpio base offset > > > > Tested-by: Martin Blumenstingl > > Signed-off-by: Jerome Brunet > > Patch applied. Thx Linus. Just to be sure, did you remember to squash patch 1 to 5 together ? I know it is a bit unusual but, as explained earlier, those patches were only split to ease the review. Keeping the change split would break bisect. > > Yours, > Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbrunet@baylibre.com (Jerome Brunet) Date: Thu, 05 Oct 2017 13:47:48 +0200 Subject: [PATCH 1/8] pinctrl: meson: remove offset from pinctrl In-Reply-To: References: <20170920133927.17390-1-jbrunet@baylibre.com> <20170920133927.17390-2-jbrunet@baylibre.com> Message-ID: <1507204068.17300.204.camel@baylibre.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2017-10-05 at 13:22 +0200, Linus Walleij wrote: > On Wed, Sep 20, 2017 at 3:39 PM, Jerome Brunet wrote: > > > Offset on meson pinctrl and gpios is something that was carried from the > > vendor driver, where there is a weird link between the 2 > > controllers. Since these 2 controllers are independent, this offset adds > > an unnecessary complexity. > > > > This patch remove this manually set offset and rely on pinctrl to figure > > out the gpio base offset > > > > Tested-by: Martin Blumenstingl > > Signed-off-by: Jerome Brunet > > Patch applied. Thx Linus. Just to be sure, did you remember to squash patch 1 to 5 together ? I know it is a bit unusual but, as explained earlier, those patches were only split to ease the review. Keeping the change split would break bisect. > > Yours, > Linus Walleij