diff for duplicates of <1507210761.20822.2.camel@primarydata.com> diff --git a/a/1.txt b/N1/1.txt index 4b8f8e4..17dcdc9 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,18 +1,33 @@ -SGkgSmFuLA0KDQpPbiBUaHUsIDIwMTctMTAtMDUgYXQgMTA6MzYgKzAyMDAsIEphbiBLYXJhIHdy -b3RlOg0KPiBIZWxsbywNCj4gDQo+IEknbSBkb2luZyBzb21lIHdvcmsgaW4gcGFnZSBjYWNoZSBo -YW5kbGluZyBhbmQgSSBoYXZlIG5vdGljZWQgdGhhdA0KPiBORlMgaXMNCj4gdGhlIG9ubHkgdXNl -ciBvZiBtYXBwaW5nLT5hX29wcy0+ZnJlZXBhZ2UgY2FsbGJhY2suIEZyb20gYSBxdWljayBsb29r -DQo+IEkNCj4gZG9uJ3Qgc2VlIHdoeSBpc24ndCBORlMgdXNpbmcgLT5yZWxlYXNlcGFnZSAvIC0+ -aW52YWxpZGF0ZXBhZ2UNCj4gY2FsbGJhY2sgYXMNCj4gYWxsIG90aGVyIGZpbGVzeXN0ZW1zIGRv -PyBJIGFncmVlIHlvdSB3b3VsZCBoYXZlIHRvIHNldCBQYWdlUHJpdmF0ZQ0KPiBiaXQgZm9yDQo+ -IHRob3NlIHRvIGdldCBjYWxsZWQgZm9yIHRoZSBkaXJlY3RvcnkgbWFwcGluZyBob3dldmVyIHRo -YXQgd291bGQgc2VlbQ0KPiBsaWtlDQo+IGEgY2xlYW5lciB0aGluZyB0byBkbyBhbnl3YXkgLSBp -biBmYWN0IHlvdSBkbyBoYXZlIHByaXZhdGUgZGF0YSBpbg0KPiB0aGUNCj4gcGFnZS4gIEp1c3Qg -dGhleSBhcmUgbm90IHBvaW50ZWQgdG8gYnkgcGFnZS0+cHJpdmF0ZSBidXQgaW5zdGVhZCBhcmUN -Cj4gc3RvcmVkDQo+IGFzIHBhZ2UgZGF0YS4uLiBBbSBJIG1pc3Npbmcgc29tZXRoaW5nPw0KPiAN -Cj4gCQkJCQkJCQlIb256YQ0KDQpJJ20gbm90IHVuZGVyc3RhbmRpbmcgeW91ciBwb2ludC4gZGVs -ZXRlX2Zyb21fcGFnZV9jYWNoZSgpIGRvZXNuJ3QgY2FsbA0KcmVsZWFzZXBhZ2UgQUZBSUNTLg0K -DQpUaGUgcG9pbnQgb2YgZnJlZXBhZ2UgaXMgdGhhdCBpdCBpcyBjYWxsZWQgYWZ0ZXIgdGhlIHBh -Z2UgaGFzIGJlZW4NCnJlbW92ZWQgZnJvbSB0aGUgcGFnZSBjYWNoZS4NCg0KLS0gDQpUcm9uZCBN -eWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRhaW5lciwgUHJpbWFyeURhdGENCnRyb25k -Lm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg== +Hi Jan, + +On Thu, 2017-10-05 at 10:36 +0200, Jan Kara wrote: +> Hello, +> +> I'm doing some work in page cache handling and I have noticed that +> NFS is +> the only user of mapping->a_ops->freepage callback. From a quick look +> I +> don't see why isn't NFS using ->releasepage / ->invalidatepage +> callback as +> all other filesystems do? I agree you would have to set PagePrivate +> bit for +> those to get called for the directory mapping however that would seem +> like +> a cleaner thing to do anyway - in fact you do have private data in +> the +> page. Just they are not pointed to by page->private but instead are +> stored +> as page data... Am I missing something? +> +> Honza + +I'm not understanding your point. delete_from_page_cache() doesn't call +releasepage AFAICS. + +The point of freepage is that it is called after the page has been +removed from the page cache. + +-- +Trond Myklebust +Linux NFS client maintainer, PrimaryData +trond.myklebust@primarydata.com diff --git a/a/content_digest b/N1/content_digest index dfac0f2..77864a7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -8,23 +8,38 @@ "Cc\0anna.schumaker@netapp.com <anna.schumaker@netapp.com>\0" "\00:1\0" "b\0" - "SGkgSmFuLA0KDQpPbiBUaHUsIDIwMTctMTAtMDUgYXQgMTA6MzYgKzAyMDAsIEphbiBLYXJhIHdy\n" - "b3RlOg0KPiBIZWxsbywNCj4gDQo+IEknbSBkb2luZyBzb21lIHdvcmsgaW4gcGFnZSBjYWNoZSBo\n" - "YW5kbGluZyBhbmQgSSBoYXZlIG5vdGljZWQgdGhhdA0KPiBORlMgaXMNCj4gdGhlIG9ubHkgdXNl\n" - "ciBvZiBtYXBwaW5nLT5hX29wcy0+ZnJlZXBhZ2UgY2FsbGJhY2suIEZyb20gYSBxdWljayBsb29r\n" - "DQo+IEkNCj4gZG9uJ3Qgc2VlIHdoeSBpc24ndCBORlMgdXNpbmcgLT5yZWxlYXNlcGFnZSAvIC0+\n" - "aW52YWxpZGF0ZXBhZ2UNCj4gY2FsbGJhY2sgYXMNCj4gYWxsIG90aGVyIGZpbGVzeXN0ZW1zIGRv\n" - "PyBJIGFncmVlIHlvdSB3b3VsZCBoYXZlIHRvIHNldCBQYWdlUHJpdmF0ZQ0KPiBiaXQgZm9yDQo+\n" - "IHRob3NlIHRvIGdldCBjYWxsZWQgZm9yIHRoZSBkaXJlY3RvcnkgbWFwcGluZyBob3dldmVyIHRo\n" - "YXQgd291bGQgc2VlbQ0KPiBsaWtlDQo+IGEgY2xlYW5lciB0aGluZyB0byBkbyBhbnl3YXkgLSBp\n" - "biBmYWN0IHlvdSBkbyBoYXZlIHByaXZhdGUgZGF0YSBpbg0KPiB0aGUNCj4gcGFnZS4gIEp1c3Qg\n" - "dGhleSBhcmUgbm90IHBvaW50ZWQgdG8gYnkgcGFnZS0+cHJpdmF0ZSBidXQgaW5zdGVhZCBhcmUN\n" - "Cj4gc3RvcmVkDQo+IGFzIHBhZ2UgZGF0YS4uLiBBbSBJIG1pc3Npbmcgc29tZXRoaW5nPw0KPiAN\n" - "Cj4gCQkJCQkJCQlIb256YQ0KDQpJJ20gbm90IHVuZGVyc3RhbmRpbmcgeW91ciBwb2ludC4gZGVs\n" - "ZXRlX2Zyb21fcGFnZV9jYWNoZSgpIGRvZXNuJ3QgY2FsbA0KcmVsZWFzZXBhZ2UgQUZBSUNTLg0K\n" - "DQpUaGUgcG9pbnQgb2YgZnJlZXBhZ2UgaXMgdGhhdCBpdCBpcyBjYWxsZWQgYWZ0ZXIgdGhlIHBh\n" - "Z2UgaGFzIGJlZW4NCnJlbW92ZWQgZnJvbSB0aGUgcGFnZSBjYWNoZS4NCg0KLS0gDQpUcm9uZCBN\n" - "eWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRhaW5lciwgUHJpbWFyeURhdGENCnRyb25k\n" - Lm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg== + "Hi Jan,\n" + "\n" + "On Thu, 2017-10-05 at 10:36 +0200, Jan Kara wrote:\n" + "> Hello,\n" + "> \n" + "> I'm doing some work in page cache handling and I have noticed that\n" + "> NFS is\n" + "> the only user of mapping->a_ops->freepage callback. From a quick look\n" + "> I\n" + "> don't see why isn't NFS using ->releasepage / ->invalidatepage\n" + "> callback as\n" + "> all other filesystems do? I agree you would have to set PagePrivate\n" + "> bit for\n" + "> those to get called for the directory mapping however that would seem\n" + "> like\n" + "> a cleaner thing to do anyway - in fact you do have private data in\n" + "> the\n" + "> page. Just they are not pointed to by page->private but instead are\n" + "> stored\n" + "> as page data... Am I missing something?\n" + "> \n" + "> \t\t\t\t\t\t\t\tHonza\n" + "\n" + "I'm not understanding your point. delete_from_page_cache() doesn't call\n" + "releasepage AFAICS.\n" + "\n" + "The point of freepage is that it is called after the page has been\n" + "removed from the page cache.\n" + "\n" + "-- \n" + "Trond Myklebust\n" + "Linux NFS client maintainer, PrimaryData\n" + trond.myklebust@primarydata.com -0bd8f69db568e2fbea676cc016881aaf82d39d10f97e0df46bb49459dbf168bb +cb070355ec4969401ba07adde67eaea1269df20cdaf0bc8ba3a7bd48da80bc95
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.