From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v5 3/5] drm/i915/guc: Move GuC core definitions into dedicated files
Date: Thu, 05 Oct 2017 20:04:10 +0300 [thread overview]
Message-ID: <1507223050.14125.2.camel@linux.intel.com> (raw)
In-Reply-To: <20171004181343.66348-4-michal.wajdeczko@intel.com>
On Wed, 2017-10-04 at 18:13 +0000, Michal Wajdeczko wrote:
> Move GuC core definitions into dedicated files as we want to
> keep GuC specific code in separated files.
>
> v2: move all functions in single patch (Joonas)
> fix old checkpatch issues (Sagar)
>
> v3: rebased
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> Reviewed-by: Sagar Arun Kamble <sagar.a.kamble@intel.com> #1
<SNIP>
> +static
> +inline int intel_guc_send(struct intel_guc *guc, const u32 *action, u32 len)
Split this at the correct boundary between return type and function
name. Then this is;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-05 17:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 18:13 [PATCH v5 0/5] drm/i915: Guc code reorg cont'd Michal Wajdeczko
2017-10-04 18:13 ` [PATCH v5 1/5] drm/i915/guc: Move GuC log declarations into dedicated header Michal Wajdeczko
2017-10-04 18:13 ` [PATCH v5 2/5] drm/i915/guc: Move GuC submission " Michal Wajdeczko
2017-10-04 18:13 ` [PATCH v5 3/5] drm/i915/guc: Move GuC core definitions into dedicated files Michal Wajdeczko
2017-10-05 9:25 ` Sagar Arun Kamble
2017-10-05 17:04 ` Joonas Lahtinen [this message]
2017-10-04 18:13 ` [PATCH v5 4/5] drm/i915/uc: Fix includes order Michal Wajdeczko
2017-10-05 17:04 ` Joonas Lahtinen
2017-10-04 18:13 ` [PATCH v5 5/5] drm/i915/uc: Unify initialization of the uC firmware helper Michal Wajdeczko
2017-10-05 17:08 ` Joonas Lahtinen
2017-10-04 19:06 ` ✓ Fi.CI.BAT: success for drm/i915: Guc code reorg cont'd Patchwork
2017-10-04 22:54 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507223050.14125.2.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.